-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] Hide encoding and dead_letter_* from Peeked Message #14733
Changes from all commits
645cd60
7bb3914
28531ad
c859e4c
bbcab5a
94d7734
cb9607c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,11 +28,11 @@ | |
|
||
|
||
class BaseSession(object): | ||
def __init__(self, session_id, receiver, encoding="UTF-8"): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would LOVE to change this to keyword only instead There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't have a strong preference here, either works for me as session is something that user shouldn't create by themselves, and we don't document it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm inclined not to because of what Adam said. Kwarg hiding is workable for public surface areas, but still suboptimal there, and in a way that I'm nervous to expose us to internally: namely, you don't notice typod arguments any more. Let me know if this isn't a convincing argument and I can try harder, don't want to come in and flip the table :P |
||
# type: (str, Union[ServiceBusReceiver, ServiceBusReceiverAsync], str) -> None | ||
def __init__(self, session_id, receiver): | ||
# type: (str, Union[ServiceBusReceiver, ServiceBusReceiverAsync]) -> None | ||
self._session_id = session_id | ||
self._receiver = receiver | ||
self._encoding = encoding | ||
self._encoding = "UTF-8" | ||
self._session_start = None | ||
self._locked_until_utc = None # type: Optional[datetime.datetime] | ||
self.auto_renew_error = None | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclining towards just stopping to document the
encoding
keyword since we just want to hide it for now - thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seconded.