Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated notebooks to make them more "general" #15660

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

BillmanH
Copy link
Contributor

@BillmanH BillmanH commented Dec 7, 2020

I created a group of notebooks that I think cover the "Analyst Experience". The 4 notebooks take you step by step through the process of creating twins/models/ and relationships.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Dec 7, 2020
@ghost
Copy link

ghost commented Dec 7, 2020

Thank you for your contribution BillmanH! We will review the pull request and get back to you soon.

@ghost
Copy link

ghost commented Dec 7, 2020

CLA assistant check
All CLA requirements met.

@check-enforcer
Copy link

check-enforcer bot commented Dec 7, 2020

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@elhorton
Copy link

elhorton commented Dec 7, 2020

Hi @mayurid @lmazuel and @annatisch , @zolvarga and I have talked with Bill about adding these notebooks as samples for the ADT SDK as they showcase the analyst use case, could you please help us get these merged or let us know of any changes you suggest? Thanks!

@annatisch
Copy link
Member

Thank you @BillmanH, @elhorton - this is awesome - thank you for contributing samples!
@czubair, @maggiepint - do we have any guidance on adding these kinds of more comprehensive samples into the repo? Do we typically keep them in this repo, or elsewhere?

@BillmanH BillmanH requested a review from annatisch December 8, 2020 23:00
@BillmanH
Copy link
Contributor Author

@elhorton, @czubair, @maggiepint, On thinking about this Is this the best place for notebooks? I was looking at some other Azure repositories and saw that they have separate repos for notebooks. Is that something you can set up for digital twin? Here's an example from azure machine learning. It may be better to attach them in that way. What do you think?

@elhorton
Copy link

@elhorton, @czubair, @maggiepint, On thinking about this Is this the best place for notebooks? I was looking at some other Azure repositories and saw that they have separate repos for notebooks. Is that something you can set up for digital twin? Here's an example from azure machine learning. It may be better to attach them in that way. What do you think?

Adding in my thoughts-- I think for now, since the Jupyter notebooks run the Python ADT SDK, this repo would be a good place for them as they're high quality samples and most discoverable here. However, if @maggiepint or @czubair don't think the Azure SDK repo is a good location, then I absolutely think we should set up a generic ADT samples repo-- I'd collaborate with the ADT team to help get that set up. @maggiepint @czubair @annatisch do you have thoughts on this? let us know if it's easier to chat this through.

@lmazuel lmazuel removed their request for review December 29, 2020 23:18
@elhorton
Copy link

@maggiepint or @czubair , can you please help with this? Would love to get this merged. Thanks.

@lmazuel
Copy link
Member

lmazuel commented Sep 13, 2021

Even if we're unsure of the right place, I prefer merge the PR than to let it open. We can move the files as necessary. @annatisch CC

@lmazuel lmazuel merged commit 3eb0af9 into Azure:main Sep 13, 2021
zihzhan-msft added a commit that referenced this pull request Sep 20, 2021
commit 7832c5a
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Sat Sep 18 09:34:11 2021 +0800

    [AutoRelease] t2-eventhub-2021-09-17-55263(Do not merge) (#20739)

    * CodeGen from PR 15979 in Azure/azure-rest-api-specs
    EventHub: Added missing Cluster API in 2021-06-01-preview (#15979)

    * Added missing Cluster APIs to 2021-01-01-preview

    * added cluster API in 2021-06-01-preview

    * updated lint errors

    * update 1

    * added listbysubscription

    * fixed ModelValidation

    Co-authored-by: v-ajnava <v-ajnava@microsoft.com>

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 29d98e8
Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Date:   Fri Sep 17 17:27:57 2021 -0700

    Fix broken link in python repo (#20746)

commit cbfacbd
Author: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
Date:   Fri Sep 17 14:04:28 2021 -0700

    [Storage]Unify service version and update changelog (#20723)

    * [Storage]Unify service version and update changelog

    * fix test

commit ea5ecea
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Fri Sep 17 10:19:31 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2010 (#20729)

    * Remove empty sections in changelog entry as part of prepare release

    * Update SECTIONS_HEADER_REGEX to accomodate various header levels

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 9b63801
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Fri Sep 17 15:00:44 2021 +0800

    [AutoRelease] t2-azurearcdata-2021-09-15-74995 (#20714)

    * CodeGen from PR 15874 in Azure/azure-rest-api-specs
    Adding 202 Accepted for deletion call (#15874)

    * Adding 202 for deletion call

    * Adding headers to suppress warnings

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 0645f49
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Thu Sep 16 15:58:10 2021 -0700

    [Test Proxy] Make add_sanitizer a module-level method (#20701)

commit ddf49b1
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Thu Sep 16 15:27:08 2021 -0700

    [Test proxy] Add migration guide (#20469)

commit e116660
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Thu Sep 16 12:33:48 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2011 (#20702)

    * Common pipeline template and script to detect API changes

    * Cahnges as per review comments

    * Review comment changes

    * CCahgnes as per review comments

    * Show warning for list of failed packages to detect API changes

    * Apply suggestions from code review

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
    Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 44e2acf
Author: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Date:   Thu Sep 16 10:57:23 2021 -0700

    protobuf to handle python 2.7 issues (#20725)

commit 81c6aa0
Author: Xiang Yan <xiangsjtu@gmail.com>
Date:   Thu Sep 16 08:33:08 2021 -0700

    add troubleshoot doc (#20684)

    * add troubleshoot doc

    * fix typo

    * update

    * update

    * update

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update Troubleshoot.md

    * update error log

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

commit 87e0f99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 15:32:41 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2016 (#20706)

    * Make ServiceName optional for verify-changelog

    In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

    * Put quotes around the strings to allow for empty

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit c80e26e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 12:45:42 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2009 (#20672)

    * Skip PSModule caching in container jobs

    * Add succeeded check to condition

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
    Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 1efff7f
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Wed Sep 15 10:53:42 2021 -0700

    [Search] Add skillset validation (#20669)

    * Add client-side validation and test.

    * Add skillset validation test.

    * Make code more Pythonic.

commit 6a06b0e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Sep 14 16:56:19 2021 -0700

    Add for multiple levels of Atx Headers in the CHANGELOG.md (#20694)

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3fdbaa7
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 16:27:06 2021 -0700

    [EventHub] update arm template with storage conn str (#20376)

    * update test resources

    * fix

    * fix failing tests

    * adams comments

    * pylint

    * remove dateutil

    * adams comments

    * nit

commit 279e7eb
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 15:22:05 2021 -0700

    Add a new row type in query (#20685)

    * Add row type

    * Add a new row type

    * add test

    * lint

    * Apply suggestions from code review

    * changes

commit 5016742
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date:   Tue Sep 14 13:09:43 2021 -0700

    Update changelog date (#20686)

    * update swagger

    * update release date

commit 080f88d
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 13:01:32 2021 -0700

    [SchemaRegistry] update type of `schema` in `serialize` (#20683)

    * update type

    * update sample naming

commit 599a099
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 09:41:19 2021 -0700

    Handle Errors and Tables in Query (#20658)

    * initial commit

    * batch set

    * batch

    * tests + changes

    * more tests

    * lint

    * changelog

    * Apply suggestions from code review

    * comment

    * lint

    * querry

    * comments

commit 3252969
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 09:17:18 2021 -0700

    [SchemaRegistry] remove codec param in serializer (#20671)

    * remove codec

    * changelog

commit 27b7e75
Author: msyyc <70930885+msyyc@users.noreply.github.com>
Date:   Tue Sep 14 16:52:11 2021 +0800

    Update change_log.py (#20680)

commit fd80cb7
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Tue Sep 14 13:52:13 2021 +0800

    [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (#20678)

    * CodeGen from PR 15627 in Azure/azure-rest-api-specs
    [SRP] 2021-06-01 Swagger Api (#15627)

    * Add June21 Swagger Api version, Updated Readme files

    * adding abort and hnson migration swagger API

    * swagger: marking requesttype as required parameter for hns onmigration

    * Added new PublicNetworkAccess property to swagger spec

    * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger

    * Add Account Level VLW Swagger changes and example

    * Update Blob Inventory Api comment to include AccessTierInferred and Tags

    * Rename HnsOn to hierarchical namespace

    * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec

    * Update Spell check custom words list. Correct incorrect spellings

    * Add missing refrences to PublicNetworkAccess Examples

    * Add required type:object, Add default return type for hns migration apis

    * Prettier tool update to storage.json

    * Add update account with immutability policy example

    * Removed StorageFileDataSmbShareOwner as Server side does not support it

    * Add AllowProtectedAppendWritesAll feature changes with example

    * Updated enum values and description for PublicNetworkAccess

    * Add type:object to ProtectedAppendWritesHistory ; Spellcheck

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 3eb0af9
Author: William Harding <william.jeffrey.harding@gmail.com>
Date:   Mon Sep 13 16:06:06 2021 -0700

    Updated notebooks to make them more "general" (#15660)

    * Updated notebooks to make them more "general"

    * updated gitignore, added models, updated path

    * reverted gitignore

    * reverting gitignore

    * Renamed some files, changed model id to be more generic

commit 69be40d
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Mon Sep 13 15:35:26 2021 -0700

     [Key Vault] Update new test resource script (#20663)

commit ce307fe
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date:   Mon Sep 13 17:23:16 2021 -0500

    Final consistency review of Monitor Query README (#20667)

    * Final consistency review of Monitor Query README

    * Add rate limits section

commit c4d64b2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:50:44 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1979 (#20666)

    * Move logic for removing empty sections to ChangeLog-Operations.ps1

    * Refactor sections regex

    * Add SanitizeEntry parameter

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3a537c9
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 13:45:21 2021 -0700

    Update docstrings for custom models. (#20592)

commit 90ce516
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:06:02 2021 -0700

    Fix SemVer.ToString to handle v0 case (#20665)

    Since we are treating v0 versions as prerelease we need to make sure
    we don't accidently start to add the bogus prerelease label in cases where
    we call ToString() on the version.

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit dd67039
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:04:52 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1946 (#20656)

    * Add ability to exit gracefully when all files in the diff are excluded

    * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths'

    * Add tests

    * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests

    * Import common instead of logging

    * Enable strict mode

    Co-authored-by: Daniel Jurek <djurek@microsoft.com>

commit 7b2aeaf
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Mon Sep 13 10:47:42 2021 -0700

    [EventHubs] update test to test async producer (#19892)

    - call async Producer for testing/improving code coverage
    - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this

commit 8f28e2a
Author: Leighton Chen <lechen@microsoft.com>
Date:   Mon Sep 13 10:37:18 2021 -0700

    [Monitor exporter] Add OTLP and dual exporter scenario to samples (#20634)

    * rpc

    * samples

commit 5450368
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 09:21:54 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1983 (#20618)

    * Doc Updates and Revisions for External Use

    The focus of these changes is to revise the script to better support use
    by external contributors and others outside of the Azure SDK ecosystem and
    without access to the Microsoft AAD Tenant.

    Changes include:

    - Creation of a new Test Application service principal is now possible
      from a non-Microsoft AAD tenant.

    - When a new Test Application principal is created, the principle of least
      privilege is now applied; the new Test Application is granted ownership
      of the resource group associated with the test resources and no longer
      has access to any other resources in the subscription.

    - If an existing Test Application principal is specified, it will be
      assigned ownership of the resource group created.  This supports using
      a Test Application principal without privileges at the subscription-level.

    - When no provisioner is specified, the script is now executed in the
      context of the caller rather than the Test Application principal.
      This supports using a Test Application principal that has restricted
      privileges and better aligns to the purpose of the Test Application
      principal.

    - The `$TestApplicationOid` is now explicitly bound at the time a new Test
      Application principal is created rather than having to query for it later.

    - Common error scenarios resulting from lack of permissions now provide
      messaging with more context of why the failure occurred and suggest
      remediation.

    - Added new examples to illustrate the common call patterns needed by
      external contributors running the script, outside of the Microsoft tenant
      and Azure SDK ecosystem.

    - Documentation has been enhanced with additional context to detail the
      permissions and roles assigned by the script.

    - Added documentation details for Bicep template use.

    * Add the provisioner OID to the deployment params

    Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.

    * Fixing typos and spelling mistakes

    Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
    Co-authored-by: Heath Stewart <heaths@microsoft.com>

commit b7b7e36
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 09:10:38 2021 -0700

    [Search] Update SearchClient.search API (#20602)

    * Update SearchClient.search API.

    * Update CHANGELOG and async SearchClient.

    * Update parameter parsing for omitted values.

    * Code review comments and linter fixes.

commit 4048684
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Sun Sep 12 15:49:22 2021 -0700

    Increment version for monitor releases (#20635)

    Increment package version after release of azure-monitor-query
zihzhan-msft added a commit that referenced this pull request Sep 20, 2021
commit 7832c5a
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Sat Sep 18 09:34:11 2021 +0800

    [AutoRelease] t2-eventhub-2021-09-17-55263(Do not merge) (#20739)

    * CodeGen from PR 15979 in Azure/azure-rest-api-specs
    EventHub: Added missing Cluster API in 2021-06-01-preview (#15979)

    * Added missing Cluster APIs to 2021-01-01-preview

    * added cluster API in 2021-06-01-preview

    * updated lint errors

    * update 1

    * added listbysubscription

    * fixed ModelValidation

    Co-authored-by: v-ajnava <v-ajnava@microsoft.com>

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 29d98e8
Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Date:   Fri Sep 17 17:27:57 2021 -0700

    Fix broken link in python repo (#20746)

commit cbfacbd
Author: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
Date:   Fri Sep 17 14:04:28 2021 -0700

    [Storage]Unify service version and update changelog (#20723)

    * [Storage]Unify service version and update changelog

    * fix test

commit ea5ecea
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Fri Sep 17 10:19:31 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2010 (#20729)

    * Remove empty sections in changelog entry as part of prepare release

    * Update SECTIONS_HEADER_REGEX to accomodate various header levels

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 9b63801
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Fri Sep 17 15:00:44 2021 +0800

    [AutoRelease] t2-azurearcdata-2021-09-15-74995 (#20714)

    * CodeGen from PR 15874 in Azure/azure-rest-api-specs
    Adding 202 Accepted for deletion call (#15874)

    * Adding 202 for deletion call

    * Adding headers to suppress warnings

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 0645f49
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Thu Sep 16 15:58:10 2021 -0700

    [Test Proxy] Make add_sanitizer a module-level method (#20701)

commit ddf49b1
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Thu Sep 16 15:27:08 2021 -0700

    [Test proxy] Add migration guide (#20469)

commit e116660
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Thu Sep 16 12:33:48 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2011 (#20702)

    * Common pipeline template and script to detect API changes

    * Cahnges as per review comments

    * Review comment changes

    * CCahgnes as per review comments

    * Show warning for list of failed packages to detect API changes

    * Apply suggestions from code review

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
    Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 44e2acf
Author: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Date:   Thu Sep 16 10:57:23 2021 -0700

    protobuf to handle python 2.7 issues (#20725)

commit 81c6aa0
Author: Xiang Yan <xiangsjtu@gmail.com>
Date:   Thu Sep 16 08:33:08 2021 -0700

    add troubleshoot doc (#20684)

    * add troubleshoot doc

    * fix typo

    * update

    * update

    * update

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update Troubleshoot.md

    * update error log

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

commit 87e0f99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 15:32:41 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2016 (#20706)

    * Make ServiceName optional for verify-changelog

    In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

    * Put quotes around the strings to allow for empty

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit c80e26e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 12:45:42 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2009 (#20672)

    * Skip PSModule caching in container jobs

    * Add succeeded check to condition

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
    Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 1efff7f
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Wed Sep 15 10:53:42 2021 -0700

    [Search] Add skillset validation (#20669)

    * Add client-side validation and test.

    * Add skillset validation test.

    * Make code more Pythonic.

commit 6a06b0e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Sep 14 16:56:19 2021 -0700

    Add for multiple levels of Atx Headers in the CHANGELOG.md (#20694)

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3fdbaa7
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 16:27:06 2021 -0700

    [EventHub] update arm template with storage conn str (#20376)

    * update test resources

    * fix

    * fix failing tests

    * adams comments

    * pylint

    * remove dateutil

    * adams comments

    * nit

commit 279e7eb
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 15:22:05 2021 -0700

    Add a new row type in query (#20685)

    * Add row type

    * Add a new row type

    * add test

    * lint

    * Apply suggestions from code review

    * changes

commit 5016742
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date:   Tue Sep 14 13:09:43 2021 -0700

    Update changelog date (#20686)

    * update swagger

    * update release date

commit 080f88d
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 13:01:32 2021 -0700

    [SchemaRegistry] update type of `schema` in `serialize` (#20683)

    * update type

    * update sample naming

commit 599a099
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 09:41:19 2021 -0700

    Handle Errors and Tables in Query (#20658)

    * initial commit

    * batch set

    * batch

    * tests + changes

    * more tests

    * lint

    * changelog

    * Apply suggestions from code review

    * comment

    * lint

    * querry

    * comments

commit 3252969
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 09:17:18 2021 -0700

    [SchemaRegistry] remove codec param in serializer (#20671)

    * remove codec

    * changelog

commit 27b7e75
Author: msyyc <70930885+msyyc@users.noreply.github.com>
Date:   Tue Sep 14 16:52:11 2021 +0800

    Update change_log.py (#20680)

commit fd80cb7
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Tue Sep 14 13:52:13 2021 +0800

    [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (#20678)

    * CodeGen from PR 15627 in Azure/azure-rest-api-specs
    [SRP] 2021-06-01 Swagger Api (#15627)

    * Add June21 Swagger Api version, Updated Readme files

    * adding abort and hnson migration swagger API

    * swagger: marking requesttype as required parameter for hns onmigration

    * Added new PublicNetworkAccess property to swagger spec

    * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger

    * Add Account Level VLW Swagger changes and example

    * Update Blob Inventory Api comment to include AccessTierInferred and Tags

    * Rename HnsOn to hierarchical namespace

    * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec

    * Update Spell check custom words list. Correct incorrect spellings

    * Add missing refrences to PublicNetworkAccess Examples

    * Add required type:object, Add default return type for hns migration apis

    * Prettier tool update to storage.json

    * Add update account with immutability policy example

    * Removed StorageFileDataSmbShareOwner as Server side does not support it

    * Add AllowProtectedAppendWritesAll feature changes with example

    * Updated enum values and description for PublicNetworkAccess

    * Add type:object to ProtectedAppendWritesHistory ; Spellcheck

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 3eb0af9
Author: William Harding <william.jeffrey.harding@gmail.com>
Date:   Mon Sep 13 16:06:06 2021 -0700

    Updated notebooks to make them more "general" (#15660)

    * Updated notebooks to make them more "general"

    * updated gitignore, added models, updated path

    * reverted gitignore

    * reverting gitignore

    * Renamed some files, changed model id to be more generic

commit 69be40d
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Mon Sep 13 15:35:26 2021 -0700

     [Key Vault] Update new test resource script (#20663)

commit ce307fe
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date:   Mon Sep 13 17:23:16 2021 -0500

    Final consistency review of Monitor Query README (#20667)

    * Final consistency review of Monitor Query README

    * Add rate limits section

commit c4d64b2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:50:44 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1979 (#20666)

    * Move logic for removing empty sections to ChangeLog-Operations.ps1

    * Refactor sections regex

    * Add SanitizeEntry parameter

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3a537c9
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 13:45:21 2021 -0700

    Update docstrings for custom models. (#20592)

commit 90ce516
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:06:02 2021 -0700

    Fix SemVer.ToString to handle v0 case (#20665)

    Since we are treating v0 versions as prerelease we need to make sure
    we don't accidently start to add the bogus prerelease label in cases where
    we call ToString() on the version.

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit dd67039
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:04:52 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1946 (#20656)

    * Add ability to exit gracefully when all files in the diff are excluded

    * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths'

    * Add tests

    * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests

    * Import common instead of logging

    * Enable strict mode

    Co-authored-by: Daniel Jurek <djurek@microsoft.com>

commit 7b2aeaf
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Mon Sep 13 10:47:42 2021 -0700

    [EventHubs] update test to test async producer (#19892)

    - call async Producer for testing/improving code coverage
    - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this

commit 8f28e2a
Author: Leighton Chen <lechen@microsoft.com>
Date:   Mon Sep 13 10:37:18 2021 -0700

    [Monitor exporter] Add OTLP and dual exporter scenario to samples (#20634)

    * rpc

    * samples

commit 5450368
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 09:21:54 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1983 (#20618)

    * Doc Updates and Revisions for External Use

    The focus of these changes is to revise the script to better support use
    by external contributors and others outside of the Azure SDK ecosystem and
    without access to the Microsoft AAD Tenant.

    Changes include:

    - Creation of a new Test Application service principal is now possible
      from a non-Microsoft AAD tenant.

    - When a new Test Application principal is created, the principle of least
      privilege is now applied; the new Test Application is granted ownership
      of the resource group associated with the test resources and no longer
      has access to any other resources in the subscription.

    - If an existing Test Application principal is specified, it will be
      assigned ownership of the resource group created.  This supports using
      a Test Application principal without privileges at the subscription-level.

    - When no provisioner is specified, the script is now executed in the
      context of the caller rather than the Test Application principal.
      This supports using a Test Application principal that has restricted
      privileges and better aligns to the purpose of the Test Application
      principal.

    - The `$TestApplicationOid` is now explicitly bound at the time a new Test
      Application principal is created rather than having to query for it later.

    - Common error scenarios resulting from lack of permissions now provide
      messaging with more context of why the failure occurred and suggest
      remediation.

    - Added new examples to illustrate the common call patterns needed by
      external contributors running the script, outside of the Microsoft tenant
      and Azure SDK ecosystem.

    - Documentation has been enhanced with additional context to detail the
      permissions and roles assigned by the script.

    - Added documentation details for Bicep template use.

    * Add the provisioner OID to the deployment params

    Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.

    * Fixing typos and spelling mistakes

    Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
    Co-authored-by: Heath Stewart <heaths@microsoft.com>

commit b7b7e36
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 09:10:38 2021 -0700

    [Search] Update SearchClient.search API (#20602)

    * Update SearchClient.search API.

    * Update CHANGELOG and async SearchClient.

    * Update parameter parsing for omitted values.

    * Code review comments and linter fixes.

commit 4048684
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Sun Sep 12 15:49:22 2021 -0700

    Increment version for monitor releases (#20635)

    Increment package version after release of azure-monitor-query
zihzhan-msft added a commit to zihzhan-msft/azure-sdk-for-python that referenced this pull request Sep 20, 2021
commit 87e0f99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 15:32:41 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2016 (Azure#20706)

    * Make ServiceName optional for verify-changelog

    In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

    * Put quotes around the strings to allow for empty

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit c80e26e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 12:45:42 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2009 (Azure#20672)

    * Skip PSModule caching in container jobs

    * Add succeeded check to condition

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
    Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 1efff7f
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Wed Sep 15 10:53:42 2021 -0700

    [Search] Add skillset validation (Azure#20669)

    * Add client-side validation and test.

    * Add skillset validation test.

    * Make code more Pythonic.

commit 6a06b0e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Sep 14 16:56:19 2021 -0700

    Add for multiple levels of Atx Headers in the CHANGELOG.md (Azure#20694)

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3fdbaa7
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 16:27:06 2021 -0700

    [EventHub] update arm template with storage conn str (Azure#20376)

    * update test resources

    * fix

    * fix failing tests

    * adams comments

    * pylint

    * remove dateutil

    * adams comments

    * nit

commit 279e7eb
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 15:22:05 2021 -0700

    Add a new row type in query (Azure#20685)

    * Add row type

    * Add a new row type

    * add test

    * lint

    * Apply suggestions from code review

    * changes

commit 5016742
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date:   Tue Sep 14 13:09:43 2021 -0700

    Update changelog date (Azure#20686)

    * update swagger

    * update release date

commit 080f88d
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 13:01:32 2021 -0700

    [SchemaRegistry] update type of `schema` in `serialize` (Azure#20683)

    * update type

    * update sample naming

commit 599a099
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 09:41:19 2021 -0700

    Handle Errors and Tables in Query (Azure#20658)

    * initial commit

    * batch set

    * batch

    * tests + changes

    * more tests

    * lint

    * changelog

    * Apply suggestions from code review

    * comment

    * lint

    * querry

    * comments

commit 3252969
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 09:17:18 2021 -0700

    [SchemaRegistry] remove codec param in serializer (Azure#20671)

    * remove codec

    * changelog

commit 27b7e75
Author: msyyc <70930885+msyyc@users.noreply.github.com>
Date:   Tue Sep 14 16:52:11 2021 +0800

    Update change_log.py (Azure#20680)

commit fd80cb7
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Tue Sep 14 13:52:13 2021 +0800

    [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (Azure#20678)

    * CodeGen from PR 15627 in Azure/azure-rest-api-specs
    [SRP] 2021-06-01 Swagger Api (Azure#15627)

    * Add June21 Swagger Api version, Updated Readme files

    * adding abort and hnson migration swagger API

    * swagger: marking requesttype as required parameter for hns onmigration

    * Added new PublicNetworkAccess property to swagger spec

    * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger

    * Add Account Level VLW Swagger changes and example

    * Update Blob Inventory Api comment to include AccessTierInferred and Tags

    * Rename HnsOn to hierarchical namespace

    * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec

    * Update Spell check custom words list. Correct incorrect spellings

    * Add missing refrences to PublicNetworkAccess Examples

    * Add required type:object, Add default return type for hns migration apis

    * Prettier tool update to storage.json

    * Add update account with immutability policy example

    * Removed StorageFileDataSmbShareOwner as Server side does not support it

    * Add AllowProtectedAppendWritesAll feature changes with example

    * Updated enum values and description for PublicNetworkAccess

    * Add type:object to ProtectedAppendWritesHistory ; Spellcheck

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 3eb0af9
Author: William Harding <william.jeffrey.harding@gmail.com>
Date:   Mon Sep 13 16:06:06 2021 -0700

    Updated notebooks to make them more "general" (Azure#15660)

    * Updated notebooks to make them more "general"

    * updated gitignore, added models, updated path

    * reverted gitignore

    * reverting gitignore

    * Renamed some files, changed model id to be more generic

commit 69be40d
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Mon Sep 13 15:35:26 2021 -0700

     [Key Vault] Update new test resource script (Azure#20663)

commit ce307fe
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date:   Mon Sep 13 17:23:16 2021 -0500

    Final consistency review of Monitor Query README (Azure#20667)

    * Final consistency review of Monitor Query README

    * Add rate limits section

commit c4d64b2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:50:44 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1979 (Azure#20666)

    * Move logic for removing empty sections to ChangeLog-Operations.ps1

    * Refactor sections regex

    * Add SanitizeEntry parameter

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3a537c9
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 13:45:21 2021 -0700

    Update docstrings for custom models. (Azure#20592)

commit 90ce516
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:06:02 2021 -0700

    Fix SemVer.ToString to handle v0 case (Azure#20665)

    Since we are treating v0 versions as prerelease we need to make sure
    we don't accidently start to add the bogus prerelease label in cases where
    we call ToString() on the version.

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit dd67039
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:04:52 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1946 (Azure#20656)

    * Add ability to exit gracefully when all files in the diff are excluded

    * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths'

    * Add tests

    * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests

    * Import common instead of logging

    * Enable strict mode

    Co-authored-by: Daniel Jurek <djurek@microsoft.com>

commit 7b2aeaf
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Mon Sep 13 10:47:42 2021 -0700

    [EventHubs] update test to test async producer (Azure#19892)

    - call async Producer for testing/improving code coverage
    - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this

commit 8f28e2a
Author: Leighton Chen <lechen@microsoft.com>
Date:   Mon Sep 13 10:37:18 2021 -0700

    [Monitor exporter] Add OTLP and dual exporter scenario to samples (Azure#20634)

    * rpc

    * samples

commit 5450368
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 09:21:54 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1983 (Azure#20618)

    * Doc Updates and Revisions for External Use

    The focus of these changes is to revise the script to better support use
    by external contributors and others outside of the Azure SDK ecosystem and
    without access to the Microsoft AAD Tenant.

    Changes include:

    - Creation of a new Test Application service principal is now possible
      from a non-Microsoft AAD tenant.

    - When a new Test Application principal is created, the principle of least
      privilege is now applied; the new Test Application is granted ownership
      of the resource group associated with the test resources and no longer
      has access to any other resources in the subscription.

    - If an existing Test Application principal is specified, it will be
      assigned ownership of the resource group created.  This supports using
      a Test Application principal without privileges at the subscription-level.

    - When no provisioner is specified, the script is now executed in the
      context of the caller rather than the Test Application principal.
      This supports using a Test Application principal that has restricted
      privileges and better aligns to the purpose of the Test Application
      principal.

    - The `$TestApplicationOid` is now explicitly bound at the time a new Test
      Application principal is created rather than having to query for it later.

    - Common error scenarios resulting from lack of permissions now provide
      messaging with more context of why the failure occurred and suggest
      remediation.

    - Added new examples to illustrate the common call patterns needed by
      external contributors running the script, outside of the Microsoft tenant
      and Azure SDK ecosystem.

    - Documentation has been enhanced with additional context to detail the
      permissions and roles assigned by the script.

    - Added documentation details for Bicep template use.

    * Add the provisioner OID to the deployment params

    Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.

    * Fixing typos and spelling mistakes

    Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
    Co-authored-by: Heath Stewart <heaths@microsoft.com>

commit b7b7e36
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 09:10:38 2021 -0700

    [Search] Update SearchClient.search API (Azure#20602)

    * Update SearchClient.search API.

    * Update CHANGELOG and async SearchClient.

    * Update parameter parsing for omitted values.

    * Code review comments and linter fixes.

commit 4048684
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Sun Sep 12 15:49:22 2021 -0700

    Increment version for monitor releases (Azure#20635)

    Increment package version after release of azure-monitor-query
zihzhan-msft added a commit to zihzhan-msft/azure-sdk-for-python that referenced this pull request Sep 20, 2021
commit 7832c5a
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Sat Sep 18 09:34:11 2021 +0800

    [AutoRelease] t2-eventhub-2021-09-17-55263(Do not merge) (Azure#20739)

    * CodeGen from PR 15979 in Azure/azure-rest-api-specs
    EventHub: Added missing Cluster API in 2021-06-01-preview (Azure#15979)

    * Added missing Cluster APIs to 2021-01-01-preview

    * added cluster API in 2021-06-01-preview

    * updated lint errors

    * update 1

    * added listbysubscription

    * fixed ModelValidation

    Co-authored-by: v-ajnava <v-ajnava@microsoft.com>

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: v-ajnava <v-ajnava@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 29d98e8
Author: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com>
Date:   Fri Sep 17 17:27:57 2021 -0700

    Fix broken link in python repo (Azure#20746)

commit cbfacbd
Author: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
Date:   Fri Sep 17 14:04:28 2021 -0700

    [Storage]Unify service version and update changelog (Azure#20723)

    * [Storage]Unify service version and update changelog

    * fix test

commit ea5ecea
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Fri Sep 17 10:19:31 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2010 (Azure#20729)

    * Remove empty sections in changelog entry as part of prepare release

    * Update SECTIONS_HEADER_REGEX to accomodate various header levels

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 9b63801
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Fri Sep 17 15:00:44 2021 +0800

    [AutoRelease] t2-azurearcdata-2021-09-15-74995 (Azure#20714)

    * CodeGen from PR 15874 in Azure/azure-rest-api-specs
    Adding 202 Accepted for deletion call (Azure#15874)

    * Adding 202 for deletion call

    * Adding headers to suppress warnings

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 0645f49
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Thu Sep 16 15:58:10 2021 -0700

    [Test Proxy] Make add_sanitizer a module-level method (Azure#20701)

commit ddf49b1
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Thu Sep 16 15:27:08 2021 -0700

    [Test proxy] Add migration guide (Azure#20469)

commit e116660
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Thu Sep 16 12:33:48 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2011 (Azure#20702)

    * Common pipeline template and script to detect API changes

    * Cahnges as per review comments

    * Review comment changes

    * CCahgnes as per review comments

    * Show warning for list of failed packages to detect API changes

    * Apply suggestions from code review

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
    Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 44e2acf
Author: Scott Beddall <45376673+scbedd@users.noreply.github.com>
Date:   Thu Sep 16 10:57:23 2021 -0700

    protobuf to handle python 2.7 issues (Azure#20725)

commit 81c6aa0
Author: Xiang Yan <xiangsjtu@gmail.com>
Date:   Thu Sep 16 08:33:08 2021 -0700

    add troubleshoot doc (Azure#20684)

    * add troubleshoot doc

    * fix typo

    * update

    * update

    * update

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update sdk/identity/azure-identity/Troubleshoot.md

    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

    * Update Troubleshoot.md

    * update error log

    Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
    Co-authored-by: Charles Lowell <chlowe@microsoft.com>

commit 87e0f99
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 15:32:41 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2016 (Azure#20706)

    * Make ServiceName optional for verify-changelog

    In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

    * Put quotes around the strings to allow for empty

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit c80e26e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Wed Sep 15 12:45:42 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 2009 (Azure#20672)

    * Skip PSModule caching in container jobs

    * Add succeeded check to condition

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

    Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
    Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit 1efff7f
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Wed Sep 15 10:53:42 2021 -0700

    [Search] Add skillset validation (Azure#20669)

    * Add client-side validation and test.

    * Add skillset validation test.

    * Make code more Pythonic.

commit 6a06b0e
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Tue Sep 14 16:56:19 2021 -0700

    Add for multiple levels of Atx Headers in the CHANGELOG.md (Azure#20694)

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3fdbaa7
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 16:27:06 2021 -0700

    [EventHub] update arm template with storage conn str (Azure#20376)

    * update test resources

    * fix

    * fix failing tests

    * adams comments

    * pylint

    * remove dateutil

    * adams comments

    * nit

commit 279e7eb
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 15:22:05 2021 -0700

    Add a new row type in query (Azure#20685)

    * Add row type

    * Add a new row type

    * add test

    * lint

    * Apply suggestions from code review

    * changes

commit 5016742
Author: luc <44377201+LuChen-Microsoft@users.noreply.github.com>
Date:   Tue Sep 14 13:09:43 2021 -0700

    Update changelog date (Azure#20686)

    * update swagger

    * update release date

commit 080f88d
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 13:01:32 2021 -0700

    [SchemaRegistry] update type of `schema` in `serialize` (Azure#20683)

    * update type

    * update sample naming

commit 599a099
Author: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Date:   Tue Sep 14 09:41:19 2021 -0700

    Handle Errors and Tables in Query (Azure#20658)

    * initial commit

    * batch set

    * batch

    * tests + changes

    * more tests

    * lint

    * changelog

    * Apply suggestions from code review

    * comment

    * lint

    * querry

    * comments

commit 3252969
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Tue Sep 14 09:17:18 2021 -0700

    [SchemaRegistry] remove codec param in serializer (Azure#20671)

    * remove codec

    * changelog

commit 27b7e75
Author: msyyc <70930885+msyyc@users.noreply.github.com>
Date:   Tue Sep 14 16:52:11 2021 +0800

    Update change_log.py (Azure#20680)

commit fd80cb7
Author: Azure CLI Bot <azclibot@microsoft.com>
Date:   Tue Sep 14 13:52:13 2021 +0800

    [AutoRelease] t2-storage-2021-09-14-45016(Do not merge) (Azure#20678)

    * CodeGen from PR 15627 in Azure/azure-rest-api-specs
    [SRP] 2021-06-01 Swagger Api (Azure#15627)

    * Add June21 Swagger Api version, Updated Readme files

    * adding abort and hnson migration swagger API

    * swagger: marking requesttype as required parameter for hns onmigration

    * Added new PublicNetworkAccess property to swagger spec

    * Add enableNfsV3RootSquash and enableNfsV3AllSquash to June21 swagger

    * Add Account Level VLW Swagger changes and example

    * Update Blob Inventory Api comment to include AccessTierInferred and Tags

    * Rename HnsOn to hierarchical namespace

    * [Swagger] [June21] Added defaultToOAuthAuthentication to swagger spec

    * Update Spell check custom words list. Correct incorrect spellings

    * Add missing refrences to PublicNetworkAccess Examples

    * Add required type:object, Add default return type for hns migration apis

    * Prettier tool update to storage.json

    * Add update account with immutability policy example

    * Removed StorageFileDataSmbShareOwner as Server side does not support it

    * Add AllowProtectedAppendWritesAll feature changes with example

    * Updated enum values and description for PublicNetworkAccess

    * Add type:object to ProtectedAppendWritesHistory ; Spellcheck

    * version,CHANGELOG

    Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
    Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>

commit 3eb0af9
Author: William Harding <william.jeffrey.harding@gmail.com>
Date:   Mon Sep 13 16:06:06 2021 -0700

    Updated notebooks to make them more "general" (Azure#15660)

    * Updated notebooks to make them more "general"

    * updated gitignore, added models, updated path

    * reverted gitignore

    * reverting gitignore

    * Renamed some files, changed model id to be more generic

commit 69be40d
Author: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Date:   Mon Sep 13 15:35:26 2021 -0700

     [Key Vault] Update new test resource script (Azure#20663)

commit ce307fe
Author: Scott Addie <10702007+scottaddie@users.noreply.github.com>
Date:   Mon Sep 13 17:23:16 2021 -0500

    Final consistency review of Monitor Query README (Azure#20667)

    * Final consistency review of Monitor Query README

    * Add rate limits section

commit c4d64b2
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:50:44 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1979 (Azure#20666)

    * Move logic for removing empty sections to ChangeLog-Operations.ps1

    * Refactor sections regex

    * Add SanitizeEntry parameter

    Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

commit 3a537c9
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 13:45:21 2021 -0700

    Update docstrings for custom models. (Azure#20592)

commit 90ce516
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:06:02 2021 -0700

    Fix SemVer.ToString to handle v0 case (Azure#20665)

    Since we are treating v0 versions as prerelease we need to make sure
    we don't accidently start to add the bogus prerelease label in cases where
    we call ToString() on the version.

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

commit dd67039
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 13:04:52 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1946 (Azure#20656)

    * Add ability to exit gracefully when all files in the diff are excluded

    * Address case where cspell exits with an error when all files from the 'files' config list are excluded by the expressions in 'ignorePaths'

    * Add tests

    * Review feedback: impl goes at the bottom and should be treated as a script, logic for testing should happen above that and exit appropriately if running tests

    * Import common instead of logging

    * Enable strict mode

    Co-authored-by: Daniel Jurek <djurek@microsoft.com>

commit 7b2aeaf
Author: swathipil <76007337+swathipil@users.noreply.github.com>
Date:   Mon Sep 13 10:47:42 2021 -0700

    [EventHubs] update test to test async producer (Azure#19892)

    - call async Producer for testing/improving code coverage
    - remove passing in fake kwarg to PartitionContext; untested lines in PartitionContext can only be tested with a user implemented CheckpointStore class, so not worrying about this

commit 8f28e2a
Author: Leighton Chen <lechen@microsoft.com>
Date:   Mon Sep 13 10:37:18 2021 -0700

    [Monitor exporter] Add OTLP and dual exporter scenario to samples (Azure#20634)

    * rpc

    * samples

commit 5450368
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Mon Sep 13 09:21:54 2021 -0700

    Sync eng/common directory with azure-sdk-tools for PR 1983 (Azure#20618)

    * Doc Updates and Revisions for External Use

    The focus of these changes is to revise the script to better support use
    by external contributors and others outside of the Azure SDK ecosystem and
    without access to the Microsoft AAD Tenant.

    Changes include:

    - Creation of a new Test Application service principal is now possible
      from a non-Microsoft AAD tenant.

    - When a new Test Application principal is created, the principle of least
      privilege is now applied; the new Test Application is granted ownership
      of the resource group associated with the test resources and no longer
      has access to any other resources in the subscription.

    - If an existing Test Application principal is specified, it will be
      assigned ownership of the resource group created.  This supports using
      a Test Application principal without privileges at the subscription-level.

    - When no provisioner is specified, the script is now executed in the
      context of the caller rather than the Test Application principal.
      This supports using a Test Application principal that has restricted
      privileges and better aligns to the purpose of the Test Application
      principal.

    - The `$TestApplicationOid` is now explicitly bound at the time a new Test
      Application principal is created rather than having to query for it later.

    - Common error scenarios resulting from lack of permissions now provide
      messaging with more context of why the failure occurred and suggest
      remediation.

    - Added new examples to illustrate the common call patterns needed by
      external contributors running the script, outside of the Microsoft tenant
      and Azure SDK ecosystem.

    - Documentation has been enhanced with additional context to detail the
      permissions and roles assigned by the script.

    - Added documentation details for Bicep template use.

    * Add the provisioner OID to the deployment params

    Key Vault needs this to deploy Managed HSMs. There's a corresponding change necessary in test-resources.json I'll roll out across languages.

    * Fixing typos and spelling mistakes

    Co-authored-by: Jesse Squire <jesse.squire@gmail.com>
    Co-authored-by: Heath Stewart <heaths@microsoft.com>

commit b7b7e36
Author: Travis Prescott <tjprescott@users.noreply.github.com>
Date:   Mon Sep 13 09:10:38 2021 -0700

    [Search] Update SearchClient.search API (Azure#20602)

    * Update SearchClient.search API.

    * Update CHANGELOG and async SearchClient.

    * Update parameter parsing for omitted values.

    * Code review comments and linter fixes.

commit 4048684
Author: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Date:   Sun Sep 12 15:49:22 2021 -0700

    Increment version for monitor releases (Azure#20635)

    Increment package version after release of azure-monitor-query
iscai-msft pushed a commit that referenced this pull request Sep 29, 2021
* Updated notebooks to make them more "general"

* updated gitignore, added models, updated path

* reverted gitignore

* reverting gitignore

* Renamed some files, changed model id to be more generic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants