[EventGrid] Adjust README verbiage in preparation for UX pilot study with feedback #15729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KieranBrantnerMagee
commented
Dec 9, 2020
KieranBrantnerMagee
commented
- improve clarity of "host" vs topic endpoint (which is the verbiage actually seen in the portal)
- Add breadcrumbs to generate_sas and sas based auth
- change api key verbiage to access key
- improve clarity of "host" vs topic endpoint (which is the verbiage actually seen in the portal) - Add breadcrumbs to generate_sas and sas based auth - change api key verbiage to access key
KieranBrantnerMagee
added
Event Grid
Client
KieranBrantnerMagee
changed the title
elraikhm
approved these changes
Dec 9, 2020
rakshith91
approved these changes
Dec 9, 2020
- clarify some readme sections (access keys, endpoint) - make data be populated even if it's not a recognized strong type, was previously none. (this appears to be what JS/dotnet more or less do) - clarify data_version as required in egevent - clarify some docstrings, such as topic being required for domain. - adjust dev reqs so that mgmt endpoints aren't broken by their going to a beta release.
…guiding snippets to readme on core concepts and egevent/cloudevent usage.
|
/azp run python - eventgrid - ci |
|
Pull request contains merge conflicts. |
lmazuel
reviewed
Jan 12, 2021
| @@ -2,4 +2,4 @@ | |||
| -e ../../../tools/azure-sdk-tools | |||
| -e ../../core/azure-core | |||
| -e ../../identity/azure-identity | |||
| -e ../azure-mgmt-eventgrid | |||
| azure-mgmt-eventgrid==3.0.0rc8 | |||
Closed
|
Closing this in favor of #16124 |
rakshith91
reviewed
Jan 13, 2021
|
|
||
| :param str event_type: The event_type of the EventGridEvent object or the type of the CloudEvent object. | ||
| """ | ||
| # if system event type defined, set event.data to system event object | ||
| try: | ||
| event.data = (_event_mappings[event_type]).deserialize(event.data) | ||
| except KeyError: # else, if custom event, then event.data is dict and should be set to None | ||
| event.data = None | ||
| except KeyError: # else, if custom event, then event.data is dict and is left as-is. |
There was a problem hiding this comment.
will tackle this in #16125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.