-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Event Hubs] created EventHubConnectionStringProperties and connection string parser #16204
[Event Hubs] created EventHubConnectionStringProperties and connection string parser #16204
Conversation
/azp run python - eventhub - tests |
No pipelines are associated with this pull request. |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/eventhub/azure-eventhub/tests/unittest/test_connection_string_parser.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - make sure @yunhaoling signs it off too before you merge it :)
sdk/eventhub/azure-eventhub/azure/eventhub/_connection_string_parser.py
Outdated
Show resolved
Hide resolved
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/eventhub/azure-eventhub/azure/eventhub/_connection_string_parser.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just to clarify - this isn't replacing the from_connection_string
classmethods is it? Just supplementary?
@annatisch nope! It's just supplementary, to "assist with transforming a connection string for use with credential-based client creation". |
…thipil/azure-sdk-for-python into swathipil/eh/conn-str-parser
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
update readme (Azure#16204)
addressing: #14575
following the SB Connection String parser: #14574