Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mindep test all dependencies except nspkg #16331

Merged
merged 16 commits into from
Feb 3, 2021

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 25, 2021

Instead of just azure packages.

Right now, the only one I know of that the previous excluded was msrest, but we'll see after a run of python - all!

@scbedd
Copy link
Member Author

scbedd commented Jan 29, 2021

Kicked a full build based on this update.

Just need to walk through the errors, file issues for minimum msrest against the couple management packages that have issues, and merge this.

@check-enforcer
Copy link

check-enforcer bot commented Feb 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

Copy link
Member

@praveenkuttappan praveenkuttappan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. So this tests against min and max of external packages also.

@scbedd
Copy link
Member Author

scbedd commented Feb 3, 2021

/check-enforcer override

@scbedd scbedd merged commit 7d1aa3e into Azure:master Feb 3, 2021
iscai-msft added a commit to annatisch/azure-sdk-for-python that referenced this pull request Feb 3, 2021
…into enum-meta

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  revert file changed by bot (Azure#16493)
  [T2] Resourcemover fix dependency (Azure#16491)
  fix compute readme (Azure#16488)
  [Python] python track2 new pipeline (Azure#16484)
  T2 compute 2021 02 02 (Azure#16486)
  Mindep test all dependencies except nspkg (Azure#16331)
  Add aio folder and update GA tag (Azure#16178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants