Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cloud environment for Teams user #16359

Merged
merged 41 commits into from
Jan 30, 2021
Merged

Add Cloud environment for Teams user #16359

merged 41 commits into from
Jan 30, 2021

Conversation

turalf
Copy link
Contributor

@turalf turalf commented Jan 26, 2021

No description provided.

@turalf
Copy link
Contributor Author

turalf commented Jan 27, 2021 •
edited
Loading

/azp run python - communication

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@turalf
Copy link
Contributor Author

turalf commented Jan 28, 2021 •
edited
Loading

/azp run python - communication - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

DominikMe
DominikMe requested changes Jan 28, 2021
View reviewed changes
Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tural! Found some things to address.

sdk/communication/azure-communication-chat/azure/communication/chat/_shared/models.py Show resolved Hide resolved
...mmunication/azure-communication-chat/tests/_shared/test_communication_identity_serializer.py Show resolved Hide resolved
...e-communication-chat/azure/communication/chat/_shared/communication_identifier_serializer.py Outdated Show resolved Hide resolved
...mmunication/azure-communication-chat/tests/_shared/test_communication_identity_serializer.py Outdated Show resolved Hide resolved
...e-communication-chat/azure/communication/chat/_shared/communication_identifier_serializer.py Show resolved Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/models.py Show resolved Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/models.py Show resolved Hide resolved
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

DominikMe
DominikMe approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

Comments are mainly on docstrings and grammar. After addressing them it looks good to merge.

...tion/azure-communication-administration/azure/communication/administration/_shared/models.py Outdated Show resolved Hide resolved
...tion/azure-communication-administration/azure/communication/administration/_shared/models.py Outdated Show resolved Hide resolved
...tion/azure-communication-administration/azure/communication/administration/_shared/models.py Outdated Show resolved Hide resolved
...e-communication-chat/azure/communication/chat/_shared/communication_identifier_serializer.py Outdated Show resolved Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/models.py Outdated Show resolved Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/_shared/models.py Outdated Show resolved Hide resolved
...mmunication/azure-communication-chat/tests/_shared/test_communication_identity_serializer.py Show resolved Hide resolved
sdk/communication/azure-communication-sms/azure/communication/sms/_shared/models.py Show resolved Hide resolved
sdk/communication/azure-mgmt-communication/setup.py Show resolved Hide resolved
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

6 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

turalf added 22 commits January 29, 2021 16:28
Add test_serialize_foreign_throws
e65ce70
Add test for unknown kind
a6b0e10
Fix docstring for serialize method
5ee9907
Fix the typo in anonymous
3792c89
Fix phone number doc string
903f7eb
Sync model to admin and chat
fb9003e
Fix the docstring for CommunicationIdentifierModel
cfb85a0
Remove dev-tools
8dabd70
add mgmt core to setup py for mgmt package
dd759ad
Update the core dependency in mgmt package.
61e3341
Sync models to admin, sms, identity
92a6c14
Change the exception message
6cb8d97
Add idnetifier check in the test
d7ee2b4
sync model to other packages
0bd0a12
Remove unnecessary mgmt dependency
9c8cae6
change identity to identifier in docstrings
3cd86b7
change core forzen requirement for identity
c881ca4
Change docstring for sms
088b41d
Override shared reqs for core
c0bbf9c
Fix forzen requirements for core and sms
624b3cc
change core dependency version in chat,sms,admin
22b727e
Add mgmt core back to the dependency
6b6a902
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@turalf turalf enabled auto-merge (squash) January 30, 2021 01:26
@turalf turalf disabled auto-merge January 30, 2021 03:27
@turalf turalf merged commit 1b0d99a into Azure:master Jan 30, 2021
@turalf turalf mentioned this pull request Jan 30, 2021
Closed
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 2, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
527dc58 
…into analyze_redesign

* 'master' of https://github.com/Azure/azure-sdk-for-python: (35 commits)
  Sync eng/common directory with azure-sdk-tools for PR 1353 (Azure#16465)
  Normalize the package name for Doc.Ms readme (Azure#16401)
  fix changelog and version (Azure#16445)
  we should always run integration to publish from our artifacts. if the build pipeline crashed too early in the pipeline, this will fail regardless, due to inability to pull the artifacts down (Azure#15058)
  Fix DateTime bug (Azure#16456)
  Resolve Regression Failures (Azure#16455)
  [text analytics] Expose 'string_index_type' parameter in all service client methods where applicable (Azure#16412)
  adding devtools to the appconfig dev_reqs to solve python core issue (Azure#16381)
  Copy job matrix functionality (Azure#16450)
  Add APIView KV variable group to prepare pipelines bot (Azure#16451)
  [Datalake] Added support for PurePosixPath (Azure#16400)
  Regenerate baseline because last one break. (Azure#16415)
  adding step to test for crlf line endings (Azure#16398)
  [Datalake] Removed list_paths manual paging and deserialization (Azure#16309)
  Sync eng/common directory with azure-sdk-tools for PR 1351 (Azure#16448)
  Update auto_codegen.py (Azure#16443)
  First release purview (Azure#16440)
  1ES pools update for release pipeline. (Azure#16419)
  Add Cloud environment for Teams user (Azure#16359)
  Sync eng/common directory with azure-sdk-tools for PR 1345 (Azure#16404)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RezaJooyandeh RezaJooyandeh RezaJooyandeh left review comments

@DominikMe DominikMe DominikMe approved these changes

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

@memontic-ms memontic-ms Awaiting requested review from memontic-ms

@00Kai0 00Kai0 Awaiting requested review from 00Kai0

@changlong-liu changlong-liu Awaiting requested review from changlong-liu

@jsntcy jsntcy Awaiting requested review from jsntcy

@msyyc msyyc Awaiting requested review from msyyc

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turalf @DominikMe @RezaJooyandeh