Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Update keys documentation for 4.4.0b1 #16658

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Feb 10, 2021

Resolves #13717.

Updates the changelog for this release and adds MHSM-related documentation to the README.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Feb 10, 2021
@mccoyp mccoyp requested review from chlowell and schaabs February 10, 2021 01:26
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm uncertain on the readme additions. The readme doesn't need to be exhaustive--it's okay to omit an uncommonly used and/or preview feature like symmetric key support. Doing so may be better here because mentioning it in the readme requires explaining Key Vault vs. MHSM, which could be more confusing than helpful.

sdk/keyvault/azure-keyvault-keys/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/keyvault/azure-keyvault-keys/README.md Outdated Show resolved Hide resolved
@mccoyp mccoyp requested a review from chlowell February 10, 2021 17:36
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the development status classifier in setup.py matches, it should be "4 - Beta".

@mccoyp mccoyp changed the title [Key Vault] Update keys documentation for 4.3.2 [Key Vault] Update keys documentation for 4.4.0b1 Feb 10, 2021
@mccoyp mccoyp merged commit b665f1f into Azure:master Feb 10, 2021
@mccoyp mccoyp deleted the keys-docs branch February 10, 2021 18:41
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Nov 4, 2021
Cognitive Services add batch tag package-2021-10 (Azure#16658)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 5, 2022
Cognitive Services add batch tag package-2021-10 (Azure#16658)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update KeyVault Keys and Administration READMEs for MHSM
2 participants