Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communication chat preview4 (#16905) #17037

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Communication chat preview4 (#16905) #17037

merged 1 commit into from
Mar 3, 2021

Conversation

sarkar-rajarshi
Copy link
Member

Co-authored-by: turalf tufarhad@microsoft.com

  • preview4 changes made + unit tests fixed

  • Chat - preview4 changes

  • CommunicationUserIdentifier models added
  • create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient
  • add_participant - docstring update AddChatParticipantsResult instead of None
  • add_participants - docstring update AddChatParticipantsResult instead of None

  • pylint-changes

  • pylint changes

  • Method signature changed for add_pariticipant and add_participants

  • add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError)
  • add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError))
  • unit tests modified as per signature change
  • CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError))
  • e2e tests modified as per signature change
  • CreateChatThreadResult modified to handle partial errors in batch calls with ease
  • CreateChatThreadResult -> attributes changed to
    • chat_thread -> ChatThread (no change)
    • Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError))
  • create_chat_thread -> thread_participants and repeatability_request_id changed to keyword arguments
  • Modify unit tests to capture method signature modifications
  • Modify e2e tests to capture method signature modifications

  • pylint-changes

  • pylint fixes

  • README.md update + pylint fixes

  • test recordings added

  • add_participant -> raises error

  • Update README.md with modified signature
  • Update samples with new method signatures
  • Add test to detect invalid instantiation of AccessToken
  • Minor documentation updates
  • Modify unit tests to capture method signature modifications
  • Modify e2e tests to capture method signature modifications

  • pylint fixes

  • cls removed from docstring + update_topic async refactored

  • cls removed from docstring

Co-authored-by: Sam Cheung sacheu@microsoft.com
Co-authored-by: turalf tural.ferhadov@gmail.com
Co-authored-by: turalf tufarhad@microsoft.com

@sarkar-rajarshi @sacheun @turalf
Communication chat preview4 (#16905)
3683f00 
* [Communication] Generate identifier Models from new swagger (#16735)
* Add generated chat code from new swagger
* Address PR Feedback
* Remove CommunicationUserIdentifierModel in identity,phone number package
* Check schema of the object to determine the type [preview4] (#16838)
* Replace identifier with rawId
* Change serilizer
* Replace indentifier with rawId in test code
* Sync models across modules
* fix typo in serizliser
* Rearrange imports
* Replace rawId with raw_id
* remove trailing newline

Co-authored-by: turalf <tufarhad@microsoft.com>

* preview4 changes made + unit tests fixed

* Chat - preview4 changes
- CommunicationUserIdentifier models added
- create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient
- add_participant - docstring update AddChatParticipantsResult instead of None
- add_participants - docstring update AddChatParticipantsResult instead of None

* pylint-changes

* pylint changes

* Method signature changed for add_pariticipant and add_participants
- add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError)
- add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError))
- unit tests modified as per signature change
- CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError))
- e2e tests modified as per signature change

* CreateChatThreadResult modified to handle partial errors in batch calls with ease
- CreateChatThreadResult -> attributes changed to
  - chat_thread -> ChatThread (no change)
  - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError))
- create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments
- Modify unit tests to capture method signature modifications
- Modify e2e tests to capture method signature modifications

* pylint-changes

* pylint fixes

* README.md update + pylint fixes

* test recordings added

* add_participant -> raises error
- Update README.md with modified signature
- Update samples with new method signatures
- Add test to detect invalid instantiation of AccessToken
- Minor documentation updates
- Modify unit tests to capture method signature modifications
- Modify e2e tests to capture method signature modifications

* pylint fixes

* cls removed from docstring + update_topic async refactored

* cls removed from docstring

Co-authored-by: Sam Cheung <sacheu@microsoft.com>
Co-authored-by: turalf <tural.ferhadov@gmail.com>
Co-authored-by: turalf <tufarhad@microsoft.com>
@ghost ghost added the Communication label Mar 3, 2021
@Leoaqr Leoaqr self-requested a review March 3, 2021 00:52
@juancamilor juancamilor merged commit 4092519 into master Mar 3, 2021
@juancamilor juancamilor deleted the feature/communication-chat-preview4-comm-models branch March 3, 2021 01:05
@juancamilor
Copy link
Member

Note: Already reviewed in the other branch.

@sarkar-rajarshi
Copy link
Member Author

/azp run python - communication - tests

iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 3, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
5727484 
…into http_request_json

* 'master' of https://github.com/Azure/azure-sdk-for-python: (147 commits)
  [text analytics] add perf tests (Azure#17060)
  Add cloud event to core (Azure#16800)
  [Perf] Small fixes to storage-blob (Azure#17055)
  [EG] Regenerate Code (Azure#17053)
  Scrub batch shared keys (Azure#17030)
  [Tables] Add SAS to tables (Azure#16717)
  T2 containerservice 2021 03 03 (Azure#17050)
  Addressing issues with CredScan (Azure#16944)
  Communication chat preview4 (Azure#16905) (Azure#17037)
  remove first query section (Azure#17033)
  [formrecognizer] temp disable sample tests until service bug fixed (Azure#17036)
  [device update] allow device update pylint failures (Azure#17034)
  fix build (Azure#17029)
  update artifact names for ALL packages to align with the actual package name
  Create azure-iot-nspkg (Azure#17026)
  [Communication]: SMS 1:N Messages, Custom Tags, and Idempotence (Azure#16836)
  Fixing credentials to use AAD (Azure#16885)
  T2 deviceupdate 2021 03 02 (Azure#17016)
  T2 cosmosdb 2021 02 23 (Azure#16875)
  T2 datadog 2021 03 02 (Azure#17004)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 6, 2022
@ArcturusZhang
CodeGen from PR 17037 in Azure/azure-rest-api-specs
f4bef1d 
[Go] Track2 modify videoindexer (Azure#17037)

* [Go] Track2 modify videoindexer

* move the deduplication

* remove deduplication to see what happens

* remove go track1 config

* remove readmd.go go repo config

* remove readme.md version

Co-authored-by: ArcturusZhang <dapzhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leoaqr Leoaqr Leoaqr approved these changes

@juancamilor juancamilor juancamilor approved these changes

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit

@memontic-ms memontic-ms Awaiting requested review from memontic-ms

@turalf turalf Awaiting requested review from turalf

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sarkar-rajarshi @juancamilor @Leoaqr