[Key Vault] Add perf tests for certificates, keys, and secrets #17073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccoyp
added
KeyVault
Client
chlowell
reviewed
Mar 4, 2021
| @@ -0,0 +1,48 @@ | |||
| from azure_devtools.perfstress_tests import PerfStressTest | |||
| tenant_id = self.get_from_env("AZURE_TENANT_ID") | ||
| client_id = self.get_from_env("AZURE_CLIENT_ID") | ||
| client_secret = self.get_from_env("AZURE_CLIENT_SECRET") | ||
| self.credential = ClientSecretCredential(tenant_id, client_id, client_secret) |
There was a problem hiding this comment.
You could use EnvironmentCredential, if you don't mind being less explicit
chlowell
approved these changes
Mar 5, 2021
iscai-msft
added a commit
that referenced
this pull request
Mar 8, 2021
…into update_ta_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: Update get_package_properties.py logic for python 2.7 (#17144) update changelog (#17150) [ServiceBus] 7.1.0 Release update changelog (#17135) [ServiceBus] Object mapping support (#17080) move SetTestPipeline into its own template (#17141) Revise token cache configuration API (#16326) Fix dup cloud error (#17097) Perf tests for monitor exporter (#17067) [Communication] - Phone Number - Redesigned API (#16671) disable retry (#17078) [Key Vault] Add perf tests for certificates, keys, and secrets (#17073) [text analytics] Analyze updates for v5.1.0b6 (#17003) Add any additional claims to AuthenticationRequiredError (#17136) Fix logic in SetTestPipelineVersionInEngCommon (#17138) [Key Vault] Make test resource cleanup script asynchronous (#17032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16888.
This adds one performance test for each package, testing the get_* function for each. Instructions for writing these tests can be found here.