Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[text analytics] assertions #17098

Merged
5 commits merged into from
Mar 5, 2021
Merged

[text analytics] assertions #17098

5 commits merged into from
Mar 5, 2021

Conversation

iscai-msft
Copy link
Contributor

fixes #16498

iscai-msft
iscai-msft commented Mar 4, 2021
View reviewed changes
sdk/textanalytics/azure-ai-textanalytics/tests/test_analyze_healthcare_async.py Outdated
# currently can only test certainty
# have an issue to update https://github.com/Azure/azure-sdk-for-python/issues/17088
# meningitis_entity = next(e for e in result[0].entities if e.text == "Meningitis")
# assert meningitis_entity.assertion.certainty == EntityCertainty.NEGATIVE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out code checking the certainty. This is due to a mismatch between what the swagger has defined as the casing, and the actual casing sent over the wire.

Have a PR out for this, blocked on checking what the desired behavior is, @abhahn is looking into this (thanks @abhahn !)

maririos
maririos approved these changes Mar 4, 2021
View reviewed changes
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/_models.py
class HealthcareEntityAssertion(DictMixin):
"""Contains various assertions about a `HealthcareEntity`.

For example, if an entity is a diagnosis, is this diagnosis 'conditional' on a symptom?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the docstring. I copied them for .NET :)

@iscai-msft
fix repr test
9c67431
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f297542 
…into assertions

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [core] add HttpRequest and HttpResponse reprs (Azure#16972)
  [text analytics] add actual normalized_text tests (Azure#17123)
  update samples to use actual role names (Azure#17124)
  Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085)
  Enable APIView status check (Azure#17107)
  Fix PackageName typo (Azure#17109)
  Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103)
  Fix paths for non-windows agents (Azure#17096)
  [Communication] - Identity - Update README (Azure#17091)
  Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090)
  fix shared reqs (Azure#17095)
  [translation] initial library (Azure#16837)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
@iscai-msft
remove enums under assertion and replaced with str due to swagger issue
e79c9a5
@ghost
Copy link

ghost commented Mar 5, 2021

Hello @iscai-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit c407bd1 into Azure:master Mar 5, 2021
iscai-msft added a commit to abhahn/azure-sdk-for-python that referenced this pull request Mar 5, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
a49dd8e 
…into ta-v5.1.0b6-analyze

* 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits)
  [text analytics] PII updates for v5.1.0b6 (Azure#17038)
  Fix bug where imported matrix parameter duplicates are not overrided (Azure#17126)
  Add NULL to readme (Azure#17076)
  Sas batching (Azure#17133)
  dropping py3.5 (Azure#17127)
  [EventHubs] 5.3.1 update changelog (Azure#17132)
  [text analytics] assertions (Azure#17098)
  add recordings (Azure#17125)
  [core] add HttpRequest and HttpResponse reprs (Azure#16972)
  [text analytics] add actual normalized_text tests (Azure#17123)
  update samples to use actual role names (Azure#17124)
  Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085)
  Enable APIView status check (Azure#17107)
  Fix PackageName typo (Azure#17109)
  Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103)
  Fix paths for non-windows agents (Azure#17096)
  [Communication] - Identity - Update README (Azure#17091)
  Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090)
  fix shared reqs (Azure#17095)
  [translation] initial library (Azure#16837)
  ...
@iscai-msft iscai-msft deleted the assertions branch May 13, 2021 22:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

@abhahn abhahn Awaiting requested review from abhahn

@kristapratico kristapratico Awaiting requested review from kristapratico

@mssfang mssfang Awaiting requested review from mssfang

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

@suhas92 suhas92 Awaiting requested review from suhas92

Assignees
No one assigned
Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[text analytics] Healthcare updates for v3.1-preview.4
2 participants
@iscai-msft @maririos