Add Test Environment that runs tests w/out aiohttp #17718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
scbedd
commented
Mar 31, 2021
scbedd
commented
Mar 31, 2021
| {envbindir}/python -m pip freeze | ||
| pytest \ | ||
| {[testenv]default_pytest_params} \ | ||
| --ignore-glob='*_async.py' \ |
There was a problem hiding this comment.
Not having this means that async tests implode with
|
Within the try:
import aiohttp
raise Exception("aiohttp was not successfully installed")
except ImportError:
pass |
|
I see what you're going after here. I'll add something like it. |
…r if we can import from any of them
|
@seankane-msft added! |
clean imports Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com>
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@seankane-msft
This is related to this issue.
Can you poke holes in my logic? We don't really have anything to key off to identify one of these "optional" requirements that may or may not be present. So it's not really a case of extending
create_package_and_install.pyto identify additional requirements.To solve this generically without messing with anyone's day-to-day development, I created a new tox environment
whl_no_aio. This is essentially a retread ofwhl(aka the default) tox environment. The only difference is that have an error-ignored line (notice the leading-) that attempts uninstall of aiohttp prior to invoking any of the install or test commands.