Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Fix for async retry policy #17810

Merged
merged 6 commits into from
Apr 6, 2021
Merged

Conversation

annatisch
Copy link
Member

No description provided.

@annatisch annatisch requested a review from seankane-msft as a code owner April 5, 2021 22:01
@ghost ghost added the Tables label Apr 5, 2021
Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise LGTM

Comment on lines 108 to 112
callback = ResponseCallback(status=201, new_status=408).override_status

try:
# The initial create will return 201, but we overwrite it and retry.
# The retry will then get a 409 and return false.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the callback says new_status=408 but your comment says the retry is a 409, just for clarification is it expecing a 408 or 409?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually both - I will update the comments to be clearer.

sdk/tables/azure-data-tables/tests/test_retry.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry_async.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry_async.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry_async.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_retry_async.py Outdated Show resolved Hide resolved
@annatisch
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@annatisch annatisch merged commit 824665d into Azure:master Apr 6, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 15, 2022
[Azure Data Factory] Support rest-based connectors in ADF (I) (Azure#17810)

* Enable excel in public swagger

* update

* rollback dataflow change

* Support rest-based connectors in ADF (I)

* update

* Update

Co-authored-by: zhanyu2014 <zhanyu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants