[Tables] Removed batching result #18132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
commented
Apr 19, 2021
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Comment on lines
+417
to
+421
| def extract_batch_part_metadata(response_part): | ||
| metadata = {} | ||
| if 'Etag' in response_part.headers: | ||
| metadata['etag'] = response_part.headers['Etag'] | ||
| return metadata |
There was a problem hiding this comment.
Can we return either the etag or None instead of packaging one item into a dictionary?
There was a problem hiding this comment.
The intention is to allow for growth - if the service ever starts returning other headers or useful info. For example, a number of these operation support the echo responses on create/update - so potentially that could be supported with this dictionary.
seankane-msft
approved these changes
Apr 19, 2021
seankane-msft
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.