Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added policy Reset APIs; Cleaned up several model types. #18679

Merged
merged 11 commits into from
May 13, 2021
Merged

Added policy Reset APIs; Cleaned up several model types. #18679

merged 11 commits into from
May 13, 2021

Conversation

LarryOsterman
Copy link
Member

First round of post-initial release fixes to attestation SDK for python.

This adds a missing reset_policy API that was accidentally left out of the initial release.
It also removes all the generated model types from the exposed API surface, and cleans up a bunch of the documentation for the
attestation APIs.

@LarryOsterman LarryOsterman requested a review from a team as a code owner May 12, 2021 20:57
seankane-msft
seankane-msft approved these changes May 13, 2021
View reviewed changes
Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments about docs, then it should be good to go.

sdk/attestation/azure-security-attestation/azure/security/attestation/_administration_client.py Outdated Show resolved Hide resolved
sdk/attestation/azure-security-attestation/azure/security/attestation/_administration_client.py Outdated Show resolved Hide resolved
sdk/attestation/azure-security-attestation/azure/security/attestation/_client.py Outdated Show resolved Hide resolved
@LarryOsterman LarryOsterman merged commit 494f407 into Azure:master May 13, 2021
@LarryOsterman LarryOsterman deleted the LarryO-AddedPolicyReset branch May 13, 2021 19:48
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 13, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f8198fe 
…into add_logging_param

* 'master' of https://github.com/Azure/azure-sdk-for-python: (33 commits)
  [text analytics] rerecord (Azure#18731)
  [agrifood] generation for azure-agrifood-farming  (Azure#18713)
  [SB/EH] temporarily remove mgmt from ci pipeline (Azure#18724)
  bump core version (Azure#18723)
  Added policy Reset APIs; Cleaned up several model types. (Azure#18679)
  update release date (Azure#18704)
  Fixed PathProperties class init issue (Azure#18559)
  [agrifood] ignore swagger readme (Azure#18714)
  update for aiohttp 3.6 (Azure#18715)
  Renamed remaining connection string EV references (Azure#18682)
  Increment package version after release of azure-containerregistry (Azure#18683)
  skip live recording (Azure#18712)
  Increment package version after release of azure-identity (Azure#18710)
  Sample demonstrating authentication with a Key Vault certificate (Azure#18109)
  [AutoRelease] t2-storage-2021-05-13-13723 (Azure#18691)
  [AutoRelease] t2-loganalytics-2021-05-13-47912 (Azure#18694)
  useless sdk folder del (Azure#18688)
  [AutoRelease] t2-resource-2021-05-13-95786 (Azure#18686)
  update release date (Azure#18689)
  bump autorest version from '3.3.0' to '3.4.2' (Azure#18662)
  ...
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request May 5, 2022
@moranraz @jungph808
@rpressburger @ityankel @ArcturusZhang
CodeGen from PR 18796 in Azure/azure-rest-api-specs
bd7e694 
dev-Sentinel-2022-05-01-preview (Azure#18796)

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* Added fileImports.json (Azure#18540)

* Added fileImports.json

* add example files

* move example files

* delete old example files

* fix get file import by id example

* fix delete file import example

* fix typos

* resolve issues

* fix date

* more issue resolving

* .

* .

* add location to delete example

* support 200

* resolve comments

* update example

* remove whitespace

* readonly

* operationId

* revert file imports (Azure#18663)

* add securityMLAnalyticsSettings to securityInsights (Azure#18679)

* add securityMLAnalyticsSettings to securityInsights

* update for operationIdNounConflictingModelNames

* update plurality

* update

* add settingsdefinintionid field for anomalySettings

* Add Anomaly to timeline items (Azure#18675)

* Add Anomaly to timeline items

* Add exmaple of anomaly

* Add x-ms-identifiers

* fix  issue
fix x-m-id issue.
fix lint

* Change enum name

* REmove timeline from inceidents

* swap enum definistion and name

* Align SKU descriptions (Azure#18874)

* Align SKU descriptions

* Remove Sku model from Settings as it's not in use and has conflict with another trype.

* Update AutomationRules.json (Azure#18630)

* Update automation rules swagger

* Update examples

* fix examples

* fix naming typo

* run prettier

* run prettier on missing file

* remove logic app arm id from required

* remove a tag with errors (Azure#18916)

Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com>
Co-authored-by: jungph808 <100548649+jungph808@users.noreply.github.com>
Co-authored-by: rpressburger <93909726+rpressburger@users.noreply.github.com>
Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com>
Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankane-msft seankane-msft seankane-msft approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LarryOsterman @seankane-msft