Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault] Reorder set_role_definition parameters #18743

Merged
merged 2 commits into from
May 27, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented May 14, 2021

Python's contribution to #18579.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels May 14, 2021
@mccoyp mccoyp requested review from chlowell and schaabs as code owners May 14, 2021 03:42
@mccoyp mccoyp merged commit b6e6bc0 into Azure:master May 27, 2021
@mccoyp mccoyp deleted the role-def-params branch May 27, 2021 00:36
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jun 1, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Aug 10, 2022
[Hub Generated] Review request for Microsoft.Devices to add version preview/2022-04-30-preview (Azure#18743)

* Adds base for updating Microsoft.Devices from version preview/2021-07-02-preview to version 2022-04-30-preview

* Updates readme

* Updates API version in new specs and examples

* Add RoutingCosmosDBCollectionProperties to iothub.json.

* Update naming.

* Fix enum.

* Unique x-ms-enum names.

* Use same name for same enum def.

* Revert "Use same name for same enum def."

This reverts commit 6279e703315921b21ca72f306850305f91743874.

* Use same name for enum.

* Revert "Use same name for enum."

This reverts commit 366c4b337da16aa23bf3eac86095f0d1f0b7418e.

* Adds suppression to readme

* Revert "Revert "Use same name for enum.""

This reverts commit 15b8dc9796d24b34c476d980f4c9c2b2d64a7881.

* Update reason on UniqueXmsEnumName suppression.

* Ensure camel casing on partitionKeyName and partitionKeyTemplate.

* Add 'deviceid' to custom-words.txt.

* Add x-ms-secret.

* Remove secret tag for storage endpoint connection string.

* Adding the change for rootCertificateV2

* typo

* fixing validation error

* Update error response schema

* fixing tag

* adding Azure-AsyncOperation as header

* fix: adding Azure-AsyncOperation as header

* Fix semantic error

* header fix

* adding x-ms-identifiers

* fix

* fix

* prettier fix

* Azure-Async header position testing

* re-trigger stuck queue validation jobs

* revert change

* testing Azure AsyncOperation header

* Adding Azure-AsyncOperation to other possible place to mitigate the error

* make small change to retrigger the check queue

* Adding Async Operation header to the examples.

* fix format

* Typo fix

* revert the change of error details schema

* Revert unwanted changes

Co-authored-by: Jared Wilson <jaredwilson@microsoft.com>
Co-authored-by: Chris Huang <huangc@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants