Import msal_extensions only when needed #20095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mccoyp
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, msal_extensions depends on pywin32, which isn't importable in some environments (see #19989 for an example). Importing anything from
azure.identitywill import msal_extensions and thus pywin32 so when the latter isn't importable neither is anything inazure.identity. This PR movesimport msal_extensionsinto the functions which require it, allowing applications to avoid importing pywin32. Persistent caching still won't work without pywin32, and neither will DefaultAzureCredential if it tries to load the shared cache, but this makes it possible for affected applications to carry on with a reduced feature set.