Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress CredScan warnings for test proxy devcert #20324

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Aug 17, 2021

This suppresses a CredScan warning that comes from a non-secret devcert necessary for using the new test proxy.

@@ -36,6 +36,7 @@
},
{
"file":[
"eng/common/testproxy/dotnet-devcert.pfx",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi: @scbedd this might need to be added to other language suppressions.

@mccoyp mccoyp merged commit 035fce2 into main Aug 17, 2021
@mccoyp mccoyp deleted the devcert-suppress branch August 17, 2021 22:48
iscai-msft added a commit that referenced this pull request Aug 23, 2021
…into header_tuples

* 'main' of https://github.com/Azure/azure-sdk-for-python: (104 commits)
  [Key Vault] Add 7.3-preview support for administration (#20364)
  Fix Monitor opentelemetry exporter readme issues (#19038)
  More Renaming in query (#20303)
  Update CODEOWNERS (#20366)
  [ServiceBus] update migration guide with message count info (#20360)
  [rest] change text from a property to a method (#20290)
  Handle value types for results (#20358)
  Remove old unused update changelog script (#20357)
  bump node version (#20353)
  [AutoRelease] t2-web-2021-08-03-73015 (#20053)
  Fix query batch processing (#20345)
  Sync eng/common directory with azure-sdk-tools for PR 1912 (#20340)
  Increment version for schemaregistry releases (#20326)
  [SchemaRegistry] prepare avro for release (#20321)
  Update CHANGELOG.md (#20334)
  Update main.py (#20332)
  Removing C:\Git\azure-sdk-tools\eng\common\scripts\FilterPoliCheckResults.ps1 as it was no longer used (#20325)
  Suppress CredScan warning for test proxy devcert (#20324)
  [SchemaRegistry] update samples readme (#20323)
  [Test Proxy] Add RecordedByProxy decorator and AzureRecordedTestCase (#20138)
  ...
jeremymeng added a commit to jeremymeng/azure-sdk-for-js that referenced this pull request Aug 23, 2021
This suppresses a CredScan warning that comes from a non-secret devcert
necessary for using the new test proxy. (See related Python PR at
Azure/azure-sdk-for-python#20324)
jeremymeng added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 24, 2021
This suppresses a CredScan warning that comes from a non-secret devcert
necessary for using the new test proxy. (See related Python PR at
Azure/azure-sdk-for-python#20324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants