-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ServiceBus] Fix TTL on messages #21869
Conversation
Thank you for your contribution jyggen! We will review the pull request and get back to you soon. |
nice catch! thanks @jyggen for the PR! |
/azp run python - servicebus - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test passed, appreciate your contribution, your fix will be included in our next release🎉
Hello @yunhaoling! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Using
seconds
ontimedelta
to set TTL leads to unexpected behaviour with, for example,timedelta(days=1)
:Instead of
seconds
,total_seconds()
should be used: