Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA release for NetworkTraversal #22415

Merged
merged 5 commits into from
Feb 3, 2022

Conversation

AriZavala2
Copy link
Contributor

@AriZavala2 AriZavala2 commented Jan 10, 2022

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Jan 10, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-identity. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.0
+ # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.1

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-chat. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.0
+ # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.1

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-sms. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.0
+ # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.1

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-phonenumbers. You can review API changes here

API changes

- # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.0
+ # Package is parsed using api-stub-generator(version:0.2.7), Python version: 3.10.1

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-networktraversal. You can review API changes here

@AriZavala2 AriZavala2 force-pushed the AriZavala2/ga_review branch from 0120be3 to 3927702 Compare February 2, 2022 18:34
@AriZavala2 AriZavala2 marked this pull request as ready for review February 2, 2022 18:36
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-networktraversal. You can review API changes here

@AriZavala2
Copy link
Contributor Author

Updating Changelog and README in next commit

@AriZavala2 AriZavala2 changed the title GA changes, API View feedback GA release for NetworkTraversal Feb 2, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-networktraversal. You can review API changes here

@AriZavala2
Copy link
Contributor Author

Addressing changes requested in API view. https://apiview.dev/Assemblies/Review/39f6d92be3974ffb92618cea05fb81be @annatisch

@check-enforcer
Copy link

check-enforcer bot commented Feb 3, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@AriZavala2 AriZavala2 force-pushed the AriZavala2/ga_review branch from 81418fb to 2f9ea0c Compare February 3, 2022 19:02
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-communication-networktraversal. You can review API changes here

@AriZavala2
Copy link
Contributor Author

/azp run python - azure-communication-networktraversal - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jbeauregardb jbeauregardb merged commit 88d1b54 into Azure:main Feb 3, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* GA changes, API View feedback

* Remove undesired file

* Resolve PR comments

* Fix version number

* Update PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants