[ServiceBus] release message in background #23285

yunhaoling · 2022-03-02T21:29:43Z

addressing issue: #23020

based on @annatisch 's approach: #23212

how it works:

overload the keep-alive background task for polling socket when prefetch is 1
using threading.event for indication of whether a message arrives in a receiving context or non-receiving context

cons:
overloading keep_alive result in bad-perf, increase cpu workload.

azure-sdk · 2022-03-02T21:51:31Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001D79C98F4F0>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000025A076DB4F0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001D79C47D0F0>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000025A071CD120>,

sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py

sdk/servicebus/azure-servicebus/azure/servicebus/_common/receiver_mixins.py

azure-sdk · 2022-03-09T09:09:29Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024C69033070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000191C579EDD0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024C68B11D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000191C5271D50>,

azure-sdk · 2022-03-09T10:18:23Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024C69033070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001855E3FEDD0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024C68B11D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001855DED1D50>,

azure-sdk · 2022-03-09T19:40:38Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023A43737070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001A4FD92F220>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000023A43211D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001A4FD401D50>,

sdk/servicebus/azure-servicebus/azure/servicebus/_common/receiver_mixins.py

sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py

sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_receiver_async.py

azure-sdk · 2022-03-10T21:42:55Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000019AD5823070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001FF65B334C0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000019AD5301D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001FF65601D50>,

azure-sdk · 2022-03-10T22:35:14Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000019AD5823070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001F022C034C0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000019AD5301D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001F0226D1D50>,

yunhaoling · 2022-03-10T23:03:53Z

/azp run python - servicebus - tests

azure-pipelines · 2022-03-10T23:04:08Z

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling · 2022-03-11T22:57:18Z

/azp run python - servicebus - tests

azure-sdk · 2022-03-11T23:16:26Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002AE0D367070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000025C3D8AF4C0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002AE0CE41D20>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000025C3D381D50>,

yunhaoling · 2022-03-12T00:43:06Z

/azp run python - servicebus - tests

azure-pipelines · 2022-03-12T00:43:20Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py

yunhaoling · 2022-03-16T07:11:53Z

/azp run python - servicebus - tests

azure-pipelines · 2022-03-16T07:12:07Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2022-03-16T07:25:46Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002418F3D3070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002C4CF99E9B0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002418EEB1CF0>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002C4CF471D80>,

yunhaoling · 2022-03-16T23:09:35Z

/azp run python - servicebus - tests

azure-pipelines · 2022-03-16T23:09:49Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2022-03-16T23:21:18Z

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015A53883070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002208C87E9B0>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015A53361DB0>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002208C351D80>,

yunhaoling · 2022-03-17T04:33:21Z

/azp run python - servicebus - tests

azure-pipelines · 2022-03-17T04:33:35Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2022-04-06T07:54:09Z

API change check for azure-servicebus

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000252A5A27220>, 
+             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000239DEF53100>, 
-             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000252A54F9540>, 
+             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000239DEA19540>,

* release message in background * decouple keep receiving and fix async * small fix * fix mypy and pylint * review feedback * fix pylint and update changelog * update test to reflect the latest change * add tests and replace uamqp keep alive * fix impl bug * add test non-releasing behavior * update release date

Release machinelearningservices microsoft.machine learning services 2023 04 01 preview (Azure#23449) * Adds base for updating Microsoft.MachineLearningServices from version preview/2023-02-01-preview to version 2023-04-01-preview * Updates readme * Updates API version in new specs and examples * [Preview] Bring Back Scheduled Shutdown MLC models (Azure#23040) * [Preview] Bring Back Scheduled Shutdown MLC models * update example json --------- Co-authored-by: Naman Agarwal <naagarw@microsoft.com> * add minLength:1 prop to required strings (Azure#23108) * add parameter enableDataIsolation to workspace properties (Azure#23061) * add parameter enableDataIsolation to workspace properties * minor change to re-run the test pipelines * minor comment change to trigger the test pipeline again --------- Co-authored-by: Mingwei He <mingweihe@microsoft.com> * expose connection expiryTime in 2023-04-01-preview swagger (Azure#23118) * Add Workspace Managed Network Swagger (Azure#23283) * add managed network swagger * fix validation errors * address ARM comments * fix example * do not flatten outbound rules, need nested props --------- Co-authored-by: Josh Harrington <joharrington@microsoft.com> * Add Registries 2023-04-01-Preview Swagger (Azure#23163) * x * fix spellcheck * update preview examples * update examples * fix for swagger modelvalidation gate * examples should be in camelCase * more fixes for pr gates * fix syntax * add registryNameParameter * addressing comments * fix one more location property * address comments * update PrivateEndpointConnectionProperties * git didn't push all of my changes * fix circular dependency * update * PATCH operation should have sku, identity properties --------- Co-authored-by: Komal Yadav <komalyadav@microsoft.com> * MFE April-preview 2023 staging (Azure#23165) * update mfe.json to latest * update preview examples * make it pretty * createOrUpload example touch-ups * pretty check * POST pendingUpload lint violation, description, and array * spell check fixes * featurestore updates + notification patch updates to align with jobs * fix feature examples * rename PendingUpload -> startPendingUpload + better description * prettier feature get/list.json * update Job-Update example * update descriptions * x-ms-secret-true, remove wasbs and pattern for registries * update examples to remove wasbsUri * update registry refrence and add pattern to featuresetname * temporarily add in registry reference * one more pattern add-on for featuresetname * remove wasbs since that is no longer a part of PR * bump * add empty secrets to examples - can show object but hide secret itself * original-uri -> azure-async-operation * createOrGetPendingUpload -> createOrGetStartPendingUpload * add ms-secret to uri to keep it from breaking relative to GA --------- Co-authored-by: Kayla Ames <kaseager@microsoft.com> * [HUB] update team configuration related properties (Azure#23285) * [HUB] update team configuration related properties * Update description * fix merge issue * update workspace get operation example with managenetwork included (Azure#23411) * custom words merge * swap to original-uri * v5->v3 * registryRenames * mlc update to align with v3 types * finish updating examples --------- Co-authored-by: Naman Agarwal <namanag16@gmail.com> Co-authored-by: Naman Agarwal <naagarw@microsoft.com> Co-authored-by: Teddy Todorov <thtodoro@microsoft.com> Co-authored-by: Ming <hemingwei2017@gmail.com> Co-authored-by: Mingwei He <mingweihe@microsoft.com> Co-authored-by: jiewe <127981966+jiewe@users.noreply.github.com> Co-authored-by: Josh Harrington <53531213+joshharrin@users.noreply.github.com> Co-authored-by: Josh Harrington <joharrington@microsoft.com> Co-authored-by: Komal Yadav <23komal.yadav23@gmail.com> Co-authored-by: Komal Yadav <komalyadav@microsoft.com> Co-authored-by: Kayla Ames <kaseager@microsoft.com> Co-authored-by: ZhidaLiu <zhili@microsoft.com>

release message in background

22cca4d

ghost added the Service Bus label Mar 2, 2022

annatisch reviewed Mar 3, 2022

View reviewed changes

decouple keep receiving and fix async

cc10d34

small fix

45df64e

fix mypy and pylint

eb0098f

yunhaoling marked this pull request as ready for review March 9, 2022 21:10

yunhaoling requested review from swathipil and rakshith91 as code owners March 9, 2022 21:10

annatisch reviewed Mar 10, 2022

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/_common/receiver_mixins.py Show resolved Hide resolved

annatisch reviewed Mar 10, 2022

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py Outdated Show resolved Hide resolved

annatisch reviewed Mar 10, 2022

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/aio/_servicebus_receiver_async.py Show resolved Hide resolved

yunhaoling mentioned this pull request Mar 10, 2022

[AMQP Python] MISC improvement #23473

Closed

review feedback

fa38a9d

fix pylint and update changelog

567f7e7

update test to reflect the latest change

cfff5a5

annatisch reviewed Mar 14, 2022

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/_servicebus_receiver.py Outdated Show resolved Hide resolved

add tests and replace uamqp keep alive

fba148d

fix impl bug

0a33030

annatisch approved these changes Apr 5, 2022

View reviewed changes

yunhaoling added 2 commits April 6, 2022 00:34

add test non-releasing behavior

56bd2df

update release date

8651214

yunhaoling merged commit 233fbea into Azure:main Apr 6, 2022

yunhaoling deleted the yuling/sb/release-msg branch April 6, 2022 08:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ServiceBus] release message in background #23285

[ServiceBus] release message in background #23285

yunhaoling commented Mar 2, 2022 •

edited

Loading

azure-sdk commented Mar 2, 2022

azure-sdk commented Mar 9, 2022

azure-sdk commented Mar 9, 2022

azure-sdk commented Mar 9, 2022

azure-sdk commented Mar 10, 2022

azure-sdk commented Mar 10, 2022

yunhaoling commented Mar 10, 2022

azure-pipelines bot commented Mar 10, 2022

yunhaoling commented Mar 11, 2022

azure-sdk commented Mar 11, 2022

yunhaoling commented Mar 12, 2022

azure-pipelines bot commented Mar 12, 2022

yunhaoling commented Mar 16, 2022

azure-pipelines bot commented Mar 16, 2022

azure-sdk commented Mar 16, 2022

yunhaoling commented Mar 16, 2022

azure-pipelines bot commented Mar 16, 2022

azure-sdk commented Mar 16, 2022

yunhaoling commented Mar 17, 2022

azure-pipelines bot commented Mar 17, 2022

azure-sdk commented Apr 6, 2022

[ServiceBus] release message in background #23285

[ServiceBus] release message in background #23285

Conversation

yunhaoling commented Mar 2, 2022 • edited Loading

azure-sdk commented Mar 2, 2022

azure-sdk commented Mar 9, 2022

azure-sdk commented Mar 9, 2022

azure-sdk commented Mar 9, 2022

azure-sdk commented Mar 10, 2022

azure-sdk commented Mar 10, 2022

yunhaoling commented Mar 10, 2022

azure-pipelines bot commented Mar 10, 2022

yunhaoling commented Mar 11, 2022

azure-sdk commented Mar 11, 2022

yunhaoling commented Mar 12, 2022

azure-pipelines bot commented Mar 12, 2022

yunhaoling commented Mar 16, 2022

azure-pipelines bot commented Mar 16, 2022

azure-sdk commented Mar 16, 2022

yunhaoling commented Mar 16, 2022

azure-pipelines bot commented Mar 16, 2022

azure-sdk commented Mar 16, 2022

yunhaoling commented Mar 17, 2022

azure-pipelines bot commented Mar 17, 2022

azure-sdk commented Apr 6, 2022

yunhaoling commented Mar 2, 2022 •

edited

Loading