Skip to content

remove validate_authority #23625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2022
Merged

remove validate_authority #23625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc85f18
remove validate_authority
xiangyan99 Mar 23, 2022
a450ad5
Update sdk/identity/azure-identity/setup.py
xiangyan99 Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
# Release History

## 1.9.0b2 (Unreleased)
## 1.9.0 (Unreleased)

### Features Added

### Breaking Changes

- `validate_authority` support is not available in 1.9.0.

### Bugs Fixed

- Added check on `content` from msal response ([#23483](https://github.com/Azure/azure-sdk-for-python/issues/23483))
Expand Down
4 changes: 2 additions & 2 deletions sdk/identity/azure-identity/azure/identity/_internal/msal_credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class MsalCredential(object):
def __init__(self, client_id, client_credential=None, **kwargs):
# type: (str, Optional[Union[str, Dict]], **Any) -> None
authority = kwargs.pop("authority", None)
self._validate_authority = kwargs.pop("validate_authority", True)
# self._validate_authority = kwargs.pop("validate_authority", True)
self._authority = normalize_authority(authority) if authority else get_default_authority()
self._regional_authority = os.environ.get(EnvironmentVariables.AZURE_REGIONAL_AUTHORITY_NAME)
self._tenant_id = kwargs.pop("tenant_id", None) or "organizations"
Expand Down Expand Up @@ -73,7 +73,7 @@ def _get_app(self, **kwargs):
azure_region=self._regional_authority,
token_cache=self._cache,
http_client=self._client,
validate_authority=self._validate_authority
# validate_authority=self._validate_authority
)

return self._client_applications[tenant_id]
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/azure/identity/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
# ------------------------------------
VERSION = "1.9.0b2"
VERSION = "1.9.0"
2 changes: 1 addition & 1 deletion sdk/identity/azure-identity/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
author_email="azpysdkhelp@microsoft.com",
url="https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/identity/azure-identity",
classifiers=[
"Development Status :: 4 - Beta",
"Development Status :: 5 - Production/Stable",
"Programming Language :: Python",
"Programming Language :: Python :: 3 :: Only",
"Programming Language :: Python :: 3",
Expand Down