Skip to content

[Key Vault] Final updates for releases #23664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2022
Merged

[Key Vault] Final updates for releases #23664

merged 2 commits into from
Mar 25, 2022

Conversation

@mccoyp
Copy link
Member

@mccoyp mccoyp commented Mar 25, 2022 •
edited
Loading

Description

This gets the final things in order to release KV packages tomorrow (3/25), with two main changes:

  1. New, real recordings for azure-keyvault-administration tests on API version 7.3 (finally got an HSM deployed)
  2. Changelogs updated for the correct release date, and with the full set of relevant changes since the last stable release

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. labels Mar 25, 2022
@mccoyp
Copy link
Member Author

mccoyp commented Mar 25, 2022

/azp run python - keyvault - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 25, 2022

Azure Pipelines successfully started running 1 pipeline(s).

@mccoyp mccoyp force-pushed the kv-final-updates branch from 48dde03 to 4250918 Compare March 25, 2022 03:21
@mccoyp mccoyp marked this pull request as ready for review March 25, 2022 03:22
@mccoyp mccoyp enabled auto-merge (squash) March 25, 2022 03:24
@mccoyp mccoyp merged commit e59504d into Azure:main Mar 25, 2022
@mccoyp mccoyp deleted the kv-final-updates branch March 25, 2022 15:52
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
@mccoyp @rakshith91
[Key Vault] Final updates for releases (Azure#23664)
097de83
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@mccoyp @rakshith91
[Key Vault] Final updates for releases (Azure#23664)
aee6e14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schaabs schaabs Awaiting requested review from schaabs

@YalinLi0312 YalinLi0312 Awaiting requested review from YalinLi0312

1 more reviewer

@seankane-msft seankane-msft seankane-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client This issue points to a problem in the data-plane of the library. KeyVault

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mccoyp @seankane-msft