-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EventHubs] Buffered Producer Implementation #23748
[EventHubs] Buffered Producer Implementation #23748
Conversation
API change check for API changes have been detected in |
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer_dispatcher.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/samples/sync_samples/send_buffered_mode.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer_dispatcher.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer_dispatcher.py
Outdated
Show resolved
Hide resolved
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_partition_resolver.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/samples/async_samples/send_buffered_mode_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/samples/sync_samples/send_buffered_mode.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/aio/_producer_client_async.py
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/azure/eventhub/_buffered_producer/_buffered_producer_dispatcher.py
Show resolved
Hide resolved
.../azure-eventhub/azure/eventhub/aio/_buffered_producer/_buffered_producer_dispatcher_async.py
Outdated
Show resolved
Hide resolved
sdk/eventhub/azure-eventhub/samples/async_samples/send_buffered_mode_async.py
Show resolved
Hide resolved
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
Overall architecture:
EHProducerClient 1 -> 1 EHBufferedProducerDispatcher 1 -> n EHBufferedProducer (for single partition)
Duty of EHBufferedProducerDispatcher:
Duty of EHBufferedProducer
Answers for behavior questions raised in the arch board:
what happens if calling close/flush in on_error callback (e.g. think about infinite error case)
deadlock in current implementation, we should be explicit that users should not perform flush in on_error/on_success.
definition for various timeout behavior and how users could handle
investigation of the buffer max behavior (limitation vs timing control? back pressure?)
in current implementation, if the remaining buffer isn't enough for the incoming events, call flush to clear the buffer first
Tasks
Related issue:
#23062
#23063