[EventHub] remove uamqp imports from EventData/EventDataBatch into plugin module #24259

swathipil · 2022-04-29T21:09:32Z

related to: #21246
fixes: #24239

* initial changes for receiving * undo __init__ aio * vendor * remove c/pyx files * adams comments

* draft send port * copy and paste code changes in amqp * simple stress test scripts for sending and receiving * review feedbacks

* port amqp send large message * send perf test in parallel * use context manager for executor * add throughput * improve test code * update test matrix * update test * handle server busy * fix timeout * precision to 2 decimal points * update pyamqp changes and update tests

…2397) * copy amqp changes * eh python amqp integration * fix time unit * rename module pyamqp to _pyamqp * more pyamqp to _pyamqp * simplify todo

* cherry pick changes * update docs * cherry pick fixed retry PR * minor fix * fix mypy, pylint, brokenlink * update doc * opt out mypy/pylint/api stub * try opt out checkpointstore in ci and test * fix * more fixes * furuther opt out tests * update tests * bump version * fix __str__ * add test play holder * ignore azure checkpoinstore aio in ci Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* async port * add scripts for tests * update async perf test scripts * fix test scripts * amqp implementation update + eh update + sync perf test scripts * update pyamqp and eh async impl and test scripts * update pyamqp async impl * fix bug * fix pyamqp transport ssl setting and asyncio exception module import * use ensure future for 3.6 * update token generation to return bytes to avoid breaking changes * update docs

Increment package version after release of azure-eventhub

* stop spawning too much coroutines * improve send * async recv perf improvement * async perf improve * update version * align with sync imple * update method name * remove redundant except catch

* update docs * add todo

Increment package version after release of azure-eventhub

azure-sdk · 2022-04-29T21:39:12Z

API change check for azure-eventhub

API changes have been detected in azure-eventhub. You can review API changes here

API changes

-             partition_key: str = None
+             partition_key: str = None, 
+             **kwargs

* Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

This reverts commit 0123f4d.

* Initial implementation * http proxy support * change impl * more changes * working sol * async impl * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * more changes * sasl mixin * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/message.py * refactor * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * Update sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_transport.py * oops * comments * comment * Apply suggestions from code review Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> * comments * changes * async test * rasie * lint * changelog * version * comments * move path to EH * Fix typo Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* initial changes for receiving * undo __init__ aio * vendor * remove c/pyx files * adams comments

* draft send port * copy and paste code changes in amqp * simple stress test scripts for sending and receiving * review feedbacks

* port amqp send large message * send perf test in parallel * use context manager for executor * add throughput * improve test code * update test matrix * update test * handle server busy * fix timeout * precision to 2 decimal points * update pyamqp changes and update tests

…2397) * copy amqp changes * eh python amqp integration * fix time unit * rename module pyamqp to _pyamqp * more pyamqp to _pyamqp * simplify todo

* cherry pick changes * update docs * cherry pick fixed retry PR * minor fix * fix mypy, pylint, brokenlink * update doc * opt out mypy/pylint/api stub * try opt out checkpointstore in ci and test * fix * more fixes * furuther opt out tests * update tests * bump version * fix __str__ * add test play holder * ignore azure checkpoinstore aio in ci Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

check-enforcer · 2022-06-02T23:22:32Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

Increment package version after release of azure-eventhub

…ansport methods to static

swathipil and others added 18 commits July 12, 2021 15:08

[EventHub] basic receive event scenario with pyamqp (Azure#19748)

c6f446d

* initial changes for receiving * undo __init__ aio * vendor * remove c/pyx files * adams comments

[EventHubs & AMQP Python] Send Port (Azure#19745)

4134fc0

* draft send port * copy and paste code changes in amqp * simple stress test scripts for sending and receiving * review feedbacks

[EventHubs] Pure Python AMQP Sycn Implementation Integration (Azure#2…

f11cc0f

…2397) * copy amqp changes * eh python amqp integration * fix time unit * rename module pyamqp to _pyamqp * more pyamqp to _pyamqp * simplify todo

merge main

67df9d8

catch up with main and update release date

dc7e79c

update readme to drop uamqp

996e419

revert async tests

986d2a4

revert aio module in eventhub

e37fc23

merge main branch

0fb1af9

Increment version for eventhub releases (Azure#22994)

e8bbe38

Increment package version after release of azure-eventhub

merge central

fe47341

[EH Pyproto] Async recv perf improvement (Azure#23122)

2805d00

* stop spawning too much coroutines * improve send * async recv perf improvement * async perf improve * update version * align with sync imple * update method name * remove redundant except catch

[EH Pyproto] Release updates (Azure#23349)

17ea44b

* update docs * add todo

Increment version for eventhub releases (Azure#23420)

f5f9957

Increment package version after release of azure-eventhub

remove uamqp from EventData/EventDataBatch

de96d17

ghost added the Event Hubs label Apr 29, 2022

swathipil and others added 10 commits May 3, 2022 16:44

move all bits to Transport class

5277aed

more changes

267445e

Revert "AMQP websocket implementation (Azure#23722)" (Azure#24344)

bcab241

This reverts commit 0123f4d.

[EventHub] basic receive event scenario with pyamqp (Azure#19748)

3fcef28

* initial changes for receiving * undo __init__ aio * vendor * remove c/pyx files * adams comments

[EventHubs & AMQP Python] Send Port (Azure#19745)

56d551a

* draft send port * copy and paste code changes in amqp * simple stress test scripts for sending and receiving * review feedbacks

[EventHubs] Pure Python AMQP Sycn Implementation Integration (Azure#2…

dd96d59

…2397) * copy amqp changes * eh python amqp integration * fix time unit * rename module pyamqp to _pyamqp * more pyamqp to _pyamqp * simplify todo

swathipil and others added 7 commits June 6, 2022 21:03

[EventHubs] pyproto - update release date + docs (Azure#24723)

e60fff2

add async doc rst file

f62bae8

Increment version for eventhub releases (Azure#24753)

1ad3a2c

Increment package version after release of azure-eventhub

move uamqp from consumer to transport

403e852

receive with data/seq/val props added to amqp message

edac33c

move uamqp credentials to transport

4f6dedd

move uamqp bits to transport in client base

fb53ae2

swathipil mentioned this pull request Jun 23, 2022

add value/data/seq properties to message Azure/azure-uamqp-python#326

Merged

kashifkhan and others added 7 commits June 29, 2022 18:27

changes to update status (Azure#25024)

07c6f05

remove uamqp imports from shared

381e7cf

fixed receive bugs

5586dbd

fix negative test

678138e

update body of amqp message

141d2c0

merge pyamqp and uamqp changes + add pyamqp transport

da0791e

PYAMQP CLIENT UPDATED

9db8be0

swathipil mentioned this pull request Jul 13, 2022

[EventHub] merge uamqp and pyamqp #25193

Closed

10 tasks

swathipil added 11 commits July 20, 2022 16:16

fix receive bugs/event data bugs

455b06a

update amqp message body

c10f67c

fixing bugs in tests

87095b2

fix bug with pyamqp transport sending

0e6272c

adding things back for async unittests

dbd3044

run tests w/ + w/o uamqp installed

1f5cb73

add message backcompat

73c98ee

message backcompat fixes

8abde03

merge pyamqp switch back into uamqp

54f4974

merge buffered producer from main

a4d961d

align message property behavior w/ prev, add/fix tests, update all tr…

6f4b68d

…ansport methods to static

swathipil closed this Aug 1, 2022

swathipil mentioned this pull request Aug 23, 2022

[EventHubs] pyamqp rebase main with uamqp switch #25822

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EventHub] remove uamqp imports from EventData/EventDataBatch into plugin module #24259

[EventHub] remove uamqp imports from EventData/EventDataBatch into plugin module #24259

swathipil commented Apr 29, 2022

azure-sdk commented Apr 29, 2022

check-enforcer bot commented Jun 2, 2022

[EventHub] remove uamqp imports from EventData/EventDataBatch into plugin module #24259

[EventHub] remove uamqp imports from EventData/EventDataBatch into plugin module #24259

Conversation

swathipil commented Apr 29, 2022

azure-sdk commented Apr 29, 2022

check-enforcer bot commented Jun 2, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?