Skip to content

Fix detecting PEM cert #24844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix detecting PEM cert #24844

merged 1 commit into from
Jun 16, 2022

Conversation

xiangyan99
Copy link
Member

@xiangyan99 xiangyan99 requested a review from chlowell June 14, 2022 20:39
@ghost ghost added the Azure.Identity label Jun 14, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

mccoyp
mccoyp approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangyan99 xiangyan99 merged commit d3638ab into main Jun 16, 2022
@xiangyan99 xiangyan99 deleted the identity_parse_pem_cert branch June 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccoyp mccoyp mccoyp approved these changes

@chlowell chlowell Awaiting requested review from chlowell

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiangyan99 @azure-sdk @mccoyp