-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] DFS Encryption Scopes + Encryption Scope SAS For DataLake (STG84) #25211
Merged
vincenttran-msft
merged 15 commits into
Azure:feature/storage-stg84
from
vincenttran-msft:vincenttran/encryption_scope_sas_dlake
Jul 20, 2022
Merged
[Storage] DFS Encryption Scopes + Encryption Scope SAS For DataLake (STG84) #25211
vincenttran-msft
merged 15 commits into
Azure:feature/storage-stg84
from
vincenttran-msft:vincenttran/encryption_scope_sas_dlake
Jul 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_models.py
Show resolved
Hide resolved
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_service_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_models.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_directory.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_directory.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_models.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_models.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared_access_signature.py
Show resolved
Hide resolved
…verage for all SAS types
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_data_lake_service_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_datalake_service_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_datalake_service_client.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_directory.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_file_system.py
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_models.py
Show resolved
Hide resolved
sdk/storage/azure-storage-file-datalake/tests/test_datalake_service_client.py
Outdated
Show resolved
Hide resolved
…cases in ServiceClient
jalauzon-msft
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few minor imports to clean up or revert :)
Thanks for your hard work on this!
sdk/storage/azure-storage-file-datalake/tests/test_directory.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to implement the following features slated for STG84: