Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[azure-ai-textanalytics] CT Authoring Client #25601

Closed
wants to merge 17 commits into from
Closed

[azure-ai-textanalytics] CT Authoring Client #25601

wants to merge 17 commits into from

Conversation

LouaiZahran
Copy link

Description

The first version of the text analysis authoring client, developed using the GA specifications of 2022-05-01.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

LouaiZahran added 3 commits July 28, 2022 13:53
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 8, 2022
@ghost
Copy link

ghost commented Aug 8, 2022

Thank you for your contribution LouaiZahran! We will review the pull request and get back to you soon.

kristapratico
kristapratico reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good! Thanks for all your hard work on this 😎

sdk/cognitivelanguage/azure-ai-language-text/azure/ai/language/text/authoring/__init__.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/azure/ai/language/text/authoring/_client.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/azure/ai/language/text/authoring/_version.py Outdated Show resolved Hide resolved
...nguage/azure-ai-language-text/azure/ai/language/text/authoring/aio/operations/_operations.py Outdated Show resolved Hide resolved
...nguage/azure-ai-language-text/azure/ai/language/text/authoring/aio/operations/_operations.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/samples/authoring/sample_create_project.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/samples/authoring/sample_delete_project.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/samples/authoring/sample_delete_project.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/samples/authoring/sample_export_project.py Outdated Show resolved Hide resolved
sdk/cognitivelanguage/azure-ai-language-text/swagger/README.md Outdated Show resolved Hide resolved
@kristapratico kristapratico added Cognitive - Text Analytics and removed customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Aug 9, 2022
LouaiZahran added 7 commits August 9, 2022 13:29
@LouaiZahran LouaiZahran changed the title [ai-languages-text] CT Authoring Client v1.0.0 [azure-ai-textanalytics] CT Authoring Client Aug 10, 2022
@LouaiZahran
Copy link
Author

Thank you so much for the detailed review, @kristapratico ! Please review the changes one more time and tell me whether I should proceed with testing.

kristapratico
kristapratico reviewed Aug 10, 2022
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes! I left a few comments - you should be good to proceed with testing after those are addressed.

...analytics/azure-ai-textanalytics/azure/ai/textanalytics/authoring/_operations/_operations.py Outdated Show resolved Hide resolved
...analytics/azure-ai-textanalytics/azure/ai/textanalytics/authoring/_operations/_operations.py Outdated Show resolved Hide resolved
...analytics/azure-ai-textanalytics/azure/ai/textanalytics/authoring/_operations/_operations.py Outdated Show resolved Hide resolved
...analytics/azure-ai-textanalytics/azure/ai/textanalytics/authoring/_operations/_operations.py Outdated Show resolved Hide resolved
sdk/textanalytics/azure-ai-textanalytics/azure/ai/textanalytics/authoring/_patch.py Outdated Show resolved Hide resolved
sdk/textanalytics/azure-ai-textanalytics/samples/authoring/sample_deploy_project.py Outdated Show resolved Hide resolved
sdk/textanalytics/azure-ai-textanalytics/samples/authoring/sample_import_project.py Outdated Show resolved Hide resolved
sdk/textanalytics/azure-ai-textanalytics/swagger/authoring/README.md Outdated Show resolved Hide resolved
sdk/textanalytics/azure-ai-textanalytics/swagger/authoring/README.md Outdated Show resolved Hide resolved
sdk/textanalytics/azure-ai-textanalytics/swagger/authoring/README.md Outdated Show resolved Hide resolved
@LouaiZahran
Copy link
Author

@microsoft-github-policy-service agree [company="Microsoft"]

@LouaiZahran
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Sep 20, 2023
@deveshdama @pdaru @SanyaKochhar
CodeGen from PR 25633 in Azure/azure-rest-api-specs
faae000 
[Hub Generated] Review request for Microsoft.ContainerService/aks to add version stable/2023-08-01 (Azure#25633)

* Adds base for updating Microsoft.ContainerService/aks from version stable/2023-07-01 to version 2023-08-01

* Updates readme

* Updates API version in new specs and examples

* update (Azure#25468)

* Adding Azure Service Mesh and related changes. (Azure#25482)

* Adding Azure Service Mesh and related changes.

* Fix a typo with api version in examples

* fix a bug with egressGayeways for Istio

* add resourceuid field to managed cluster properties (Azure#25478)

* Adding examples for AzureServiceMesh (Azure#25535)

* Adding an example for AzureServiceMesh

* remove unneeded adonprofiles object

* Adding ingressGateway to the ASM example.

* Adding egressGateways to IstioComponents

* Add egressGateways to the request payload.

* Add BYO CA object to ServiceMeshProfile example

* Fix resource id format for Azure keyvault

* Enrich ASM examples (Azure#25597)

* add asm- prefix to upgrades field on mesh ops (Azure#25601)

---------

Co-authored-by: deveshdama <87668846+deveshdama@users.noreply.github.com>
Co-authored-by: daru__ <ptd2108@columbia.edu>
Co-authored-by: Sanya Kochhar <42152676+SanyaKochhar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayousef-zz kayousef-zz kayousef-zz left review comments

@kristapratico kristapratico kristapratico left review comments

@iscai-msft iscai-msft Awaiting requested review from iscai-msft

@abhahn abhahn Awaiting requested review from abhahn

Assignees
No one assigned
Labels
Cognitive - Text Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LouaiZahran @kristapratico @kayousef-zz