Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[attestation] update samples to use asyncio.run #26094

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[attestation] update samples to use asyncio.run #26094

merged 1 commit into from
Sep 12, 2022

Conversation

wonhyeongseo
Copy link
Contributor

Description

As #21207 mentions, some samples are using a loop variable for simple callbacks when this can be done by using the new run method of asyncio. This PR remedies the issue for the monitor library.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@wonhyeongseo wonhyeongseo requested review from anilba06, a team and gkostal as code owners September 8, 2022 14:13
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon.

LarryOsterman
LarryOsterman approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@LarryOsterman LarryOsterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristapratico kristapratico merged commit 17fdc93 into Azure:main Sep 12, 2022
@wonhyeongseo wonhyeongseo deleted the attestation-async-run branch September 13, 2022 00:24
mccoyp pushed a commit to mccoyp/azure-sdk-for-python that referenced this pull request Sep 22, 2022
@wonhyeongseo @mccoyp
fix: use asyncio.run instead of loop variable (Azure#26094)
3227609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarryOsterman LarryOsterman LarryOsterman approved these changes

@anilba06 anilba06 Awaiting requested review from anilba06 anilba06 is a code owner

@gkostal gkostal Awaiting requested review from gkostal gkostal is a code owner

Assignees
No one assigned
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wonhyeongseo @LarryOsterman @kristapratico