[Search] update samples to use asyncio.run #26145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kyc5644 <kyc5644@naver.com> Co-authored-by: SaidbySolo <saidbysolo@gmail.com> Co-authored-by: kyc5644 <kyc5644@naver.com> Co-authored-by: SaidbySolo <saidbysolo@gmail.com>
ghost
added
Search
customer-reported
|
Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon. |
|
/azp run python - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kristapratico
approved these changes
Sep 13, 2022
...rch/azure-search-documents/samples/async_samples/sample_index_alias_crud_operations_async.py
Show resolved
Hide resolved
|
This looks good to me, thank you! |
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
* fix: use asyncio.run instead of loop variable Co-authored-by: kyc5644 <kyc5644@naver.com> Co-authored-by: SaidbySolo <saidbysolo@gmail.com> Co-authored-by: kyc5644 <kyc5644@naver.com> Co-authored-by: SaidbySolo <saidbysolo@gmail.com> * pylint: added last line to missing files Co-authored-by: kyc5644 <kyc5644@naver.com> Co-authored-by: SaidbySolo <saidbysolo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As #21207 mentions, some samples are using a loop variable for simple callbacks when this can be done by using the new run method of asyncio. This PR remedies the issue for the search library.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines