[WebPubSub] update samples to use asyncio.run #26149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kyc5644 <kyc5644@naver.com> Co-authored-by: SaidbySolo <saidbysolo@gmail.com>
ghost
added
the
customer-reported
|
Thank you for your contribution wonhyeongseo! We will review the pull request and get back to you soon. |
iscai-msft
approved these changes
Sep 12, 2022
mccoyp
pushed a commit
to mccoyp/azure-sdk-for-python
that referenced
this pull request
Sep 22, 2022
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Nov 8, 2023
Release network microsoft.network official 2023 06 01 (Azure#26218) * Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (Azure#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (Azure#25887) * Firewall Policy - IDPS profiles (Azure#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (Azure#25982) * added ergwscale support (Azure#25969) * Fixed examples for gateway load balancer (Azure#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (Azure#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (Azure#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (Azure#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (Azure#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (Azure#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (Azure#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As #21207 mentions, some samples are using a loop variable for simple callbacks when this can be done by using the new run method of asyncio. This PR remedies the issue for the webpubsub library.
To my knowledge, this is the last library with the issue. May you please point me to a library that has this issue and does not have a PR? Thank you.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines