Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pyamqp] Pyamqp fix conn #26568

Merged
merged 3 commits into from
Oct 1, 2022
Merged

[Pyamqp] Pyamqp fix conn #26568

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d01118
remove unnecessary pops
kashifkhan Sep 30, 2022
0eb4d33
fix var name + remove unnecessary pop
kashifkhan Sep 30, 2022
ff02283
fix
kashifkhan Sep 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,8 +506,6 @@ def _incoming_end(self, channel, frame):
description="Invalid channel number received"
))
return
self._incoming_endpoints.pop(channel)
self._outgoing_endpoints.pop(channel)

def _process_incoming_frame(self, channel, frame): # pylint:disable=too-many-return-statements
# type: (int, Optional[Union[bytes, Tuple[int, Tuple[Any, ...]]]]) -> bool
Expand Down
6 changes: 2 additions & 4 deletions sdk/eventhub/azure-eventhub/azure/eventhub/_pyamqp/aio/_connection_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,8 +470,8 @@ async def _incoming_end(self, channel, frame):
"""
try:
await self._incoming_endpoints[channel]._incoming_end(frame) # pylint:disable=protected-access
self.incoming_endpoints.pop(channel)
self.outgoing_endpoints.pop(channel)
self._incoming_endpoints.pop(channel)
self._outgoing_endpoints.pop(channel)
except KeyError:
#close the connection
await self.close(
Expand All @@ -480,8 +480,6 @@ async def _incoming_end(self, channel, frame):
description="Invalid channel number received"
))
return
self._incoming_endpoints.pop(channel)
self._outgoing_endpoints.pop(channel)

async def _process_incoming_frame(self, channel, frame): # pylint:disable=too-many-return-statements
# type: (int, Optional[Union[bytes, Tuple[int, Tuple[Any, ...]]]]) -> bool
Expand Down