Remove requests dependency from PyPIClient

eng/tox/tox.ini

@@ -38,6 +38,7 @@ deps =
 pkgs =
     wheel==0.37.0
     packaging==20.4
+    urllib3==1.26.12
 
 
 [testenv]
@@ -220,7 +221,6 @@ setenv =
   PROXY_URL=http://localhost:5008
 deps =
   {[packaging]pkgs}
-  requests
   cryptography<4
 commands =
     {envbindir}/python -m pip install {toxinidir}/../../../tools/azure-sdk-tools --no-deps

tools/azure-sdk-tools/pypi_tools/pypi.py

@@ -1,6 +1,8 @@
 from packaging.version import parse as Version
 import sys
-
+import pdb
+from urllib3 import Retry, PoolManager
+import json
 
 def get_pypi_xmlrpc_client():
     """This is actually deprecated client."""
@@ -11,26 +13,24 @@ def get_pypi_xmlrpc_client():
 
 class PyPIClient:
     def __init__(self, host="https://pypi.org"):
-        import requests
-
         self._host = host
-        self._session = requests.Session()
+        self._http = PoolManager(retries=Retry(raise_on_status=True))
 
     def project(self, package_name):
-        response = self._session.get(
+        response = self._http.request(
+            'get',
             "{host}/pypi/{project_name}/json".format(host=self._host, project_name=package_name)
         )
-        response.raise_for_status()
-        return response.json()
+        return json.loads(response.data.decode('utf-8'))
 
     def project_release(self, package_name, version):
-        response = self._session.get(
+        response = self._http.request(
+            'get',
             "{host}/pypi/{project_name}/{version}/json".format(
                 host=self._host, project_name=package_name, version=version
             )
         )
-        response.raise_for_status()
-        return response.json()
+        return json.loads(response.data.decode('utf-8'))
 
     def filter_packages_for_compatibility(self, package_name, version_set):
         # only need the packaging.specifiers import if we're actually executing this filter.

tools/azure-sdk-tools/setup.py

@@ -20,6 +20,7 @@
     "pyopenssl",
     "python-dotenv",
     "PyYAML",
+    "urllib3"
 ]
 
 setup(

tools/azure-sdk-tools/tests/test_pypi_client.py

@@ -0,0 +1,45 @@
+from pypi_tools.pypi import PyPIClient
+from unittest.mock import patch
+import os
+import pytest
+import pdb
+
+
+class TestPyPiClient:
+    @pytest.mark.skipif(
+        os.environ.get("TF_BUILD", "None") == True,
+        reason=f"This test isn't worth recording and could be flaky. Skipping in CI.",
+    )
+    def test_package_retrieve(self):
+        client = PyPIClient()
+        result = client.project("azure-core")
+
+        # we won't _exhaustively_ check this, but we can sanity check a few proxy values to ensure we haven't broken anything
+        assert result["info"]["name"] == "azure-core"
+        assert len(result["releases"].keys()) > 47
+        assert "1.25.1" in result["releases"]
+        assert "1.10.0" in result["releases"]
+
+    @pytest.mark.skipif(
+        os.environ.get("TF_BUILD", "None") == True,
+        reason=f"This test isn't worth recording and could be flaky. Skipping in CI.",
+    )
+    def test_package_version_retrieve(self):
+        client = PyPIClient()
+        result = client.project_release("azure-core", "1.8.0")
+
+        assert result["info"]["name"] == "azure-core"
+        assert result["info"]["release_url"] == "https://pypi.org/project/azure-core/1.8.0/"
+
+    @pytest.mark.skipif(
+        os.environ.get("TF_BUILD", "None") == True,
+        reason=f"This test isn't worth recording and could be flaky. Skipping in CI.",
+    )
+    @patch("pypi_tools.pypi.sys")
+    def test_package_filter_for_compatibility(self, mock_sys):
+        mock_sys.version_info = (2, 7, 0)
+        client = PyPIClient()
+        result = client.get_ordered_versions("azure-core", True)
+        unfiltered_results = client.get_ordered_versions("azure-core", False)
+
+        assert len(result) < len(unfiltered_results)