Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Translation Text Service SDK #29569

Merged
merged 73 commits into from
Apr 6, 2023
Merged

Adding Translation Text Service SDK #29569

merged 73 commits into from
Apr 6, 2023

Conversation

MikeyMCZ
Copy link
Member

Description

Adding Translation Text Service SDK - https://learn.microsoft.com/en-us/azure/cognitive-services/translator/reference/v3-0-translate

ApiView - https://apiview.dev/Assemblies/Conversation/929808949dbf4c0fb72a0b51de7ec395
TypeSpec - https://github.com/Azure/azure-rest-api-specs/pull/23231/files

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@MikeyMCZ MikeyMCZ requested a review from kristapratico as a code owner March 24, 2023 14:28
@kristapratico
Copy link
Member

Is this ready for review or was I added by the automation? Let me know. :)

MikeyMCZ and others added 17 commits April 4, 2023 12:34
@MikeyMCZ @kristapratico
Update sdk/translation/azure-ai-translation-text/README.md
f285f64 
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
@MikeyMCZ @kristapratico
Update sdk/translation/azure-ai-translation-text/samples/README.md
dd3f154 
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
@MikeyMCZ @kristapratico
Update sdk/translation/azure-ai-translation-text/setup.py
a76cb46 
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Fixing PR comments
1abf440
Fixing PR comments
f08de36
Fixing PR comments
c7873aa
Fixing the links
13c31d6
Reference shared implementations
55f61f2
Sharing more implementation
3ab92f5
Removing unused imports
e016d9a
Using hasattr instead of isinstance
c084473
@MikeyMCZ
Merge branch 'Azure:main' into main
868bdfb
Fix build
ce54e14
Merge branch 'main' of https://github.com/MikeyMCZ/azure-sdk-for-python
2e97833
@MikeyMCZ
Merge branch 'Azure:main' into main
1471ed4
Sample update
4e7e7d2
Merge branch 'main' of https://github.com/MikeyMCZ/azure-sdk-for-python
8ac5ba8
kristapratico
kristapratico reviewed Apr 6, 2023
View reviewed changes
kristapratico
kristapratico reviewed Apr 6, 2023
View reviewed changes
@kristapratico kristapratico merged commit dafceb2 into Azure:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 left review comments

@kristapratico kristapratico kristapratico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MikeyMCZ @kristapratico @azure-sdk @xiangyan99 @HamshavathiM @scbedd @hamshavathimunibyraiah