Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise CredentialUnavailableError when finding an expired token #30441

Merged
merged 3 commits into from
May 31, 2023
Merged

raise CredentialUnavailableError when finding an expired token #30441

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
181ac87
raise `CredentialUnavailableError` when finding an expired token
xiangyan99 May 17, 2023
1561fe1
fix pylint
xiangyan99 May 18, 2023
3b36c1f
update changelog
xiangyan99 May 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sdk/identity/azure-identity/azure/identity/_credentials/silent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
from msal import PublicClientApplication

from azure.core.credentials import AccessToken
from azure.core.exceptions import ClientAuthenticationError

from .. import CredentialUnavailableError
from .._internal import resolve_tenant, validate_tenant_id
Expand Down Expand Up @@ -125,7 +124,7 @@ def _acquire_token_silent(self, *scopes: str, **kwargs: Any) -> AccessToken:
details = result.get("error_description") or result.get("error")
if details:
message += ": {}".format(details)
raise ClientAuthenticationError(message=message)
raise CredentialUnavailableError(message=message)

# cache doesn't contain a matching refresh (or access) token
raise CredentialUnavailableError(message=NO_TOKEN.format(self._auth_record.username))