Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Suppress stdin for subprocess-based creds #31534

Merged
merged 1 commit into from
Aug 28, 2023
Merged

[Identity] Suppress stdin for subprocess-based creds #31534

merged 1 commit into from
Aug 28, 2023

Conversation

pvaneck
Copy link
Member

@pvaneck pvaneck commented Aug 9, 2023

In some cases, the underyling executable being called hangs waiting for user input. When calling the executables we can ignore stdin.

Closes: #31493

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@pvaneck pvaneck force-pushed the identity-cli-stdin-fix branch from 348c2ac to dec6849 Compare August 9, 2023 20:06
@pvaneck pvaneck marked this pull request as ready for review August 9, 2023 20:08
@pvaneck pvaneck requested a review from xiangyan99 as a code owner August 9, 2023 20:08
@furnivall furnivall mentioned this pull request Aug 9, 2023
Closed
3 tasks
@pvaneck
[Identity] Suppress stdin for subprocess-based creds
9e1d5e0 
In some cases, the underyling executable being called
hangs waiting for user input. When calling the executables
we should just ignore stdin.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
@pvaneck pvaneck force-pushed the identity-cli-stdin-fix branch from dec6849 to 9e1d5e0 Compare August 28, 2023 18:59
@pvaneck pvaneck requested a review from a team as a code owner August 28, 2023 18:59
@xiangyan99
Copy link
Member

Do other languages also need this?

@pvaneck
Copy link
Member Author

pvaneck commented Aug 28, 2023

Do other languages also need this?

I am not certain on the stdin behavior in other languages. but I did bring this up to the group a few weeks back. I know an issue about this was already opened in the Java repo.

I can verify and open issues with other languages if the issue is recreatable.

@christothes
Copy link
Member

Do other languages also need this?

I am not certain on the stdin behavior in other languages. but I did bring this up to the group a few weeks back. I know an issue about this was already opened in the Java repo.

I can verify and open issues with other languages if the issue is recreatable.

We already have an issue for this in .NET also Azure/azure-sdk-for-net#32993

@pvaneck
Copy link
Member Author

pvaneck commented Aug 28, 2023

Checked JS/Go and they don't appear to hang for stdin when auto-upgrade is enabled for az. So I believe each affected language should have issues open regarding this.

@pvaneck pvaneck merged commit e7d72f5 into Azure:main Aug 28, 2023
@pvaneck pvaneck deleted the identity-cli-stdin-fix branch August 28, 2023 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
4 participants
@pvaneck @azure-sdk @xiangyan99 @christothes