Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnvironmentCredential to token cache table #32697

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add EnvironmentCredential to token cache table #32697

merged 1 commit into from
Oct 24, 2023

Conversation

scottaddie
Copy link
Member

Add a table row for EnvironmentCredential.

@scottaddie scottaddie requested review from pvaneck, xiangyan99 and a team as code owners October 24, 2023 20:07
@scottaddie scottaddie enabled auto-merge (squash) October 24, 2023 20:11
pvaneck
pvaneck approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch!

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@scottaddie scottaddie merged commit 7224538 into main Oct 24, 2023
25 checks passed
@scottaddie scottaddie deleted the scottaddie/token-cache branch October 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@pvaneck pvaneck pvaneck approved these changes

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner automatically assigned from Azure/azure-sdk-write-identity

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@scottaddie @azure-sdk @pvaneck @xiangyan99