Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR containerservices/resource-manager] [WIP] - Container Service - Add OpenShift support #3301

Conversation

AutorestCI
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Sep 7, 2018

Codecov Report

Merging #3301 into restapi_auto_containerservices/resource-manager will decrease coverage by 0.03%.
The diff coverage is 38.54%.

Impacted file tree graph

@@                                 Coverage Diff                                 @@
##           restapi_auto_containerservices/resource-manager    #3301      +/-   ##
===================================================================================
- Coverage                                            55.21%   55.17%   -0.04%     
===================================================================================
  Files                                                 9200     9218      +18     
  Lines                                               184958   185309     +351     
===================================================================================
+ Hits                                                102116   102247     +131     
- Misses                                               82842    83062     +220
Impacted Files Coverage Δ
...azure/mgmt/containerservice/operations/__init__.py 100% <100%> (ø) ⬆️
...ice/azure/mgmt/containerservice/models/__init__.py 100% <100%> (ø) ⬆️
.../mgmt/containerservice/container_service_client.py 100% <100%> (ø) ⬆️
...erservice/models/container_service_client_enums.py 100% <100%> (ø) ⬆️
...erations/open_shift_managed_clusters_operations.py 17.68% <17.68%> (ø)
...tainerservice/models/open_shift_managed_cluster.py 33.33% <33.33%> (ø)
...erservice/models/open_shift_managed_cluster_py3.py 33.33% <33.33%> (ø)
...s/open_shift_managed_cluster_agent_pool_profile.py 41.66% <41.66%> (ø)
...en_shift_managed_cluster_agent_pool_profile_py3.py 41.66% <41.66%> (ø)
...naged_cluster_service_aad_identity_provider_py3.py 44.44% <44.44%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71984de...646e328. Read the comment docs.

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Sep 8, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-containerservice

You can install the package azure-mgmt-containerservice of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3712#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_3712#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_3712
  • pip install -e ./azure-mgmt-containerservice

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_3712
  • pip wheel --no-deps ./azure-mgmt-containerservice

Direct download

Your files can be directly downloaded here:

@julienstroheker
Copy link

@lmazuel what's the next step to get this merged?

@lmazuel
Copy link
Member

lmazuel commented Oct 24, 2018

Will be regenerated part of the ServicePR

@lmazuel lmazuel closed this Oct 24, 2018
@lmazuel lmazuel deleted the restapi_auto_3712 branch October 24, 2018 22:35
@julienstroheker
Copy link

Thanks @lmazuel, how can I track it when this be done / merged to the master ?

@lmazuel
Copy link
Member

lmazuel commented Oct 26, 2018

Hey @julienstroheker
Your code is actually in the ServicePR ready to use:
#3378

The PR is actually tested by @zqingqing1 for the CLI, you might want to synchronize with her.
Thanks, let me know if you have more questions!

@julienstroheker
Copy link

Thanks @lmazuel
@zqingqing1 let me know how I can help here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants