Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OpenAI 1.0+ in Data Generator #33369

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Support OpenAI 1.0+ in Data Generator #33369

merged 1 commit into from
Dec 5, 2023

Conversation

gdyre
Copy link
Contributor

@gdyre gdyre commented Dec 1, 2023 •
edited
Loading

  • Add OpenAI version 1.0 support

  • Fix openai client

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@gdyre @georgedyre
Georgedyre/openai upgrade (#2)
954c7e4 
* Keep original question for first in conversation

* Add OpenAI version 1.0 support

* Fix openai client

---------

Co-authored-by: George Dyre <georgedyre@microsoft.com>
@github-actions github-actions bot added AI Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Thank you for your contribution @gdyre! We will review the pull request and get back to you soon.

@luigiw luigiw merged commit cb678ce into Azure:main Dec 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigiw luigiw luigiw approved these changes

@gjwoods gjwoods gjwoods approved these changes

@needuv needuv Awaiting requested review from needuv needuv is a code owner

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit singankit is a code owner

Assignees
No one assigned
Labels
AI Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gdyre @luigiw @gjwoods