Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all developer tools for user-based auth in tests #34927

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Mar 26, 2024

Description

@mrm9084 pointed out that it would be great to support VS Code authentication in our tests, and there's no reason not to. This PR adds support for VS Code and Azure Developer CLI authentication, to round out support for all developer tools enabled through azure-identity.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mccoyp mccoyp added test-enhancement test-proxy Anything relating to test-proxy requests or issues. labels Mar 26, 2024
@mccoyp mccoyp requested a review from scbedd as a code owner March 26, 2024 00:46
@mccoyp mccoyp merged commit ec78666 into Azure:main Mar 26, 2024
23 checks passed
@mccoyp mccoyp deleted the tests-dev-creds branch March 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-enhancement test-proxy Anything relating to test-proxy requests or issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants