Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] [Blob] Fixed next pylint errors in blob storage #34945

Merged
merged 1 commit into from
Mar 27, 2024
Merged

[Storage] [Blob] Fixed next pylint errors in blob storage #34945

merged 1 commit into from
Mar 27, 2024

Conversation

weirongw23-msft
Copy link
Member

Description

Fixed all next pylint errors in blob storage except docstring-keyword-should-match-keyword-only. This is the fix for issue #32630 .

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Mar 26, 2024
jalauzon-msft
jalauzon-msft approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on your first PR!

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob

vincenttran-msft
vincenttran-msft requested changes Mar 26, 2024
View reviewed changes
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one nit but otherwise 💯

vincenttran-msft
vincenttran-msft approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@weirongw23-msft weirongw23-msft merged commit 773cb29 into Azure:main Mar 27, 2024
20 checks passed
@weirongw23-msft weirongw23-msft deleted the pylint/azure-storage-blob branch March 27, 2024 00:38
@weirongw23-msft weirongw23-msft linked an issue Apr 17, 2024 that may be closed by this pull request
azure-storage-blob needs linting updates for pylint version 3.0.3 #32630
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenttran-msft vincenttran-msft vincenttran-msft approved these changes

@jalauzon-msft jalauzon-msft jalauzon-msft approved these changes

@annatisch annatisch Awaiting requested review from annatisch annatisch is a code owner

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

azure-storage-blob needs linting updates for pylint version 3.0.3
4 participants
@weirongw23-msft @azure-sdk @jalauzon-msft @vincenttran-msft