Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] fix sphinx #35016

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Mar 29, 2024

fixes #34639

Did not add strict_sphinx=True to pyproject.toml as per Krista's recommendation, since we're hitting this error that's originating from cpython docs:
azure-sdk-for-python/sdk/servicebus/azure-servicebus/.tox/strict-sphinx/lib/python3.11/site-packages/azure/servicebus/_common/constants.py:docstring of azure.servicebus.ServiceBusMessageState.from_bytes:9: WARNING: Inline interpreted text or phrase reference start-string without end-string.

Otherwise, this will break our build. Fixed all other sphinx errors.

@swathipil swathipil marked this pull request as ready for review March 29, 2024 19:54
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@swathipil swathipil merged commit 00ff2b8 into Azure:main Mar 29, 2024
22 checks passed
@swathipil swathipil deleted the swathipil/sb/sphinx-fix branch March 29, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-servicebus needs docstring updates for sphinx
3 participants