[Storage] Updated credentials formatting in docstrings and disabled docstring-keyword-should-match-keyword-only
#35296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-blob-changefeed
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
|
API change check API changes are not detected in this pull request. |
vincenttran-msft
approved these changes
Apr 23, 2024
This was
linked to
issues
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will enable all five packages to run properly in CI. In particular, we provided linting updates for
pylintversion 3.0.3. The build is passing locally after resolving all errors and running the appropriatenext-pylinttoxcommands at the library package-level. Here are the links to the Github Issues:The updates here include:
docstring-keyword-should-match-keyword-onlyin each file across every package that generated an error in the originaltoxrun. Also reformatted the files to ensure the# pylint: disable=...have a newline between the disable comment and import statements, as well as consolidated file-wide pylint disable comments.credentialparameter is formatted consistently as discussed.Note that
docstring-keyword-should-match-keyword-onlyis a temporary fix, because moving all existing keywords to named keywords and fully documenting them will take significant engineering effort. We're currently working on resolving that.