[Identity] Add AzurePipelinesCredential #35397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvaneck
force-pushed
the
azure-pipelines-credential
branch
from
6a499db to
8af09b5
Compare
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
pvaneck
force-pushed
the
azure-pipelines-credential
branch
2 times, most recently
from
7e177ff to
0125731
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
azure-pipelines-credential
branch
from
0125731 to
8d6c57d
Compare
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
pvaneck
force-pushed
the
azure-pipelines-credential
branch
from
c180a1b to
9d5e39c
Compare
pvaneck
requested review from
joshfree,
billwert,
ahsonkhan,
KarishmaGhiya,
scottaddie and
schaabs
xiangyan99
reviewed
May 9, 2024
sdk/identity/azure-identity/azure/identity/_credentials/azure_pipelines.py
Outdated
Show resolved
Hide resolved
scottaddie
reviewed
May 9, 2024
- Also moved credential in README. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
|
Note: The live tests for this credential have passed, and the failures (affecting everyone) are from expired keys/secrets. Those will need to be investigated/rotated. |
scottaddie
reviewed
May 10, 2024
sdk/identity/azure-identity/azure/identity/_credentials/azure_pipelines.py
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/azure/identity/aio/_credentials/azure_pipelines.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com>
xiangyan99
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new credential, AzurePipelinesCredential.
Closes: #32143