Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

address API review comments #36058

Merged
merged 20 commits into from
Jun 14, 2024
Merged

address API review comments #36058

merged 20 commits into from
Jun 14, 2024

Conversation

Adarsh-Ramanathan
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-ml

@luigiw luigiw enabled auto-merge (squash) June 14, 2024 18:20
@luigiw luigiw merged commit c6383aa into Azure:main Jun 14, 2024
17 checks passed
MilesHolland added a commit to MilesHolland/azure-sdk-for-python that referenced this pull request Jun 14, 2024
@Adarsh-Ramanathan @MilesHolland
address API review comments (Azure#36058)
6c273d9 
* address comments

* reintroduce index

* retrigger checks

* lint fixes

* retrigger checks

* remove experimental tag

* investigating build issues

* revert experimental changes

* make dataclass kw-only

* commit docstring

* make index config experimental

* remove unused experimental import

* correct build_index docstring/typehint

* kevin's suggestion - remove redundant experimental warning

* make all init args keyword only

* re-order annotations

* run black

---------

Co-authored-by: Ubuntu <azureuser@adramadev0.1u2n51k150xetd4yrig4jsoeod.xx.internal.cloudapp.net>
Co-authored-by: Miles Holland <milesholland@microsoft.com>
MilesHolland added a commit that referenced this pull request Jun 14, 2024
@MilesHolland @Adarsh-Ramanathan
address API review comments (#36058) (#36092)
6e982e5 
* address comments

* reintroduce index

* retrigger checks

* lint fixes

* retrigger checks

* remove experimental tag

* investigating build issues

* revert experimental changes

* make dataclass kw-only

* commit docstring

* make index config experimental

* remove unused experimental import

* correct build_index docstring/typehint

* kevin's suggestion - remove redundant experimental warning

* make all init args keyword only

* re-order annotations

* run black

---------

Co-authored-by: Adarsh-Ramanathan <68247982+Adarsh-Ramanathan@users.noreply.github.com>
Co-authored-by: Ubuntu <azureuser@adramadev0.1u2n51k150xetd4yrig4jsoeod.xx.internal.cloudapp.net>
MilesHolland added a commit that referenced this pull request Jun 17, 2024
@MilesHolland @xiangyan99
@jeremydvoss @kristapratico @wenjie1070116 @matferrari-msft @jiewe @azure-sdk @swathipil @lzchen @weirongw23-msft @benbp @danieljurek @dargilco @ChenxiJiang333 @JimSuplizio @pvaneck @runhli @debuggerXi @l0lawrence @vincenttran-msft @lmazuel @mccoyp @YalinLi0312 @emepetres @msyyc @weshaggard @catalinaperalta @cperaltah @jeremymeng @drielenr @Adarsh-Ramanathan @nagkumar91
1.17.0 core main merge (#36117)
eb5dade 
* Update changelog (#35929)

* update changelog for azure-core

* update identity version

* Autoinstrumentation rework (#35890)

* Configure exporters and sampler directly in configurator

* lint

* switch to majority entra auth for tests (#35581)

* switch to majority defaultazurecredential auth for tests

* test run

* don't use optional for test run

* try

* fix

* remove

* fix import

* try

* try different connection

* update subconfig

* byod uses system_assigned_managed_identity

* remove azure key where not using

* typo

* add azure-sdk-tests values to subconfig

* explicitly state model for byod tests

* add back optional env and remove skips

* push missed files

* move subconfig to service directory for now

* fix path after moving subconfig

* simplify

* add a new parameter allow_roleassignment_on_rg to allow/disallow role assignment on resource group level (#35939)

* Python SDK System Datastore Auth AML

* Python SDK System Datastore Auth AML

* Python SDK System Datastore Auth AML

* SDK Updates

* Add allow_roleassignment_on_rg for customer to determine whether to allow workspace role assignment on RG level

Add allow_roleassignment_on_rg for customer to determine whether to allow workspace role assignment on resource group level

* update the type of allow_roleassignment_on_rg

* update allow_roleassignment_on_rg to be boolean

* address lint check errors

* run black to fix the formatting issue

---------

Co-authored-by: Matthew Ferrari <matferrari@microsoft.com>
Co-authored-by: jiewe <127981966+jiewe@users.noreply.github.com>

* Increment package version after release of azure-core (#35950)

* [Event Hubs] Update URI used for consumer auth to include consumer group (#35626)

* add consumer group to uri used for consumer auth

* changelog

* add consumergroup to auth uri for consumer ops only, not mgmt ops

* lint

* fix sample

* Allow configuration of metric Views in distro (#35932)

* views

* test

* lint

* Update _configure.py

* [EventHub] Update README for enable logging section (#35955)

* [EventHub] Update README for enable logging section

Adding an enable logging section like in [servicebus](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/servicebus/azure-servicebus/README.md#logging) as it's a common enough scenario to have on the readme.

* typo

* add in krista's suggestion

* [Storage] [STG 94] Merge STG 94 into `main` branch (#35888)

* Sync eng/common directory with azure-sdk-tools for PR 8377 (#35915)

* Plumb env vars through deploy test resources

* Update eng/common/TestResources/deploy-test-resources.yml

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* Update eng/common/TestResources/deploy-test-resources.yml

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

---------

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* Distro release 1.6.0 (#35935)

* Distro release 1.6.0

* Fix exporter entry point names

* Tests

* Python client for Model-as-a-Service (MaaS) / Model-as-a-Platform (MaaP) endpoints (#34937)

* [AutoRelease] t2-datafactory-2024-06-03-75602(can only be merged by SDK owner) (#35878)

* code and test

* Update assets.json

* Update CHANGELOG.md

---------

Co-authored-by: azure-sdk <PythonSdkPipelines>
Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com>
Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>

* Use DOTNET_ROLL_FORWARD: 'Major' for test-proxy (#35956)

Co-authored-by: Daniel Jurek <djurek@microsoft.com>

* Pin pester version to 5.5.0 (#35967)

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* Some minor updates to package & samples README.md files (#35971)

* add aoai assistants streaming/v2 tests (#35443)

* add aoai assistants streaming tests

* update to 2024-05-01-preview and add assistants v2 tests

* fix some tests

* fix

* try to fix flaky assistants tests

* more updates to fix flakiness

* fix more flakiness and only run openai on weekly

* [Identity] Allow use of client assertion in OBO cred (#35812)

The new kwarg `client_assertion_func` was added to allow passing in client assertion
callbacks to OBO credential.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* [Identity] Disable live service principal tests (#35958)

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* set storage account access to identity-based for feature store creation (#35941)

* set storage account access to identity-based for feature store creation

* revert

* add workspace default storage role assignment

* Change Workspace related PR reviewer (#35921)

* Add permission

* Cleanup permission

---------

Co-authored-by: Xi Jin <jinxi@microsoft.com>

* [EG] GA Namespaces (#35831)

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* link to samples

* remove comment

* remove uneeded test

* [EGv2] doc updates (#30483)

* doc updates

* doc update

* doc

* [EGv2] Eg typing/formatting (#30492)

* mypy pylint

* update samples

* remove version disclaimer

* Beta LiveTests (#30728)

* add bicep file for tests

* update output

* update test

* secret sanitization

* refactor failing test

* update conftest

* update assets and sanitizers

* update preparer loc

* update conftest

* conftest

* update conftest

* remove variables for now

* update assets

* update tests

* try to update regex

* update recordings

* update conftest

* update preparer

* update test

* update exception test

* update tests

* update asset

* update conftest

* pr comments

* default needs to be eastus

* import

* [EGv2] generate with newer emitter (#31962)

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* generate with newer emitter

* update tsp

* regen

* update tests

* update tspconfig

* cspell

* version

* update serialization

* update assets

* update mypy

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* [EGv2] Binary mode  (#32922)

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* Beta LiveTests (#30728)

* add bicep file for tests

* update output

* update test

* secret sanitization

* refactor failing test

* update conftest

* update assets and sanitizers

* update preparer loc

* update conftest

* conftest

* update conftest

* remove variables for now

* update assets

* update tests

* try to update regex

* update recordings

* update conftest

* update preparer

* update test

* update exception test

* update tests

* update asset

* update conftest

* pr comments

* default needs to be eastus

* import

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* fix merge

* dont go to generated before binary

* update patch

* update patches

* eventgrid client patch

* changes

* add

* update test

* update tyoe checking

* pass through binary_mode for now --

* update patch aio

* add async func

* update

* sys

* update kwargs

* add Todo and start adding more tests

* update

* differentiate between binary and not

* update binary

* no base64 in binary mode

* binary

* try JSONEncoder on everything if not str/bytes

* update test

* update test

* update changes

* whitespace

* space

* remove commented

* str serialize extensions?

* xml test

* encode extensions as object

* update test

* update extension serialization for  deserialize

* move flag to operation level

* extra comma

* dont raise httpresponse

* update patch

* accept dict cloud events

* spacing

* remove content_type check

* add live test

* remove live test mark

* update

* use env vars

* update test

* only run live test

* comment

* typo

* error incorrect

* start comments

* update test

* add sample

* update tests

* update docstrings to add clarity

* update err message

* remove generated cloud event

* update sample

* update

* update samples to include dict

* update patch

* spacing

* add comments

* formatting

* update doc

* update tests

* update tests

* tests

* skip tests for now

* typo

* add dict binary mode

* update docstring

* update patch to allow throw error

* first pass at comments

* update patch eror

* nit

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* [EventGrid] Ignite Release generate with new typespec (#32652)

* Beta LiveTests (#30728)

* add bicep file for tests

* update output

* update test

* secret sanitization

* refactor failing test

* update conftest

* update assets and sanitizers

* update preparer loc

* update conftest

* conftest

* update conftest

* remove variables for now

* update assets

* update tests

* try to update regex

* update recordings

* update conftest

* update preparer

* update test

* update exception test

* update tests

* update asset

* update conftest

* pr comments

* default needs to be eastus

* import

* [EGv2] Binary mode  (#32922)

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* Beta LiveTests (#30728)

* add bicep file for tests

* update output

* update test

* secret sanitization

* refactor failing test

* update conftest

* update assets and sanitizers

* update preparer loc

* update conftest

* conftest

* update conftest

* remove variables for now

* update assets

* update tests

* try to update regex

* update recordings

* update conftest

* update preparer

* update test

* update exception test

* update tests

* update asset

* update conftest

* pr comments

* default needs to be eastus

* import

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* fix merge

* dont go to generated before binary

* update patch

* update patches

* eventgrid client patch

* changes

* add

* update test

* update tyoe checking

* pass through binary_mode for now --

* update patch aio

* add async func

* update

* sys

* update kwargs

* add Todo and start adding more tests

* update

* differentiate between binary and not

* update binary

* no base64 in binary mode

* binary

* try JSONEncoder on everything if not str/bytes

* update test

* update test

* update changes

* whitespace

* space

* remove commented

* str serialize extensions?

* xml test

* encode extensions as object

* update test

* update extension serialization for  deserialize

* move flag to operation level

* extra comma

* dont raise httpresponse

* update patch

* accept dict cloud events

* spacing

* remove content_type check

* add live test

* remove live test mark

* update

* use env vars

* update test

* only run live test

* comment

* typo

* error incorrect

* start comments

* update test

* add sample

* update tests

* update docstrings to add clarity

* update err message

* remove generated cloud event

* update sample

* update

* update samples to include dict

* update patch

* spacing

* add comments

* formatting

* update doc

* update tests

* update tests

* tests

* skip tests for now

* typo

* add dict binary mode

* update docstring

* update patch to allow throw error

* first pass at comments

* update patch eror

* nit

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* [EGv2] Build Release (#30325)

* move old sdk under legacy

* gen typespec code

* naming changes from archboard

* samples

* update patch naming

* update imports with new gen

* update samples

* update client naming on aio

* update receive op

* update async to close client

* update receive()

* update gen code

* moving around samples

* updating samples

* update samples

* update patch and samples

* patch internalmodels

* spacing

* updating model patch

* update patch models

* add both models back

* update docstring

* update docs

* updating patch for receive

* old EG models

* add reject samples

* patch

* update format

* update patch

* eventgrid_client exceptions

* update test imports

* update total sample

* receive patch fix

* add in more tests

* update test file

* remove locktoken model

* remove LockToken in patch

* remove event delivery delay

* eg client exceptions

* .8.5 generation, and deliveryCount

* rename sample

* update version for beta

* changelog

* updating for gen

* regen

* generate via commit

* publish result

* fix docstring

* publish docstring

* return type

* publish result

* return publish result -- is none

* format

* update Publish result model

* deliverycount patch

* update from main

* add copyright

* added to readme

* remove from readme

* force publish_result response

* update patch tp unindent

* cspell

* update mypy.ini

* import order

* mark livetest

* update operations init

* rename async

* mypy

* ignore mypy

* pylint

* pylint

* ignore pylint for now to avoid gen code errors

* ignore samples until ARM setup

* update patches

* remove publish result

* remove PublishResult

* remove publishresult

* comma

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update publishResult

* change to .value

* gen code " to '

* remove comment

* ran black

* update changelog

* update sample readme

* gen code without query name

* gen code

* update tsp commit

* remove publishresult

* readme disclaimer

* update changelog

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* Beta LiveTests (#30728)

* add bicep file for tests

* update output

* update test

* secret sanitization

* refactor failing test

* update conftest

* update assets and sanitizers

* update preparer loc

* update conftest

* conftest

* update conftest

* remove variables for now

* update assets

* update tests

* try to update regex

* update recordings

* update conftest

* update preparer

* update test

* update exception test

* update tests

* update asset

* update conftest

* pr comments

* default needs to be eastus

* import

* regen

* new api version

* samples for new features

* update test-resources.json

* update operation samples

* add samples

* more sample

* update tests

* add mros

* gen

* fix changelog

* update tests

* update preparer

* point at canary until release

* update test deployment area

* update

* add

* try this tests

* update samples

* livetest mark

* update tests

* eastus working?

* regen - removed azure refs in gen code

* update comments

* add other sample

* update

* remove stream - no response

* update version and date for release

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* update for release

* add changelog

* [EG] Regenerate beta (#35014)

* update generation

* version

* skip

* [EG] Beta One Client (#34973)

* [EG] dont hardcode api_version on request (#34965)

* dont hardcode api_version on request

* pylint fixes

* revert

* api version

* Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/aio/_publisher_client_async.py

* Update sdk/eventgrid/azure-eventgrid/azure/eventgrid/aio/_publisher_client_async.py

* add sync side patches

* aio patches

* update readme samples

* all samples use EGClient

* update readme samples

* fix imports

* import issue

* missing pathc

* allow sas cred

* typo

* updates

* sas

* client

* self serialize cloudevent

* add bakc in

* updates

* update ptach

* update

* update exception logic

* async w client

* aio [atch

* typo

* import

* update links

* tests

* raise error

* content type

* use more fake url

* remove content type

* mypy

* update apiversion

* content type

* unitttests

* update auth

* updates

* add level

* update readme

* update

* binary mode

* args, kwargs

* remove auth

* add sample comments

* testing

* move around readme

* content type

* update tests

* docstring

* cncf event

* add more tests

* update doc

* update inits to prevent typing errors

* ran blakc

* fix pylint patch

* changes

* add all kwargs

* indent

* reviews

* nit

* name changes

* options

* options/result rename

* Revert "options"

This reverts commit fe0623a.

* Revert "options/result rename"

This reverts commit 6d37422.

* fix tests

* remove or None

* remove EGPubClient

* remove options naming

* Revert "remove EGPubClient"

This reverts commit bf94364.

* typeerror

* update readme

* readme nit

* readme updates

* add send operation samples

* add datacontenttpye

* typo

* make Options bag models kwargs

* remove models

* import

* exception

* update changelog

* shorten operation names

* nit

* [EG] Docstring/update changelog (#35108)

* nits

* Revert "shorten operation names"

This reverts commit cd37161.

* remove broken link

* edit

* update readme (#35147)

* beta version

* [EG] Readme updates (#35152)

* simplify readme

* update all links to feature branch

* spacing

* try

* type error to value error (#35164)

* [EG] rename release_delay (#35172)

* rename

* valueError

* update version

* version

* [EG] regenerate to fix gen code bug (#35327)

* regenerate to fix gen code bug

* update serialization code

* update

* pylint

* update faulty tests

* use _patch

* use _patch

* add test type

* fix test + add version

* ver (#35345)

* typo (#35348)

* typo (#35351)

* typo

* update

* [EG] Archboard Feedback (#35738)

* regen

* remove all samples/tests before fixing

* move all topic/sub to client level

* update

* updates

* update samples

* add other publisher tests

* missing

* content type

* consumerclient

* upload consumer tests

* updates

* update

* changes

* updates

* rename

* update

* patch

* test update

* update tests

* fix

* updates snippets

* update readme

* try updating api_version

* typo

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* typo2

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* renames/docs from comments

* regen

* update patch

* remove import

* caps

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* [EG] Update tests (#35833)

* [EG] Update tests (#35752)

* test

* typo

* update recordings

* mark live

* kwarg fix

* updates

* revert

* kwargs

* continue skip

* rename

* naming

* remove _async

* nit

* typo

* remove async

* remove print (#35855)

* [EG] update pyproject and samples (#35857)

* update

* pylint changes

* update readme + version

* regen

* Update scripts/devops_tasks/test_run_samples.py

* readme

* typo

* update

* add tests

* updates tests 2

* Revert "updates tests 2"

This reverts commit 1b85d9e.

* try

* typeError

* missing await

* unused import

---------

Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>

* Increment package version after release of azure-monitor-opentelemetry (#35969)

* update test for new structure of custom blocklist (#36001)

* Update github-event-processor to 1.0.0-dev.20240610.2 (#36000)

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* [Identity] Minor doc updates (#35974)

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* allow for futher embedded snippets (#36004)

* allow for futher embedded snippets

* Update tools/azure-sdk-tools/ci_tools/snippet_update/python_snippet_updater.py

* [Monitor Query + Ingestions] Update changelogs (#35942)

Preparation for release.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* [Identity] Managed identity bug fix (#36010)

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Added release dates (#36006)

* Remove MayankKumar91 (#35911)

* Increment package version after release of azure-identity (#36015)

* Always run analyze weekly (#35968)

* try to make analyze weekly run unconditionally

* try display name

* remove debugging

* move samples (#35966)

* sample

* readme updates

* links

* delete duplicates

* doc updates

* plural

* [Key Vault] Change location for weekly China cloud tests (#36018)

* Fix Sphinx on azure-storage-blob-changefeed (#35975)

* update release date (#36028)

* azure-mgmt-core shouldn't use mgmt docs build (#35936)

* Identity credential unavailable error non json imds (#36016)

* Raise CredentialUnavailableError if the response is not json

* update changelog

* update

* update

* Update sdk/identity/azure-identity/CHANGELOG.md

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>

---------

Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update azure-ai-inference client library to support sending images as part of chat completions (#36022)

* Export InputTypes from constants (#35848)

* Export InputTypes from constants

InputTypes should exported as with AssetTypes, so there is no need to use literals types when using literal Inputs.

* Added InputTypes modification to CHANGELOG.md

* [EG] Eventgrid Release (#36030)

* update changelog

* add

* regen - black edits

* update

* update sphinx

* typo

* sample bump

* Fix Sphinx on azure-storage-blob (#36014)

* [Identity] Update AzurePipelinesCredential (#35858)

- OIDC API version updated to 7.1.
- Use the `SYSTEM_OIDCREQUESTURI` envvar for the base OIDC url
- Added a new required parameter: "system_access_token".
- Bump version to 1.17.0.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* upgrade autorest.python to `6.13.19` (#36024)

* Increment version for monitor releases (#36036)

* Increment package version after release of azure-monitor-ingestion

* Increment package version after release of azure-monitor-query

* compatible with new date format (#36049)

* [AutoRelease] t2-cdn-2024-06-12-45722(can only be merged by SDK owner) (#36050)

* code and test

* Update CHANGELOG.md

* Update _version.py

---------

Co-authored-by: azure-sdk <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [EG] link + patch update (#36045)

* update patch

* update date

* update link

* httpresponseerror

* update

* pylint

* pylint

* remove wrap

* async with (#36060)

* Incremental (#36040)

* typo (#36062)

* Fix prepare-pipelines line wrapping (#36061)

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>

* [bct] Initial refactoring breaking changes tool (#36005)

* wip - support non-breaking changes

* refactor to support changelog functionality

* print changelog or breaking changes

* support changelog flag

* changelog fix

* ignore unknown args

* change enum

* undo positional param change

* cleanup

* update tests

* add changelog test

---------

Co-authored-by: Catalina Peralta <caperal@microsoft.com>

* Update swagger_to_sdk_config_dpg.json (#36068)

* Increment package version after release of azure-eventgrid (#36063)

* Sync eng/common directory with azure-sdk-tools for PR 8388 (#35970)

* Removal of the devops release PAT

* Don't pass in the access token, just use the AzureCLI task and do everything in the scripts

* Updates for feedback

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* report number of breaking changes (#36067)

Co-authored-by: Catalina Peralta <caperal@microsoft.com>

* update codeowner (#36074)

* update codeowner

* update

* update strict-sphinx to v7 (#36075)

* Update spelling dependencies (#36084)

This is the result of `npm audit fix` to address vulnerability in older versions
of `braces`.

Co-authored-by: Jeremy Meng <yumeng@microsoft.com>

* [DevCenter] Update release date (#36083)

* Update release date

* Add codeowners to dev center

* Update to github alias

* Fix label name

* [Identity] Add TSG section for AzurePipelinesCredential (#36048)

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Support sending image data as part of a user message, using a new ImageUrl.load() method. Add sample and test. (#36042)

* update (#36051)

* Increment package version after release of azure-ai-inference (#36091)

* address API review comments (#36058)

* address comments

* reintroduce index

* retrigger checks

* lint fixes

* retrigger checks

* remove experimental tag

* investigating build issues

* revert experimental changes

* make dataclass kw-only

* commit docstring

* make index config experimental

* remove unused experimental import

* correct build_index docstring/typehint

* kevin's suggestion - remove redundant experimental warning

* make all init args keyword only

* re-order annotations

* run black

---------

Co-authored-by: Ubuntu <azureuser@adramadev0.1u2n51k150xetd4yrig4jsoeod.xx.internal.cloudapp.net>
Co-authored-by: Miles Holland <milesholland@microsoft.com>

* Update CodeownersLinter version to 1.0.0-dev.20240614.4 (#36093)

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* [AutoRelease] t2-mobilenetwork-2024-06-05-65505(can only be merged by SDK owner) (#35916)

* code and test

* Update assets.json

---------

Co-authored-by: azure-sdk <PythonSdkPipelines>
Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com>

* [AutoRelease] t2-storagemover-2024-06-11-87054(can only be merged by SDK owner) (#36020)

* code and test

* Update CHANGELOG.md

---------

Co-authored-by: azure-sdk <PythonSdkPipelines>
Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>

* code and test (#35959)

Co-authored-by: azure-sdk <PythonSdkPipelines>

* [AutoRelease] t2-web-2024-06-07-57417(can only be merged by SDK owner) (#35963)

* code and test

* Update CHANGELOG.md

---------

Co-authored-by: azure-sdk <PythonSdkPipelines>
Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>

* Update breaking_changes_allowlist.py (#36104)

* appconfig mi test (#35842)

* update yml

* update

* Bugfix: None was being appended to output path for batch-endpoint invoke command and wasn't picking up the override output path (#36089)

* Reverting models to make sure calls to the simulator work

* quotes

* Spellcheck fixes

* ignore the models for doc generation

* Fixed the quotes on f strings

* pylint skip file

* Support for summarization

* Adding a limit of 2 conversation turns for all but conversation simulators

* exclude synthetic from mypy

* Another lint fix

* Skip the file causing linting issues

* Bugfix on output to json_qa_lines and empty response from callbacks

* Skip pylint

* Add if/else on message to eval json util

* adding max_simulation_results for sync call

* Bugfix: None was being added to the end of the output path

* Sync eng/common directory with azure-sdk-tools for PR 8457 (#36113)

* Update macos image from 11 to latest

* unpin pester now that 5.6.0 is on the agent

---------

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>

---------

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: Xiang Yan <xiangsjtu@gmail.com>
Co-authored-by: Jeremy Voss <jerevoss@gmail.com>
Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Jie Wen <wenjie1070116@gmail.com>
Co-authored-by: Matthew Ferrari <matferrari@microsoft.com>
Co-authored-by: jiewe <127981966+jiewe@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com>
Co-authored-by: Leighton Chen <lechen@microsoft.com>
Co-authored-by: Peter Wu <162184229+weirongw23-msft@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Darren Cohen <39422044+dargilco@users.noreply.github.com>
Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com>
Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com>
Co-authored-by: runhli <87873226+runhli@users.noreply.github.com>
Co-authored-by: XI JIN <giovannijin1990@gmail.com>
Co-authored-by: Xi Jin <jinxi@microsoft.com>
Co-authored-by: Libba Lawrence <llawrence@microsoft.com>
Co-authored-by: vincenttran-msft <101599632+vincenttran-msft@users.noreply.github.com>
Co-authored-by: Laurent Mazuel <laurent.mazuel@gmail.com>
Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>
Co-authored-by: Yalin Li <yall@microsoft.com>
Co-authored-by: Javi Carnero <javier@carnero.net>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: catalinaperalta <catalinaperaltah@hotmail.com>
Co-authored-by: Catalina Peralta <caperal@microsoft.com>
Co-authored-by: Jeremy Meng <yumeng@microsoft.com>
Co-authored-by: Driele Neves Ribeiro <drielene@microsoft.com>
Co-authored-by: Adarsh-Ramanathan <68247982+Adarsh-Ramanathan@users.noreply.github.com>
Co-authored-by: Ubuntu <azureuser@adramadev0.1u2n51k150xetd4yrig4jsoeod.xx.internal.cloudapp.net>
Co-authored-by: Nagkumar Arkalgud <nagkumar91@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilesHolland MilesHolland MilesHolland approved these changes

@jingyizhu99 jingyizhu99 jingyizhu99 approved these changes

@kdestin kdestin kdestin left review comments

@paulshealy1 paulshealy1 Awaiting requested review from paulshealy1 paulshealy1 is a code owner

@singankit singankit Awaiting requested review from singankit

@diondrapeck diondrapeck Awaiting requested review from diondrapeck

@luigiw luigiw Awaiting requested review from luigiw

@needuv needuv Awaiting requested review from needuv

@ninghu ninghu Awaiting requested review from ninghu

@YusakuNo1 YusakuNo1 Awaiting requested review from YusakuNo1

Assignees
No one assigned
Labels
Machine Learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Adarsh-Ramanathan @azure-sdk @jingyizhu99 @kdestin @MilesHolland @luigiw