Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable venv for testing #36465

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Re-enable venv for testing #36465

merged 10 commits into from
Jul 12, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jul 12, 2024

As mentioned in #36454 ,I would re-enable venv for test runs when I had a more elegant way of doing it.

This PR is that more elegant way, or at the very least the much less ugly version.

Contributes to resolving #35204

@scbedd scbedd self-assigned this Jul 12, 2024
@scbedd
Copy link
Member Author

scbedd commented Jul 12, 2024

/azp run python - core

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scbedd
Copy link
Member Author

scbedd commented Jul 12, 2024

Negative check coming back error as expected, adjusted methodology of invoking tests properly fails when a test fails 👍

@scbedd scbedd merged commit 5590b15 into main Jul 12, 2024
34 checks passed
@scbedd scbedd deleted the fix-setuptools-extern branch July 12, 2024 23:02
@scbedd scbedd restored the fix-setuptools-extern branch July 12, 2024 23:27
v-vdharmaraj pushed a commit that referenced this pull request Jul 15, 2024
* use a venv for test steps
v-vdharmaraj pushed a commit that referenced this pull request Jul 15, 2024
* use a venv for test steps
@scbedd scbedd deleted the fix-setuptools-extern branch August 8, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants