Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drive awareness of credential chains doc #37549

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Drive awareness of credential chains doc #37549

merged 4 commits into from
Sep 24, 2024

Conversation

scottaddie
Copy link
Member

@scottaddie scottaddie commented Sep 24, 2024 •
edited
Loading

Summary of changes

  • Replace much of the detail in the README's DefaultAzureCredential and ChainedTokenCredential sections with links to the new credential chains doc.
  • Update API docs to point to ChainedTokenCredential and DefaultAzureCredential sections in the credential chains doc.

@scottaddie scottaddie requested review from pvaneck, xiangyan99 and a team as code owners September 24, 2024 14:06
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@scottaddie scottaddie marked this pull request as draft September 24, 2024 18:05
@scottaddie scottaddie marked this pull request as ready for review September 24, 2024 18:17
@scottaddie scottaddie requested a review from pvaneck September 24, 2024 21:43
pvaneck
pvaneck approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@pvaneck pvaneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @scottaddie!

@scottaddie scottaddie merged commit 0fc263f into main Sep 24, 2024
22 checks passed
@scottaddie scottaddie deleted the scottaddie/identity-readme branch September 24, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaneck pvaneck pvaneck approved these changes

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner automatically assigned from Azure/azure-sdk-write-identity

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan ahsonkhan is a code owner automatically assigned from Azure/azure-sdk-write-identity

@KarishmaGhiya KarishmaGhiya Awaiting requested review from KarishmaGhiya KarishmaGhiya is a code owner automatically assigned from Azure/azure-sdk-write-identity

@chlowell chlowell Awaiting requested review from chlowell chlowell is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees
No one assigned
Labels
Azure.Identity
Projects
Azure Identity SDK Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottaddie @azure-sdk @pvaneck