[bct] add base class properties in code report #37656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @msyyc getting back to this PR...could you see if this change breaks anything in the mgmt plane checks? I think it should be fine and fixes the issue you were having with duplicate reports but let me know if something isnt working as expected. |
…into bc/fix-base-class-reporting
I test the PR locally and it indeed fixes the target issue. Thanks! |
msyyc
approved these changes
Oct 17, 2024
…e/azure-sdk-for-python into bc/fix-base-class-reporting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37513 Make sure we're checking base class properties as well, seems there were some corner cases where we werent checking base class properties