-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Remove Telemetry from main (#37783)" #37812
Merged
mrm9084
merged 1 commit into
feature/azure-appconfiguration-provider/variants
from
revert-37783-RevertTelemetryMain
Oct 9, 2024
Merged
Revert "Remove Telemetry from main (#37783)" #37812
mrm9084
merged 1 commit into
feature/azure-appconfiguration-provider/variants
from
revert-37783-RevertTelemetryMain
Oct 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a65dfb2.
mrm9084
merged commit Oct 9, 2024
a107c2b
into
feature/azure-appconfiguration-provider/variants
6 checks passed
mrm9084
added a commit
that referenced
this pull request
Nov 18, 2024
* Revert "Remove Telemetry from main (#37783)" (#37812) This reverts commit a65dfb2. * Allocation Id (#37840) * Adding Telemetry * Telemetry Support * fixing formatting * Update _azureappconfigurationprovider.py * Update _azureappconfigurationproviderasync.py * formatting * changing doc style due to pylint-next * fixing kwargs docs * Formatting * Review comments * Changed label checking. * black format changes * pylint * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> * added space checks * Update conftest.py * moved telemetry to client wrapper * fixing format * updating after merge * fixing black issue * removing unused imports * AllocationId * Update CODEOWNERS * Update CODEOWNERS * fixing issues * Update _client_manager_base.py * Fixing configuration value empty in calc * fixing pylint * Update _constants.py * review comments * fixing allocation check * format fix --------- Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> * Python Provider 2.0.0b2 Changelog update (#37860) * Update CHANGELOG.md * Update CHANGELOG.md * Increment package version after release of azure-appconfiguration-provider (#37877) * Update _client_manager_base.py (#38019) * App Config Allocation Id Update (#38065) * updated calc to sort keys * Update CHANGELOG.md * Allocation id update (#38242) * updated calc to sort keys * Update CHANGELOG.md * Update _client_manager_base.py * Update CHANGELOG.md (#38521) * Increment package version after release of azure-appconfiguration-provider (#38553) * Removing Allocation ID (#38555) * Removing Allocation ID * Remove constants * Update _client_manager_base.py --------- Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
allenkim0129
pushed a commit
to allenkim0129/azure-sdk-for-python
that referenced
this pull request
Nov 18, 2024
* Revert "Remove Telemetry from main (Azure#37783)" (Azure#37812) This reverts commit a65dfb2. * Allocation Id (Azure#37840) * Adding Telemetry * Telemetry Support * fixing formatting * Update _azureappconfigurationprovider.py * Update _azureappconfigurationproviderasync.py * formatting * changing doc style due to pylint-next * fixing kwargs docs * Formatting * Review comments * Changed label checking. * black format changes * pylint * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> * added space checks * Update conftest.py * moved telemetry to client wrapper * fixing format * updating after merge * fixing black issue * removing unused imports * AllocationId * Update CODEOWNERS * Update CODEOWNERS * fixing issues * Update _client_manager_base.py * Fixing configuration value empty in calc * fixing pylint * Update _constants.py * review comments * fixing allocation check * format fix --------- Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> * Python Provider 2.0.0b2 Changelog update (Azure#37860) * Update CHANGELOG.md * Update CHANGELOG.md * Increment package version after release of azure-appconfiguration-provider (Azure#37877) * Update _client_manager_base.py (Azure#38019) * App Config Allocation Id Update (Azure#38065) * updated calc to sort keys * Update CHANGELOG.md * Allocation id update (Azure#38242) * updated calc to sort keys * Update CHANGELOG.md * Update _client_manager_base.py * Update CHANGELOG.md (Azure#38521) * Increment package version after release of azure-appconfiguration-provider (Azure#38553) * Removing Allocation ID (Azure#38555) * Removing Allocation ID * Remove constants * Update _client_manager_base.py --------- Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
FabianMeiswinkel
added a commit
that referenced
this pull request
Nov 23, 2024
* Add 'change_feed_mode' to 'query_items_change_feed' API * remove unnecessary import * Fix lint * Updated CHANGELOG.md * Removed _feed_range.py * Addressed comments * Fixed lint * Add kwargs back to 'call'QueryItemsChangeFeed' * Fixed syntax error with f-string * Removed StrEnum to support earlier Python versions * Fixed f-string error * addressed comments * Addressed comments Also, enabled AllVersionsAndDelete mode for emulators * Removed unnecessary tests * Fix tests for emulator * Generating SDK with model renames (#38108) * Generating SDK with model name updates * Fixing the missed api name change for SDT * Updated the TypeSpec and re-generated the SDK with TranslationStatus id as string * Fixing TranslationIds and DocumentIds renames in patched methods * Updating changelog * [Identity][Monitor] Update live test setup (#37943) Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Clean-up cosmos test pipeline (#38126) Update cosmos test pipeline as it no longer needs that sub-config as the data comes from the service connection. Also update the config name to use default name of public. * Multi modal eval fix (#38134) * Initial-Commit-multimodal * Fix * Sync eng/common directory with azure-sdk-tools for PR 9092 (#37713) * Export the subscription data from the service connection * Update deploy-test-resources.yml --------- Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Removing private parameter from __call__ of AdversarialSimulator (#37709) * Update task_query_response.prompty remove required keys * Update task_simulate.prompty * Update task_query_response.prompty * Update task_simulate.prompty * Remove private variable and use kwargs * Add experimental tag to adv sim --------- Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> * Enabling option to disable response payload on writes (#37365) * Initial draft * Adding tests * Renaming parameter * Update container.py * Renaming test file * Fixing LINT issues * Update container.py * Update _base.py * Update _base.py * Fixing tests * Fixing tests * Adding support to disable response payload on write for AIO * Update CHANGELOG.md * Update _cosmos_client.py * Reacting to code review comments * Addressing code review feedback * Addressed CR feedback * Fixing pyLint errors * Fixing pylint errors * Update test_crud.py * Fixing svc regression * Update sdk/cosmos/azure-cosmos/azure/cosmos/aio/_container.py Co-authored-by: Anna Tisch <antisch@microsoft.com> * Reacting to code review feedback. * Update container.py * Update test_query_vector_similarity.py --------- Co-authored-by: Anna Tisch <antisch@microsoft.com> * deprecate azure_germany (#37654) * deprecate azure_germany * update * update * Update sdk/identity/azure-identity/azure/identity/_constants.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update --------- Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * Add default impl to handle token challenges (#37652) * Add default impl to handle token challenges * update version * update * update * update * update * Update sdk/core/azure-core/azure/core/pipeline/policies/_utils.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * Update sdk/core/azure-core/azure/core/pipeline/policies/_utils.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update * Update sdk/core/azure-core/tests/test_utils.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * Update sdk/core/azure-core/azure/core/pipeline/policies/_utils.py Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * update --------- Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> * Make Credentials Required for Content Safety and Protected Materials Evaluators (#37707) * Make Credentials Required for Content Safety Evaluators * fix a typo * lint, fix content safety evaluator * revert test change * remove credential from rai_service * addFeedRangesAndUseFeedRangeInQueryChangeFeed (#37687) * Add getFeedRanges API * Add feedRange support in query changeFeed Co-authored-by: annie-mac <xinlian@microsoft.com> * Update release date for core (#37723) * Improvements to mindependency dev_requirement conflict resolution (#37669) * during mindependency runs, dev_requirements on local relative paths are now checked for conflict with the targeted set of minimum dependencies * multiple type clarifications within azure-sdk-tools * added tests for new conflict resolution logic --------- Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> * Need to add environment to subscription configuration (#37726) Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * Enable samples for formrecognizer (#37676) * multi-modal-changes * fixes * Fix with latest * dict-fix * adding-protected-material * adding-protected-material * adding-protected-material * bumping-version * adding assets * Added image in simulator * Added image in simulator * bumping-version * push-asset * assets * pushing asset * remove-containt-on-key * asset * asset2 * asset3 * asset4 * adding conftest * conftest * cred fix * asset-new * fix * asset * adding multi-modal-without-tests * asset-from-main * asset-from-main * fix * adding one test only * new asset * tests,fix: Sanitizer should replace with enum value not enum name * test-asset * [AutoRelease] t2-containerservicefleet-2024-09-24-42036(can only be merged by SDK owner) (#37538) * code and test * Update CHANGELOG.md * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-dns-2024-09-25-81486(can only be merged by SDK owner) (#37560) * code and test * update-testcase * Update CHANGELOG.md * Update test_mgmt_dns_test.py --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-appconfiguration-2024-10-09-68726(can only be merged by SDK owner) (#37800) * code and test * update-testcase * Update pyproject.toml --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * code and test (#37855) Co-authored-by: azure-sdk <PythonSdkPipelines> * [AutoRelease] t2-servicefabricmanagedclusters-2024-10-08-57405(can only be merged by SDK owner) (#37768) * code and test * update-testcase * update-testcases --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-containerinstance-2024-10-21-66631(can only be merged by SDK owner) (#38005) * code and test * update-testcase * Update CHANGELOG.md * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [sdk generation pipeline] bump typespec-python 0.36.1 (#38008) * update version * update package.json * [AutoRelease] t2-dnsresolver-2024-10-12-16936(can only be merged by SDK owner) (#37864) * code and test * update-testcase * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * new asset after fix in conftest * asset * chore: Update assets.json * Move perf pipelines to TME subscription (#38020) Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> * fix * after-comments * fix * asset * new asset with 1 test recording only * chore: Update assets.json * conftest fix * assets change * new test * few changes * removing proxy start * added all tests * asset * fixes * fixes with asset * asset-after-tax * enabling 2 more tests * unit test fix * asset * new asset * fixes per comments * changes by black * merge fix * pylint fix * pylint fix * ground test fix * fixes - pylint, black, mypy * more tests * docstring fixes * doc string fix * asset * few updates after Nagkumar review * fix * fix mypy --------- Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Nagkumar Arkalgud <nagkumar91@users.noreply.github.com> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com> Co-authored-by: Anna Tisch <antisch@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: kdestin <101366538+kdestin@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * azure-ai-evaluation release 1.0.0b5 2024-10-28 (#38138) * Update task_query_response.prompty remove required keys * Update task_simulate.prompty * Update task_query_response.prompty * Update task_simulate.prompty * Fix the api_key needed * Update for release * Black fix for file * Add original text in global context * Update test * Update the indirect attack simulator * Black suggested fixes * Update simulator prompty * Update adversarial scenario enum to exclude XPIA * Update changelog * Black fixes * Remove duplicate import * Fix the mypy error * Mypy please be happy * Updates to non adv simulator * accept context from assistant messages, exclude them when using them for conversation * update changelog * pylint fixes * pylint fixes * remove redundant quotes * Fix typo * pylint fix * Update broken tests * Include the grounding json in the manifest * Fix typo * Come on package * Release 1.0.0b5 * Notice from Chang * Remove adv_conv template parameters from the outputs --------- Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalg-work-mac.local> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> * open apiview for mgmt sdk (#38143) * [AutoRelease] t2-appplatform-2024-10-25-72111(can only be merged by SDK owner) (#38092) * code and test * changelog * changelog * changelog * Update CHANGELOG.md * Update _version.py * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * AzurePipelinesCredential | adding mlflow uri func (#36580) * Bug 3323988: Regex fix and indices correction for model download * fixing test case * adding mlflow tracking uri func * passing service context to azureml mlflow * final flow APC complete * modify host_url * fixing unit test cases * changing mock for urlparse * fixing the log msg * Update changelog (#38133) * Increment package version after release of azure-ai-evaluation (#38142) * Remove psycopg2-binary from dev_requirements.txt (#38103) Remove psycopg2-binary from dev_requirements.txt * [Evaluation] Error improve for service-based evaluator/simulator (#38106) * Error improve for service-based evaluator/simulator * update * update print summary * update * fix failed tests * fix black * update changelog * update * update version * AzMon exporter: Serialize complex log bodies to json and set dependency type to `gen_ai.system` instead of N/A (#37694) * Serialize complex log bodies to json and support gen_ai.system * Experimental tags on ADV scenarios (#38166) * Update task_query_response.prompty remove required keys * Update task_simulate.prompty * Update task_query_response.prompty * Update task_simulate.prompty * Fix the api_key needed * Update for release * Black fix for file * Add original text in global context * Update test * Update the indirect attack simulator * Black suggested fixes * Update simulator prompty * Update adversarial scenario enum to exclude XPIA * Update changelog * Black fixes * Remove duplicate import * Fix the mypy error * Mypy please be happy * Updates to non adv simulator * accept context from assistant messages, exclude them when using them for conversation * update changelog * pylint fixes * pylint fixes * remove redundant quotes * Fix typo * pylint fix * Update broken tests * Include the grounding json in the manifest * Fix typo * Come on package * Release 1.0.0b5 * Notice from Chang * Remove adv_conv template parameters from the outputs * Update chanagelog * Experimental tags on adv scenarios --------- Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalg-work-mac.local> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> Co-authored-by: Nagkumar Arkalgud <nagkumar@Mac.lan> * Sync eng/common directory with azure-sdk-tools for PR 9259 (#38160) * Run perf tests under federated auth Run the tests under the same federated auth used to deploy the tests and setup the variables needed to configure AzurePipelineCredential. * Fix indention for working directory --------- Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * Re-generated REST client after re-copying Swagger folder for `2024-10-01-preview`. (#38003) - Re-copied Swagger folder from https://github.com/Azure/azure-rest-api-specs/tree/release-machinelearningservices-Microsoft.MachineLearningServices-2024-10-01-preview/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-10-01-preview - Up to Azure/azure-rest-api-specs@4a10268 - Re-generated REST client for `v2024-10-01-preview` - Unit and e2e tests (in Live mode) passed for feature `workspaces` (Details in PR) Co-authored-by: Jing Li <jingli8@microsoft.com> * [Evaluation] Change RougeType to Enum (#38131) * Change RougeType to Enum * update test recording * update assets.json * try to update recordings to fix the failed tests * update * revert assets.json * update * Auto-enable Azure AI Inference instrumentation in Azure Monitor, update docs (#38071) * Auto-enable Azure AI Inference instrumentation in Azure Monitor, update docs * [AutoRelease] t2-redhatopenshift-2024-10-30-81004(can only be merged by SDK owner) (#38181) * code and test * update-testcase * Update CHANGELOG.md * Update _meta.json --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-resourcehealth-2024-10-30-72592(can only be merged by SDK owner) (#38186) * code and test * update-testcase * update-testcases * update-testcases --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-appconfiguration-2024-10-30-38914(can only be merged by SDK owner) (#38177) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-databox-2024-10-30-61405(can only be merged by SDK owner) (#38182) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-edgeorder-2024-10-30-57522(can only be merged by SDK owner) (#38178) * code and test * update-testcase * update-testcases --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-extendedlocation-2024-10-30-79235(can only be merged by SDK owner) (#38176) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-digitaltwins-2024-10-30-74766(can only be merged by SDK owner) (#38179) * code and test * update-testcase * Rename test_azure_mgmt_digitaltwins_test.py to disable_test_azure_mgmt_digitaltwins_test.py * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * Added get_arm_info (#38018) * Added get_arm_info * update * update * Update * Update release date * update * Update CHANGELOG.md (#38170) One column name updated to "New `max_token` for Generation" in CHANGLOG.md * Minor Readme fix (#38191) * Update task_query_response.prompty remove required keys * Update task_simulate.prompty * Update task_query_response.prompty * Update task_simulate.prompty * Fix the api_key needed * Update for release * Black fix for file * Add original text in global context * Update test * Update the indirect attack simulator * Black suggested fixes * Update simulator prompty * Update adversarial scenario enum to exclude XPIA * Update changelog * Black fixes * Remove duplicate import * Fix the mypy error * Mypy please be happy * Updates to non adv simulator * accept context from assistant messages, exclude them when using them for conversation * update changelog * pylint fixes * pylint fixes * remove redundant quotes * Fix typo * pylint fix * Update broken tests * Include the grounding json in the manifest * Fix typo * Come on package * Release 1.0.0b5 * Notice from Chang * Remove adv_conv template parameters from the outputs * Update chanagelog * Experimental tags on adv scenarios * Readme fix onbreaking change --------- Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalg-work-mac.local> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> Co-authored-by: Nagkumar Arkalgud <nagkumar@Mac.lan> * Minor fixes in vanilla OTel tracing sample (#38194) * Minor fixes in OTel tracing samples * Add test for get_arm_endpoints (#38196) * Add overloads for __call__ methods that accept query/response and conversation (#38097) * Add overloads for __call__ methods that take query/response and conversation * remove callable type hint * add docstrings/type hints * fix a typo * remove file * remove a bad param * add docs for relevance * fix some missing type hints * lint and run black * merge with main * fix some mypy errors, not all pylint * fix black errors * attempt to fix tests * fix retrieval * fix up tests and lint * fix some docstrings to mark some things as optional * [Monitor] Apply black formatting (#38129) Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [CI] Update autorest CI to use Python 3.9 (#38175) Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Eval qr json lines now has context from both turns and category if it exists (#38199) * Update task_query_response.prompty remove required keys * Update task_simulate.prompty * Update task_query_response.prompty * Update task_simulate.prompty * Fix the api_key needed * Update for release * Black fix for file * Add original text in global context * Update test * Update the indirect attack simulator * Black suggested fixes * Update simulator prompty * Update adversarial scenario enum to exclude XPIA * Update changelog * Black fixes * Remove duplicate import * Fix the mypy error * Mypy please be happy * Updates to non adv simulator * accept context from assistant messages, exclude them when using them for conversation * update changelog * pylint fixes * pylint fixes * remove redundant quotes * Fix typo * pylint fix * Update broken tests * Include the grounding json in the manifest * Fix typo * Come on package * Release 1.0.0b5 * Notice from Chang * Remove adv_conv template parameters from the outputs * Update chanagelog * Experimental tags on adv scenarios * Readme fix onbreaking change * Add the category and both user and assistant context to the response of qr_json_lines * Update changelog --------- Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalg-work-mac.local> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> Co-authored-by: Nagkumar Arkalgud <nagkumar@Mac.lan> * Fix doc issues (#38204) * Evaluation: Remove `parallel` from composite evaluators (#38168) * Remove `parallel` from composite evaluators * update recording * update * output_dir check * fix the test recording * fix the failed unit-test * update changelog * update * fix black issue * revert output_path related change * Update sdk/evaluation/azure-ai-evaluation/CHANGELOG.md Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> --------- Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> * [Core] Allow operation-level tracing attributes (#38164) Our documentation advertises that the `tracing_attributes` keyword argument can be passed in at both the client constructor level and the operation/method level. This makes this actually the case. Per-operation customization of tracing attributes can help users mark/identify spans from specific operations when spans are handled through custom span processors. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 9281 (#38213) * package-properties are now populated with matrix configurations from their ci.yml if present * create new code path for generate-job-matrix.yml which combines Create-JobMatrix and the "distribute-packages-to-matrix" action to generate dynamic matrices for PRs --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com> * Sync eng/common directory with azure-sdk-tools for PR 9290 (#38223) * identify and resolve missing function GenerateMatrixForConfig * identify and resolve miss-used null-coalesce operator --------- Co-authored-by: Scott Beddall <scbedd@microsoft.com> * update (#38220) * [AutoRelease] t2-containerservicefleet-2024-10-31-68497(can only be merged by SDK owner) (#38221) * code and test * update-testcase * format * reformat --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * [BatchAI] deprecate azure-mgmt-batchai (#38226) * [ModelsRepository] deprecating azure-iot-modelrepository (#38225) * [ModelsRepository] deprecating iot-modelrepository * add changelog section * [ServerManager] deprecating azure-mgmt-servermanager (#38229) * [DocumentDB] deprecate azure-mgmt-documentdb (#38227) * [EH/SB] ran black (#38210) * ran black * fix pylint * black sb * pylint * spacing * Update randomization pattern for Adversarial simulation (#38211) * Update randomization pattern for Adversarial simulation * update changelog * amqp msg (#38122) * Implement live metrics filtering for charts (part 1) (#37998) * Update CODEOWNERS for graphrbac owner (#38236) Updating the owner of graphrbac to Laurent as Yuchao said they are not the owners. * Multi modal docstring improvements (#38193) * docstring-update * doc string updates * doc string updates * Increment package version after release of azure-core (#38240) * kwarg type hints (#38214) * [Evaluation] add environment variable for API token refresh rate (#38162) * use env var for azure token refresh interval * update changelog and set default value for env var * cast refresh rate to int * fix pylint error * fix tox black issue * [Evaluation] Default to non-randomized order of template parameters (#38239) * Default to non-randomized order of template parameters * small changelog update * resolve issue with language-settings handling additional service changes (#38216) * Reduce unnecessary delete calls to ARM for storage accounts (#38246) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * clean up unused python script (#38128) * Sync eng/common directory with azure-sdk-tools for PR 9288 (#38243) * Update Logging * Update eng/common/scripts/logging.ps1 --------- Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> * [Scheduler] deprecate azure-mgmt-scheduler (#38228) * [ServiceManagement] deprecate azure-servicemanagement-legacy (#38230) * [GraphRBAC] deprecating package (#38224) * [GraphRBAC] updating docs to point to replacement repo * update version file * fix link * Enable py2docfx docs gen tool, remove the dockerimage docs validation (#38085) * Enable py2docfx docs gen tool, remove the dockerimage docs validation * Remove the --no-venv-required flag from the command line which was a leftover copy/paste from the original PR * Change the version to a pre-release for testing as the released version doesn't appear to have these changes * Update py2docfx version since previous version had problems on Linux * Change the python command to add -u so the sdtout and stderr streams are unbuffered and we see the full output * Updates for feedback and to see what's going on with the output * Remove the Get-Content line which should have been removed in the last commit * Print the command output on actual different lines * Finish the sentence in the comment * Sync eng/common directory with azure-sdk-tools for PR 9294 (#38251) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * [core] add servicemanagement legacy to ci for release (#38253) * Session Token Management APIs (#36971) * merge from main and resolve conflicts * remove async keyword from changeFeed query in aio package * refactor * refactor * fix pylint * added public surface methods * pylint fix * fix * added functionality for merging session tokens from logical pk * fix mypy * added tests for basic merge and split * resolve comments * resolve comments * resolve comments * resolve comments * fix pylint * fix mypy * fix tests * add tests * fix pylint * fix and resolve comments * fix and resolve comments * Added isSubsetFeedRange logic * Added request context to crud operations, session token helpers * revert unnecessary change * Added more tests * Added more tests * Changed tests to use new public feed range and more test coverage for request context * Added more tests * Fix tests and add changelog * fix spell checks * Added tests and pushed request context to client level * Added async methods and removed feed range from request context * fix tests * fix tests and pylint * Reacting to comments * Reacting to comments * pylint and added hpk tests * reacting to comments * fix tests and mypy * fix mypy * fix mypy * reacting to comments * reacting to comments * reacting to comments * fix cspell * rename method to get_latest_session_token * reacting to reverted feed range * change based on the api review * Reacting to API review and adding samples. * Fixed pylint * Reacting to comments * Reacting to comments * Reacting to comments * Reacting to comments * Fix pydoc * Fix pydoc * reacting to comments * reacting to comments --------- Co-authored-by: annie-mac <xinlian@microsoft.com> * [AutoRelease] t2-network-2024-10-31-29845(can only be merged by SDK owner) (#38235) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [ServiceBus/EventHub] add service specific message annotations to receiver logs (#38090) * [ServiceBus] add service specific message annotations to receiver logs * add to eventhub + update readme logging to include thread formatting * only log service annotations header props * move logging to sdk layer * move msg logging into eh consumer * remove sb pyamqp recvr logs * black * Updating CODEOWNERS for Synapse (#38255) Wan Yang no longer uses the @wonner alias and uses @wanyang7. * Evaluation: Fix the `output_path` parameter of `evaluate` API doesn't support relative path (#38241) * Fix output_path parameter doesn't support relative path * add comments * fix the test * update * minor update * update * [synapse] deprecate azure-synapse (#38262) * [Synapse] deprecation azure-mgmt-synapse * update synapse rel date * [DocumentDB] update deprecation release date (#38265) * [CognitiveServices] deprecate vision packages (#38206) * deprecate computervision * deprecate vision face * contentmoderator * update release date * update changelog date * update release date * customvision * RAI service input sanitization (#38247) * escape eval inputs * new recordings and disable accidentally enabled test * save recordings again * save recordings again again * save recordings again again again * update groundedness threshold * Update sdk/evaluation/azure-ai-evaluation/tests/e2etests/test_builtin_evaluators.py Co-authored-by: Billy Hu <ninhu@microsoft.com> * correct new check --------- Co-authored-by: Billy Hu <ninhu@microsoft.com> * pass params from ci.yml to cosmos-sdk-client appropriately (#38272) * Fix __call__ Overload Types (#38238) * Fix __call__ overload issues * fix typing issue * make query required for groundednesspro * fix a malformatted docstring * fix some type hints and remove eval_last_turn from evaluators * fix optional import * comment out eval last turn section * Update deprecation_process.md (#38270) Adding a section on: - adding the artifact to the ci before release - skipping checks for other failing packages in the pipeline for release if needed * [DocumentDB] add changelog to manifest.ini (#38273) * [evaluation] Add support for using evaluate() with evaluators that have missing inputs (#38276) * Update evaluate to allow optional params + add tests * Record tests * Exclude optional params from 'missing inputs' warning * Add tests * Record tests * Fix linting errors * Merge from main and fix linting error * Add unit test for missing output * Update convo test to assert per turn results * Run linting * Add test data * Re-record test * disabled black in pyproject.toml for all packages (#38271) * [AutoRelease] t2-postgresqlflexibleservers-2024-10-30-49242(can only be merged by SDK owner) (#38188) * code and test * update-testcase * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-devtestlabs-2024-11-04-17468(can only be merged by SDK owner) (#38286) * code and test * update-testcase * update changelog * Update CHANGELOG.md * Update _version.py * Update setup.py --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * [AutoRelease] t2-sql-2024-10-03-42323(can only be merged by SDK owner) (#37698) * code and test * Update CHANGELOG.md * Update sdk/sql/azure-mgmt-sql/CHANGELOG.md * Update sdk/sql/azure-mgmt-sql/CHANGELOG.md * update-testcase * fix generated samples * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [EventHub] add ssl_context kwarg to clients (#37702) * remove verify from pyamqp JWTToken * add ssl_context kwarg * add tests * fix merge * fix failing/lint/mypy * lint * separate ssl_context property from conn verify * make sb changes * add tests * changelog * black * Update CHANGELOG.md (#38301) * download_file is fully annotated (#38284) * Release azure-monitor-opentelemetry-exporter (#38310) * Increment package version after release of azure-monitor-opentelemetry (#38308) * Eval/bugfix/content safety parallel (#38307) * fix cs eval * recordings and cl * target newly released proxy version (#38282) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * [Storage] Added connection pool note to `max_concurrency` kwarg for upload/download APIs (#38254) * Sync eng/common directory with azure-sdk-tools for PR 9308 (#38311) Remove unnecessary Resolve-Path in Get-PrPkgProperties Co-authored-by: Scott Beddall <scbedd@microsoft.com> * Version/location updates for stress script usage (#38281) Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> * [AutoRelease] t2-loganalytics-2024-11-04-45063(can only be merged by SDK owner) (#38292) * code and test * update-testcase * fix generated samples * update version --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-automation-2024-11-04-74277(can only be merged by SDK owner) (#38294) * code and test * update-testcase * Update CHANGELOG.md --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> * Broker on mac support (#38274) * Broker on mac support * update * update * update * update * update * update readme * update * Add firewallsku as ManagedNetwork property (#37885) * Generated REST client for upcoming API version `v2024-10-01-preview`. - Created Swagger folder `2024-10-01-preview` by copying from the same one in GitHub project `azure-rest-api-specs` - https://github.com/Azure/azure-rest-api-specs/tree/release-machinelearningservices-Microsoft.MachineLearningServices-2024-10-01-preview/specification/machinelearningservices/resource-manager/Microsoft.MachineLearningServices/preview/2024-10-01-preview - Up to Azure/azure-rest-api-specs#30776 - Safe to merge in for not bumping up callers' API versions with it - Cannot bump up before registering it for RPs in selected regions - Added tag `v2024-10-01-preview` to `readme.md` - Generated REST client for `v2024-10-01-preview` * Initial commit * Initial commit * add new test for firewallsku * add new test for firewallsku * remove irrelevant changes * add addressprefix changes * address review comments * address review comments * reset the file in rest client * address review comments --------- Co-authored-by: Jing Li <jingli8@microsoft.com> Co-authored-by: Nethra Sashikar <nsashikar@microsoft.com> * [AutoRelease] t2-managementgroups-2024-11-04-45946(can only be merged by SDK owner) (#38291) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-managedservices-2024-11-04-44075(can only be merged by SDK owner) (#38287) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-marketplaceordering-2024-11-04-08673(can only be merged by SDK owner) (#38288) * code and test * update-testcase * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-servicebus-2024-11-04-58886(can only be merged by SDK owner) (#38293) * code and test * update-testcase * update version --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> * [Synapse] azure-synapse post deprecation (#38315) * [Cognitive Services] vision post-deprecation (#38304) * [Cognitive Services] vision post-deprecation * black on active cs packages * [Cosmos] documentdb post deprecation (#38314) * [sdk generation pipeline] fix logic to extract swagger file (#38334) * fix logic to extract swagger file * fix logic to extract swagger file * Update deprecation_process.md for Verify Readmes failure (#38333) Adding a section for Verify Readmes failure following #37975 . * Increment package version after release of azure-identity-broker (#38337) * Edit pass on Azure Identity Broker README (#38339) * Edit pass on Azure Identity Broker README * Change version * [Core] Deprecate OpenCensus tracing plugin (#37975) Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * [Core] servicemanagement-legacy post deprecation (#38319) * Prompt support for Inference SDK (#37917) * Prompty support within Azure AI Inference SDK * Fix unit test * Address PR feedback with copyright, merge PromptConfig to PromptTemplate * Add comment and set model_name as optional * Bug fixes * Updated parameter names from PM feedbacks * Improve sample code and unit tests * Update readme and comments * Rename files * Address PR comment * add Pydantic as dependency * Fix type errors * Fix spelling issues * Address PR comments and fix linter issues * Fix type import for "Self" * Change to keyword-only constructor and fix linter issues * Rename function `from_message` to `from_str`; `render` to `create_messages` * Change from `from_str` to `from_string` * Merge latest code from `microsoft/prompty` and resolve linter issues * Fix PR comment * Fix PR comments * Remove a defunct variable from docindex.yml (#38342) * Fix errors from sphinx and mypy * Changed parameter to `mode` Since `change_feed_mode` was only used for `query_items_change_feed`, it doesn't have to be specified. `mode` should be good enough. * Fixed typo * Changed 'mode' to be string type * Reverted necessary type def * Addressed comments * Added samples for change_feed_mode * Addressed comments * Removed unnecessary docstring * Remove mode if 'continuation' was in override definition * add test samples tracking (#38502) * add test samples tracking * add samples tracking to csv/html/md reports * fix for catastrophic pipeline failure * Add OpenTelemetry LoggingHandler conditionally (#38549) * Add helpers to log a GitHub "notice" (#38574) Co-authored-by: Mike Harder <mharder@microsoft.com> * [AutoRelease] t2-cosmosdb-2024-11-14-60943(can only be merged by SDK owner) (#38531) * code and test * update-testcase --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-mysqlflexibleservers-2024-11-05-47456(can only be merged by SDK owner) (#38329) * code and test * update-testcase * update-format --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * [AutoRelease] t2-netapp-2024-11-08-58381(can only be merged by SDK owner) (#38411) * code and test * Update CHANGELOG.md * Update CHANGELOG.md * assets * update-format --------- Co-authored-by: azure-sdk <PythonSdkPipelines> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> * Shrike (#38560) * Datastore auth bug (#38586) * Increment package version after release of azure-search-documents (#38593) * Merge App Config Provider Beta to Main (#38579) * Revert "Remove Telemetry from main (#37783)" (#37812) This reverts commit a65dfb2. * Allocation Id (#37840) * Adding Telemetry * Telemetry Support * fixing formatting * Update _azureappconfigurationprovider.py * Update _azureappconfigurationproviderasync.py * formatting * changing doc style due to pylint-next * fixing kwargs docs * Formatting * Review comments * Changed label checking. * black format changes * pylint * Update sdk/appconfiguration/azure-appconfiguration-provider/azure/appconfiguration/provider/_azureappconfigurationprovider.py Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> * added space checks * Update conftest.py * moved telemetry to client wrapper * fixing format * updating after merge * fixing black issue * removing unused imports * AllocationId * Update CODEOWNERS * Update CODEOWNERS * fixing issues * Update _client_manager_base.py * Fixing configuration value empty in calc * fixing pylint * Update _constants.py * review comments * fixing allocation check * format fix --------- Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> * Python Provider 2.0.0b2 Changelog update (#37860) * Update CHANGELOG.md * Update CHANGELOG.md * Increment package version after release of azure-appconfiguration-provider (#37877) * Update _client_manager_base.py (#38019) * App Config Allocation Id Update (#38065) * updated calc to sort keys * Update CHANGELOG.md * Allocation id update (#38242) * updated calc to sort keys * Update CHANGELOG.md * Update _client_manager_base.py * Update CHANGELOG.md (#38521) * Increment package version after release of azure-appconfiguration-provider (#38553) * Removing Allocation ID (#38555) * Removing Allocation ID * Remove constants * Update _client_manager_base.py --------- Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> * batching adjustments for create-prjobmatrix (#38597) Co-authored-by: Scott Beddall <scbedd@microsoft.com> * [EG] resource notification event (#38100) * rn * update * update * bump * black * Updated doc strings * Merged main * Addressed comments * Revert "Merged main" This reverts commit 217dabc. * Added comment why it is safe to raise exception if mode was missing * Added comment why it is safe to raise exception if mode was missing * Moved the feature update log under unreleased features * Add missing period in changelog --------- Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: hamshavathimunibyraiah <125092972+hamshavathimunibyraiah@users.noreply.github.com> Co-authored-by: Paul Van Eck <paulvaneck@microsoft.com> Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com> Co-authored-by: Waqas Javed <7674577+w-javed@users.noreply.github.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com> Co-authored-by: Nagkumar Arkalgud <nagkumar91@users.noreply.github.com> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalgworkmac.lan> Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com> Co-authored-by: Anna Tisch <antisch@microsoft.com> Co-authored-by: Xiang Yan <xiangsjtu@gmail.com> Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com> Co-authored-by: annie-mac <xinlian@microsoft.com> Co-authored-by: Scott Beddall <45376673+scbedd@users.noreply.github.com> Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com> Co-authored-by: kdestin <101366538+kdestin@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <119990644+ChenxiJiang333@users.noreply.github.com> Co-authored-by: ChenxiJiang333 <v-chenjiang@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Nagkumar Arkalgud <nagkumar@naarkalg-work-mac.local> Co-authored-by: Kshitij Chawla <166698309+kshitij-microsoft@users.noreply.github.com> Co-authored-by: sanchez-alex <141684261+sanchez-alex@users.noreply.github.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Billy Hu <ninhu@microsoft.com> Co-authored-by: Liudmila Molkova <limolkova@microsoft.com> Co-authored-by: Nagkumar Arkalgud <nagkumar@Mac.lan> Co-authored-by: Jing Li <u9009@outlook.com> Co-authored-by: Jing Li <jingli8@microsoft.com> Co-authored-by: changliu2 <99364750+changliu2@users.noreply.github.com> Co-authored-by: Yalin Li <yall@microsoft.com> Co-authored-by: Scott Beddall <scbedd@microsoft.com> Co-authored-by: swathipil <76007337+swathipil@users.noreply.github.com> Co-authored-by: Libba Lawrence <llawrence@microsoft.com> Co-authored-by: slister1001 <103153180+slister1001@users.noreply.github.com> Co-authored-by: Matthew Metcalf <mrm9084@gmail.com> Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com> Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com> Co-authored-by: James Suplizio <jasupliz@microsoft.com> Co-authored-by: MilesHolland <108901744+MilesHolland@users.noreply.github.com> Co-authored-by: Diondra <16376603+diondrapeck@users.noreply.github.com> Co-authored-by: Peter Wu <162184229+weirongw23-msft@users.noreply.github.com> Co-authored-by: Nethra C Sashikar <sashikarnethra@gmail.com> Co-authored-by: Nethra Sashikar <nsashikar@microsoft.com> Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com> Co-authored-by: Scott Addie <10702007+scottaddie@users.noreply.github.com> Co-authored-by: David Wu <YusakuNo1@users.noreply.github.com> Co-authored-by: Krista Pratico <krpratic@microsoft.com> Co-authored-by: Mike Harder <mharder@microsoft.com> Co-authored-by: Audunn Baldvinsson <audunn.baldvinsson@netapp.com> Co-authored-by: Amit Chauhan <70937115+achauhan-scc@users.noreply.github.com> Co-authored-by: Avani Gupta <avanigupta@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a65dfb2.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines