Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Common Matrix Generation #38324

Merged
merged 14 commits into from
Nov 19, 2024
Merged

Use Common Matrix Generation #38324

merged 14 commits into from
Nov 19, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 5, 2024 •
edited
Loading

Using the same methodology as what was implemented for js - pullrequest.

@scbedd scbedd self-assigned this Nov 5, 2024
@scbedd scbedd marked this pull request as ready for review November 15, 2024 21:56
@scbedd
Copy link
Member Author

scbedd commented Nov 15, 2024

/check-enforcer override

Overriding the Analyze failure. The touched files are failing mypy, but not in a way that is introduced by this PR.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@scbedd scbedd mentioned this pull request Nov 16, 2024
Merged
@scbedd
Copy link
Member Author

scbedd commented Nov 18, 2024

/check-enforcer override

The failures are actual test failures in attestation package. They are running because this PR also simplifies the platform-matrices across the repo, and one of the changed service-level folders was attestation. Going to merge this PR.

@scbedd
Copy link
Member Author

scbedd commented Nov 18, 2024

Confirmed via manual invocation that the nightly alpha builds are building properly. Going to ignore the build failures and merge.

@scbedd
Copy link
Member Author

scbedd commented Nov 18, 2024

/check-enforcer override

No fault of the matrix methodology adjustment, we just have actual analyze and test failures in the updated packages.

@scbedd scbedd enabled auto-merge (squash) November 18, 2024 23:30
@scbedd scbedd disabled auto-merge November 19, 2024 00:32
@scbedd scbedd merged commit 67aa17f into Azure:main Nov 19, 2024
25 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbp benbp benbp approved these changes

@weshaggard weshaggard Awaiting requested review from weshaggard weshaggard is a code owner

@mccoyp mccoyp Awaiting requested review from mccoyp mccoyp is a code owner

@pvaneck pvaneck Awaiting requested review from pvaneck pvaneck is a code owner

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99 xiangyan99 is a code owner

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger is a code owner automatically assigned from Azure/azure-sdk-write-identity

@christothes christothes Awaiting requested review from christothes christothes is a code owner automatically assigned from Azure/azure-sdk-write-identity

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner automatically assigned from Azure/azure-sdk-write-identity

@mpodwysocki mpodwysocki Awaiting requested review from mpodwysocki mpodwysocki is a code owner automatically assigned from Azure/azure-sdk-write-identity

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan is a code owner automatically assigned from Azure/azure-sdk-write-identity

Assignees

@scbedd scbedd

Labels
None yet
Projects
Azure SDK EngSys 🚢🎉
Status: 🎊 Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scbedd @azure-sdk @benbp