Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EH&SB] Improved comments #38950

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[EH&SB] Improved comments #38950

wants to merge 2 commits into from

Conversation

kashifkhan
Copy link
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@kashifkhan
Copy link
Member Author

/azp run python - eventhub - tests

@kashifkhan
Copy link
Member Author

/azp run python - servicebus - tests

@kashifkhan
Copy link
Member Author

/azp run python - eventhub - perf

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kashifkhan
Copy link
Member Author

/azp run python - servicebus -perf

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@kashifkhan
Copy link
Member Author

/azp run python - servicebus - perf

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kashifkhan
Copy link
Member Author

/azp run python - eventhub - perf

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch Awaiting requested review from annatisch annatisch will be requested when the pull request is marked ready for review annatisch is a code owner

@swathipil swathipil Awaiting requested review from swathipil swathipil will be requested when the pull request is marked ready for review swathipil is a code owner

@l0lawrence l0lawrence Awaiting requested review from l0lawrence l0lawrence will be requested when the pull request is marked ready for review l0lawrence is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Event Hubs Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashifkhan @azure-sdk